C# winform how to convert a string entered by the user to datetime so it can be inserted to SQL server

Question

2.50/5 (2 votes)

See more:

Hi,
I have a masked textbox in my form where the user enters the date as dd/MM/yyyy
and then this value is inserted into a sql server table.
I'm getting the following error when the query is executed:

the conversion of a varchar data type to a datetime data type resulted in an out-of-range value

I have tried many ways and tried to look for similar issues online and tried the fixes/answers but I'm still getting the error.
The error only happens when the 'dd' entered is higher than 12 so i assume that the sql server is taking that value as the MM instead of dd.
Below is what I tried.

What I have tried:

C#

Datetime receivedDate = DateTime.ParseExact(receivedDate.Text, "dd/MM/yyyy", System.Globalization.CultureInfo.InvariantCulture);

The insert statement is as follows:

SQL

string query = "INSERT INTO dateTbl(recD) VALUES('" + receivedDate + "')"

Posted 4-Mar-19 23:40pm

xTMx9

Updated 4-Mar-19 23:50pm

Add a Solution

Comments

Richard MacCutchan 5-Mar-19 5:47am

why are you using a TextBox rather than a DateTimePicker?

xTMx9 5-Mar-19 6:58am

I'm using a TextBox because there are many textboxes in the form and the user has to be fast in entering the data and switching from one to another so figured having a masked textbox would be faster.
I have not used DateTimePicker control much before so I'm not sure if text can be entered like that of a textbox or have to always choose from the calendar.

Richard MacCutchan 5-Mar-19 7:28am

Do you really believe that the average user can type a date in your specific format faster than he/she can click on a control?
And there is an easy way to find out what features this control supports.

xTMx9 6-Mar-19 4:03am

only a few users use that form and its faster for them that way, "Enter" from previous box, type in bunch of numbers quick then Enter, rather than clicking on a control

2 solutions

Solution 2

See DateTimePicker Class (System.Windows.Forms) | Microsoft Docs[^].

Posted 4-Mar-19 23:51pm

Richard MacCutchan

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Accepted Answer · 2019-03-04T23:45:00

Solution 1

Don't use a concatenated string in your query. Use a parameterised query instead.

If that doesn't completely solve your problem (it should) then try formatting your date as yyyy-Mmm-dd

Posted 4-Mar-19 23:45pm

CHill60

Comments

xTMx9 5-Mar-19 6:56am

Had to edit the code and using a parameterised query solved the problem, thanks.