Click here to Skip to main content
15,896,154 members

Finally block resets stacktrace

inbox_aa asked:

Open original thread
I encountered an Finally block issue. my try-catch-finally code in CatchAndRethrowImplicitly2() needs to rethrowing an exception, if there is not finally block, the stacttrace content did contains the original exception information, however, if it inlcuded the Finally block to clean up the resources, the exception's the original exception's stacktrace was gone. here is my code:

C#
using System;
using System.Collections.Generic;
using System.Text;
using System.Data.SqlClient;
using System.Data;

namespace UsageLibrary
    {
    
    class TestsRethrow
        {
        static void Main()
            {
            TestsRethrow testRethrow = new TestsRethrow();
            testRethrow.CatchException();
            }

        void CatchException()
            {

            try
                {
                CatchAndRethrowImplicitly2();
                }
            catch (Exception e)
                {
                Console.WriteLine("{0}Implicitly 2 specified:{0}{1}",
                   Environment.NewLine, e.StackTrace);
                }
            }

        void CatchAndRethrowImplicitly2()
            {
            SqlDataReader dr = null;

            try
                {
                SqlConnection conn = new SqlConnection("Data Source=.;Initial Catalog=AdventureWorks2008R2;Integrated Security=True");
                SqlCommand commd = new SqlCommand();
                commd.Connection = conn;
                commd.CommandType = CommandType.Text;
                commd.CommandText = "select [Name] from [AdventureWorks2008R2].[Sales].[Store]";
                if (conn.State == ConnectionState.Closed)
                    conn.Open();
                dr=commd.ExecuteReader();
                CatchAndRethrowImplicitly();
                }
            catch //(Exception ex)
                {
                throw;
                }
            finally // <-- if comment this block, stacktrace content is reset.
                {
                dr.Close();
                }
            }
        void CatchAndRethrowImplicitly()
            {
            try
                {
                ThrowException();
                }
            catch (Exception e)
                {
                throw;
                }
            }

        void ThrowException()
            {
            throw new ArithmeticException("illegal expression");
            }
        }
    }
Tags: C#

Plain Text
ASM
ASP
ASP.NET
BASIC
BAT
C#
C++
COBOL
CoffeeScript
CSS
Dart
dbase
F#
FORTRAN
HTML
Java
Javascript
Kotlin
Lua
MIDL
MSIL
ObjectiveC
Pascal
PERL
PHP
PowerShell
Python
Razor
Ruby
Scala
Shell
SLN
SQL
Swift
T4
Terminal
TypeScript
VB
VBScript
XML
YAML

Preview



When answering a question please:
  1. Read the question carefully.
  2. Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
  3. If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
  4. Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.
Let's work to help developers, not make them feel stupid.
Please note that all posts will be submitted under the http://www.codeproject.com/info/cpol10.aspx.



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900