JavaScript random number if statement problem

Question

5.00/5 (1 vote)

See more:

Hi, I have been trying to get a system working where a random number is calculated, then a statement is written to the screen depending on the number that was generated, so in theory it should put a random statement on the screen when the page is refreshed.
However, When i refresh the page it always prints the first statement, and no others, There are no error's so i cannot work out why it is like this. Here is my code:

JavaScript

var fact;
	fact = Math.ceil(Math.random()*4)
	
	if (fact = 1) {
		document.write('Hi');
	}else if(fact = 2){
		document.write('Nope');

So basically there are two more statements after that, But i cant understand why it only writes the first statement, and no others.

Posted 16-Nov-12 5:28am

Corrigan_sam

Add a Solution

Comments

deepak.m.shrma 18-Nov-12 22:26pm

LOL.. :-D jst a silly mistake. every beginner face in starting :-)

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-11-16T05:34:00

Solution 2

It's pretty easy to fix - are you sure you can't see it yourself?

Ok:

JavaScript

if (fact = 1) {

Becomes

JavaScript

if (fact == 1) {

We've all done it! :laugh:

Posted 16-Nov-12 5:34am

OriginalGriff

Comments

Corrigan_sam 16-Nov-12 11:39am

Ahh man thanks a lot, I knew it would be something simple! At least there's websites like this one to help me learn!

OriginalGriff 16-Nov-12 11:45am

You're welcome! As I said, we've all done it. The other annoying "goodie" is
if (myVariable == 1);
DoThis();

:doh:

Corrigan_sam 16-Nov-12 11:49am

Haha yea, Its good to have people like you on these websites, Thanks again :)

deepak.m.shrma 18-Nov-12 22:25pm

Lol... :-P

Thomas Daniels · Accepted Answer · 2012-11-16T05:31:00

Change it into this:

JavaScript

var fact;
	fact = Math.ceil(Math.random()*4)
	
	if (fact == 1) {
		document.write('Hi');
	}else if(fact == 2){
		document.write('Nope');

With an == operator, you compare objects and with an = operator, you set the value of an object.
In your code, you didn't compare the two variables, but you did set the fact variable to 1 in your first if statement.

JavaScript random number if statement problem

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us