Click here to Skip to main content
15,891,423 members

problem with 'if else' in c# winform

Ese Ochuko asked:

Open original thread
hi friends;
i am having a problem working with my loging form which i design in winform here is my code
C#
private void btnLogin_Click(object sender, EventArgs e)
      {
          user = txtUsername.Text;
          pass = txtPassword.Text;
          role = cbRole.Text;
          SqlConnection con = new SqlConnection();
          con.ConnectionString = "Data Source=ESE-HP;Initial Catalog=PIMS;User ID=sa;PWD=ese";
          con.Open();
          SqlCommand cmd = new SqlCommand("select * from employee where  occupation = '" + role + "' and password = '" + pass + "' and username = '" + user + "' ", con);
          SqlDataReader dr = cmd.ExecuteReader();


          while (dr.Read())
          {
              if ((dr["Password"].ToString() == pass && dr["Username"].ToString() == user && dr["Occupation"].ToString() == role))
              {
                  messageBox.Show("Login Successful");
              }

             else
              {
                  MessageBox.Show("LOGIN NOT SUCCESSFUL );
              }
            }
      }


i have a login form that has username, password and role textbox when i run the code and enter my correct credentials, it displays the message "LOGIN SUCCESSFUL", but if i did not enter the correct information in the boxes, it wont display the 'else' message which is "LOGIN NOT SUCCESSFUL", i do not know what the problem is, can someone help me out? thanks.
Tags: C#

Plain Text
ASM
ASP
ASP.NET
BASIC
BAT
C#
C++
COBOL
CoffeeScript
CSS
Dart
dbase
F#
FORTRAN
HTML
Java
Javascript
Kotlin
Lua
MIDL
MSIL
ObjectiveC
Pascal
PERL
PHP
PowerShell
Python
Razor
Ruby
Scala
Shell
SLN
SQL
Swift
T4
Terminal
TypeScript
VB
VBScript
XML
YAML

Preview



When answering a question please:
  1. Read the question carefully.
  2. Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
  3. If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
  4. Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.
Let's work to help developers, not make them feel stupid.
Please note that all posts will be submitted under the http://www.codeproject.com/info/cpol10.aspx.



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900