Click here to Skip to main content
15,896,207 members

loading data to combo box with out blanks

Sparky12488 asked:

Open original thread
Hi,

im have a problem with some code to load data from my MSSQL server in to a combo box. the code works and it loads the data but when i select the item from the drop down it loads all the blank space from the SQL table aswell.

this is my code:

C#
private void loadlocationcombobox()
        {
            string constr = ConfigurationManager.ConnectionStrings  ["SQLServer"].ConnectionString;
            string query = "select location_name from dbo.Location";

            SqlConnection con = new SqlConnection(constr);
            SqlCommand command = new SqlCommand(query, con);
            con.Open();
            SqlDataReader sqlreader = command.ExecuteReader();



            try
            {
                while (sqlreader.Read())
                {
                    comboLocation.Items.Add(sqlreader[0]);
                }

            }
            catch (Exception ex)
            {
                MessageBox.Show("A error has occurred: " + ex.Message, "error", MessageBoxButtons.OK, MessageBoxIcon.Error);
            }
            finally
            {
                sqlreader.Close();
                con.Close();
            }
        }



any help would be great as i have been looking at the code but just cant see how to fix it.
Tags: C#

Plain Text
ASM
ASP
ASP.NET
BASIC
BAT
C#
C++
COBOL
CoffeeScript
CSS
Dart
dbase
F#
FORTRAN
HTML
Java
Javascript
Kotlin
Lua
MIDL
MSIL
ObjectiveC
Pascal
PERL
PHP
PowerShell
Python
Razor
Ruby
Scala
Shell
SLN
SQL
Swift
T4
Terminal
TypeScript
VB
VBScript
XML
YAML

Preview



When answering a question please:
  1. Read the question carefully.
  2. Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
  3. If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
  4. Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.
Let's work to help developers, not make them feel stupid.
Please note that all posts will be submitted under the http://www.codeproject.com/info/cpol10.aspx.



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900