My querys are not executing

Question

1.00/5 (2 votes)

See more:

My project is about e municipality where online permission system for the users
I am performing a demo
The queries are executed for the one week and now No query is executing
What will be the problem
Please help me

PHP

php
    include('functions.php');
    $id = $_GET['id'];

$query = "SELECT * FROM `listtap` WHERE `id` = '$id'; ";
    if(count(fetchAll($query)) > 0)
    {
        foreach(fetchAll($query) as $row)
        {
            $id=$row['id'];
            $name=$row['name'];
            $taxno=$row['taxno'];
            $noc=$row['noc'];
            $c=$row['c'];
            $date=$row['date'];    
            $query = "INSERT INTO `approvedtap` (`id`, `name`, `taxno`, `noc`,`c`,`date`) VALUES ('$id','$name','$taxno','$noc','$c','$date') ;";
        }
        $query .= "DELETE FROM `listtap` WHERE `listtap`.`id` = '$id';";       
        if(performQuery($query)){
            echo "Account has been rejected.";header("location:homeelectricity.php");
        }else{
            echo "Unknown error occured. Please try again.";
        }
}

What I have tried:

Execution problem
For the above program i have unknown error

Posted 30-Oct-19 8:12am

Member 14636305

Updated 30-Oct-19 11:03am

Richard MacCutchan

v6

Add a Solution

Comments

Richard Deeming 30-Oct-19 14:16pm

Your database has probably been obliterated because your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

PHP: SQL Injection - Manual[^]

Richard Deeming 30-Oct-19 14:17pm

And if you want someone to help you fix an error, you need to tell us what the error is.

Click the green "Improve question" link and add the full details of the error to your question. Remember to indicate which line of code it's thrown from.

Dave Kreskowiak 30-Oct-19 14:42pm

It could be any one or more of about a couple dozen things. But since you give no information about the errors you're getting, nor supplied the "performQuery" code, it's impossible for anyone to tell you what's going on.

Richard MacCutchan 30-Oct-19 15:50pm

You never execute the INSERT queries.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

MadMyche · Answer 1 · 2019-10-30T09:37:00

Good thing that is erroring now, as this script has several SQL Injection Vulnerabilities

PHP

$query = "SELECT * FROM `listtap` WHERE `id` = '$id'; ";
$query = "INSERT INTO `approvedtap` (`id`, `name`, `taxno`, `noc`,`c`,`date`) VALUES ('$id','$name','$taxno','$noc','$c','$date') ";
$query = "DELETE FROM `listtap` WHERE `listtap`.`id` = '$id';";

NEVER EVER create queries by piecing together the commands and variables; you should always use Parameters, and this can be done with prepared statements

References:
PHP: Prepared statements and stored procedures - Manual[^]
PHP Prepared Statements[^]

Patrice T · Answer 2 · 2019-10-30T11:03:00

Quote:
My querys are not executing

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

phpdbg | php debugger[^]
Debugging techniques for PHP programmers[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

My querys are not executing

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0