Must declare the scalar variable "@".

Question

1.00/5 (1 vote)

See more:

I got this EROR:Must declare the scalar variable "@".
my program is 3 layer.
plz help me
this is dataAccess layer

C#

public int InsertObject(int objectID, string name, string typeObject,int number,string typeUnit)
{
SqlConnection con = new SqlConnection("Data Source=.;Initial Catalog=anbraProject;Integrated Security=True");
SqlCommand com = new SqlCommand();

com.CommandType = CommandType.Text;
com.CommandText = "INSERT INTO Objecttbl(objID,name,typeObj,num,typeUnit)VALUES(@objID,@name,(SELECT typeID FROM typeObjtbl WHERE nameType = @ nametype),@num,(SELECT typeUnitID FROM typeUnit WHERE nameUnit = @ nameUnit))";
com.Connection = con;
com.Parameters.AddWithValue("@objID", objectID);
com.Parameters.AddWithValue("@name", name);
com.Parameters.AddWithValue("@typeObj", typeObject);
com.Parameters.AddWithValue("@num", number);
com.Parameters.AddWithValue("@typeUnit", typeUnit);




con.Open();
int Result = com.ExecuteNonQuery();
con.Close();

  return Result;
}

this is Middle layer:

C#

public int InsertObject(int objectID, string name, string typeObject, int number, string typeUnit)
        {
            DataAccess.DataManager dm = new DataAccess.DataManager();
            return dm.InsertObject(objectID, name, typeObject, number, typeUnit);
        }

and This is Presentation layer:

C#

private void button1_Click(object sender, EventArgs e)
        {
            Middle.Middle m = new Middle.Middle();
            if (m.InsertObject(Int32.Parse(txtIDObj.Text), txtNameObj.Text, cboTypeObj.SelectedValue.ToString(), Int32.Parse(txtNumObj.Text), cbotypeUnit.SelectedValue.ToString()) == 1)
            {
                dataGridView1.DataSource = m.GetObjByName();
                dataGridView1.Refresh();
            }
            

        }

Posted 11-Jan-13 4:19am

f,amiri882

Add a Solution

Comments

Richard C Bishop 11-Jan-13 10:22am

You need to take the spaces out between the "@" and the variable name in your query. It should read: WHERE nameUnit = @nameUnit not WHERE nameUnit = @ nameUnit.

4 solutions

Solution 2

"INSERT INTO Objecttbl(objID,name,typeObj,num,typeUnit)VALUES(@objID,@name,(SELECT typeID FROM typeObjtbl WHERE nameType = @ nametype),@num,(SELECT typeUnitID FROM typeUnit WHERE nameUnit = @ nameUnit))";

Looks like SPACE is present in between @ & parameter name. Try:

@nametype<br />
@nameUnit

Posted 11-Jan-13 4:27am

Sandeep Mewara

Comments

Maciej Los 11-Jan-13 13:01pm

Good answer, my 5!

Solution 3

Change your query code from this

INSERT INTO Objecttbl(objID,name,typeObj,num,typeUnit)VALUES(@objID,@name,(SELECT typeID FROM typeObjtbl WHERE nameType = @ nametype),@num,(SELECT typeUnitID FROM typeUnit WHERE nameUnit = @ nameUnit))

To this

INSERT INTO Objecttbl(objID,name,typeObj,num,typeUnit)VALUES(@objID,@name,(SELECT typeID FROM typeObjtbl WHERE nameType = @nametype),@num,(SELECT typeUnitID FROM typeUnit WHERE nameUnit = @nameUnit))

You've also got @nametype and @nameUnit which you are not assigning any value to as well.

Posted 11-Jan-13 4:29am

David_Wimbley

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2013-01-11T05:29:00

In overall the parameter names in the SQL statement do not match the ones you use in your program. As already said by others, you cannot have spaces between the name and the @.

So have a try with something like:

C#

public int InsertObject(int objectID, string name, string typeObject,int number,string typeUnit)
        {
        SqlConnection con = new SqlConnection("Data Source=.;Initial Catalog=anbraProject;Integrated Security=True");
        SqlCommand com = new SqlCommand();
 
        com.CommandType = CommandType.Text;
        com.CommandText = @"
INSERT INTO Objecttbl(objID, name, typeObj, num, typeUnit) 
VALUES (@objID, 
        @name, 
       (   SELECT typeID 
           FROM typeObjtbl 
           WHERE nameType = @nametype),
       @num,
       (   SELECT typeUnitID 
           FROM typeUnit 
           WHERE nameUnit = @nameUnit)
       )";
        com.Connection = con;
        com.Parameters.AddWithValue("@objID", objectID);
        com.Parameters.AddWithValue("@name", name);
        com.Parameters.AddWithValue("@nametype", ???);
        com.Parameters.AddWithValue("@nameUnit", ???);
 
        con.Open();
        int Result = com.ExecuteNonQuery();
        con.Close();
 
        return Result;
  }

I marked the two parameter values with question marks since I'm not able to say what values you want to use for the parameters. The point is you have to define a value that you want to use in the querying part for tables typeObjtbl and typeUnit

PIEBALDconsult · Accepted Answer · 2013-01-11T04:23:00

Solution 1

@ nametype @ nameUnit
Maybe remove the SPACEs separating the @ from the name?

Posted 11-Jan-13 4:23am

PIEBALDconsult

Comments

f,amiri882 11-Jan-13 11:05am

I cleared space,but it still has this EROR

David_Wimbley 11-Jan-13 11:07am

It would help if you specify your error that you are getting, the crystal ball only gets us so far.

f,amiri882 11-Jan-13 11:34am

after clear space,I got this eror:
Must declare the scalar variable "@nametype".
Must declare the scalar variable "@nameUnit".

David_Wimbley 11-Jan-13 11:39am

wow

"You've also got @nametype and @nameUnit which you are not assigning any value to as well."

You need to add

com.Parameters.AddWithValue("@nameType", number);
com.Parameters.AddWithValue("@nameUnit", typeUnit);

Maciej Los 11-Jan-13 13:00pm

Good answer, +5!

f,amiri882 11-Jan-13 13:19pm

thanks alot,
may problem solved.

Must declare the scalar variable "@".

4 solutions

Solution 4

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us