T-SQL - stored procedure

Question

1.00/5 (1 vote)

See more:

SQL-Server-2005

How can I write this stored procedure that would check stockqty and print message if it goes down to zero? Currently I am getting error. Thanks.

Error:
Msg 102, Level 15, State 1, Procedure ValidateQty, Line 8
Incorrect syntax near ';'.
Msg 137, Level 15, State 2, Line 3
Must declare the scalar variable "@vStockqty".
Msg 137, Level 15, State 2, Line 5
Must declare the scalar variable "@Partid".
Msg 137, Level 15, State 2, Line 8
Must declare the scalar variable "@vStockqty".
Msg 137, Level 15, State 2, Line 9
Must declare the scalar variable "@Partid".
--------------------------------------------------------------------------------

SQL

IF EXISTS (SELECT name FROM SYSOBJECTS WHERE name = 'ValidateQty')
    BEGIN DROP PROCEDURE ValidateQty; END;
GO

CREATE PROCEDURE ValidateQty 
@vStockqty CHAR(10),
@Partid CHAR(10)
AS 
BEGIN 
-- No query required; test for positive value
END;
GO

-- testing block for ValidateQty  -- warn if the stockqty goes below 1
IF (@vStockqty < 1 (SELECT Stockqty
                  FROM Inventory
                  WHERE PartID = @Partid) )
BEGIN    

EXECUTE ValidateQty 0, @vStockqty;
 PRINT 'Stock quantity is below zero  for  ' + @Partid   ;
END;
GO

Posted 9-Mar-13 19:27pm

7prince

Add a Solution

Comments

Sandeep Mewara 10-Mar-13 3:26am

CREATE PROCEDURE ValidateQty
@vStockqty CHAR(10),
@Partid CHAR(10)
AS
BEGIN
-- No query required; test for positive value
END;

You have given end above. Remove it and see.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

gvprabu · Answer 1 · 2013-03-09T21:26:00

Hi,

Try some TSQL Basic Books for Creating Procedure....

I think, Sorry to say this, you are not having any basic T-SQL Programming Skills...

First Read about followings

Data Types (Quantity and all not a VARCHAR Data type, These are Numbers right).
Conditional Statements (IF, WHILE ...)
How and Where to use BEGIN...END , Go Statements...
Simple Stored Procedures

Check the links..

SQL Tutorials[^]

SQL

IF OBJECT_ID('ValidateQty') IS NOT NULL DROP PROCEDURE dbo.ValidateQty
GO
CREATE PROCEDURE ValidateQty 
@vStockqty INT,
@Partid INT
AS 
BEGIN 
	-- No query required; test for positive value
	-- testing block for ValidateQty  -- warn if the stockqty goes below 1
	SELECT @vStockqty = Stockqty 
	FROM Inventory
	WHERE PartID = @Partid
	
	IF @vStockqty < 1
	BEGIN    
		PRINT 'Stock quantity is below zero  for  ' + @Partid   ;
	END;
END;

EXECUTE ValidateQty 10, 121;

Regars,
GVPrabu

Maciej Los · Answer 2 · 2013-03-10T01:28:00

Check this:

SQL

CREATE PROCEDURE ValidateQty 
@vStockqty INT NOT NULL,
@Partid INT NOT NULL
AS 
BEGIN  
    IF (@vStockqty > 0)
    BEGIN
            SELECT Stockqty
            FROM Inventory
            WHERE PartID = @Partid)
        END
    ELSE
        BEGIN
            PRINT 'Stock quantity is below zero  for  ' + @Partid 
        END
END

Do you see the differences?

Khorshed Alam, Dhaka · Answer 3 · 2013-03-10T04:48:00

try this one:

IF EXISTS (
       SELECT NAME
       FROM   sys.procedures
       WHERE  NAME = 'ValidateQty'
   )
BEGIN
    DROP PROCEDURE ValidateQty;
END;
    GO
    
CREATE PROCEDURE ValidateQty
	@vStockqty CHAR(10),
	@Partid CHAR(10)
AS
	DECLARE @CurrentValue INT = (
	            SELECT Stockqty
	            FROM   Inventory
	            WHERE  PartID = @Partid
	        )
	
	-- testing block for ValidateQty  -- warn if the stockqty goes below 1
	IF (@CurrentValue -@vStockqty) < 1
	BEGIN
	    EXECUTE ValidateQty 0, @vStockqty;
	    PRINT 'Stock quantity is below zero  for  ' + @Partid ;
	END;
GO

T-SQL - stored procedure

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0