SqlDataReader/DataSet to Generic List Creation

Question

0.00/5 (No votes)

See more:

Hi,

I would like to know which is the best way of generating List of entity objects?
I am using following layers to fetch the data
presentation Layer->Service Layer->DAL (& Entity layer)

Way1:

get dataset from dqladpter.Fill()
apply linq to convert each dataTable row into a entity object
and convert into a List<entityclass>

Way2:

C#

while(sqldataReader.Read())
{
EntityClass ec = new EntityClass();
ec.Name = sqldataReader["Name"];
.
.
.
ListClass.Add(ec);
}

both way return the same results but i need which is the best way and why?
My thought is, Way2 might be best because it reduce the dataset memory size
Please clarify...
Regards,
--SJ

Posted 22-May-13 6:45am

codeninja-C#

Updated 22-May-13 19:03pm

v3

Add a Solution

Comments

Balimusi 22-May-13 13:54pm

This is entirely depending on your need and situation. If your purpose is solely returning data to your application, DataReader will be a good choice. DataReader is a forward-only read; it's fast.

However, there is situation where you need to use DataSet; for instance, if you need to transform the result-set into XML and to be sent over the wire via HTTP, where a DataReader cannot be serialized and cannot be passed between physical-tier boundaries.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

TheKarateKid · Answer 1 · 2013-05-22T08:00:00

You can try similar to this
First of all add similar method in inside Entity Class

C#

public EntityClass Fill(IDataReader row)
{
   return new EntityClass(row);
}


//you can write the helper method in business layer to convert to generic list
private GenericList<t> ConvertTo<t>(IDataReader reader)
                        where T : EntityClass, new()
        {
            GenericList<t> temp = new GenericList<t>();
            try
            {
                while (reader.Read())
                {
                    temp.Add((new T().Fill(reader)) as T);
                }
                return temp;
            }
            catch (Exception ex)
            {
                throw ex;
            }
            finally
            {
                reader.Close();
            }
        }
</t></t></t></t>

then you can invoke the business layer method from UI inturn invoke data access layer. DAL will return the data reader instance. This instance you can pass to ConverTo method to get the generic list. Hope this will give an hint
Thanks
Nilesh