Click here to Skip to main content
15,891,316 members

C# login check code not working correctly

anshulpui2 asked:

Open original thread
I want to create a loginpage for user and check whether they are admin or general user. i have written the following code. I think the logic is correct but I dont know why the output of the program is not correct. Please help me with this.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Configuration;
using System.Data;
using System.Data.SqlClient;

namespace Bidders_Joint
{
public partial class WebForm2 : System.Web.UI.Page
{
string constr = ConfigurationManager.ConnectionStrings["BiddersJoint"].ToString();
string password;
string type;
protected void Page_Load(object sender, EventArgs e)
{

}

protected void btnLogin_Click(object sender, EventArgs e)
{



SqlConnection con = new SqlConnection(constr);
SqlCommand cmd = new SqlCommand("select Password,Type from TABLE_USER where User_ID = @userid", con);
cmd.Parameters.AddWithValue("@userid",txtUserid.Text.ToString());
try
{
cmd.Connection.Open();
SqlDataReader dr = cmd.ExecuteReader();
while (dr.Read())
{
password = dr["Password"].ToString();
type = dr["Type"].ToString();
}
if ((password == txtPassword.Text.ToString()) && (type == "admin"))
{
Response.Redirect("administrator.aspx");
}

if ((password==txtPassword.Text.ToString()) && (type=="general"))
{
Response.Redirect("userspage.aspx");
}
else
{
lblMessage.Text = "wrong userid or password";
}


}
catch (Exception ex)
{

lblMessage.Text = ex.Message;
}
finally
{
cmd.Connection.Close();
}
}




}
}

output is always worng userid or password even when userid and password are correct
Tags: C#, ASP.NET

Plain Text
ASM
ASP
ASP.NET
BASIC
BAT
C#
C++
COBOL
CoffeeScript
CSS
Dart
dbase
F#
FORTRAN
HTML
Java
Javascript
Kotlin
Lua
MIDL
MSIL
ObjectiveC
Pascal
PERL
PHP
PowerShell
Python
Razor
Ruby
Scala
Shell
SLN
SQL
Swift
T4
Terminal
TypeScript
VB
VBScript
XML
YAML

Preview



When answering a question please:
  1. Read the question carefully.
  2. Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
  3. If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
  4. Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.
Let's work to help developers, not make them feel stupid.
Please note that all posts will be submitted under the http://www.codeproject.com/info/cpol10.aspx.



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900