Insert record by using class in asp.net

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

, +

hi
Any one can tell me am i right or not

I developed a software of payroll in asp.net 3.5
i use sql 2005,i use class to insert,update,delete.Code is like that
************

C#

public static SqlConnection con = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=|DataDirectory|\Business_Medical.mdf;Integrated Security=True;User Instance=True");
public static string Qurrystring;
 
public static void Save(string Qurrystring)
   {      
       con.Close();
       con.Open();
      SqlCommand cmd=new SqlCommand(Qurrystring,con);
      cmd.ExecuteNonQuery();
      cmd.Dispose();
      con.Close();
    }
public static void Modify(string Qurrystring)
   {
       con.Close();
       con.Open();
       SqlCommand cmd = new SqlCommand(Qurrystring, con);
       cmd.ExecuteReader();
       cmd.Dispose();
       con.Close();
   }

when i want to insert any record that time i do in my .aspx file

HTML

Main.Qurrystring = "INSERT INTO CityMaster(code,ename)VALUES("+Convert.ToInt16(txtcode.Text)+","+ txtename.Text +");
Main.Save(Main.Qurrystring);

Is that right way to develop dynamic website.

Posted 19-Aug-13 1:35am

dhiraj mane

Updated 19-Aug-13 1:43am

Maciej Los

v2

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

dhiraj mane · Answer 1 · 2013-08-20T20:59:00

Solution 4

but it work faster?
what should i do to make it fast?

Posted 20-Aug-13 20:59pm

dhiraj mane

Ali Haider Malik · Answer 2 · 2013-08-19T23:40:00

Solution 3

Use this method to avoid from SQL injection

C#

public static void Save()
{
            String Query=("INSERT INTO CityMaster(code,ename)VALUES(@code,@ename");
            SqlConnection Connection=new SqlConnection("Data Source=.\SQLEXPRESS;AttachDbFilename=|DataDirectory|\Business_Medical.mdf;Integrated Security=True;User Instance=True");
            SqlCommand Command = new SqlCommand(Query, Connection);
            Command.CommandTimeout = 30;
            Command.CommandType = CommandType.Text;
            Command.Parameters.AddWithValue("@code", txtcode.Text);//This is Parameter
            Command.Parameters.AddWithValue("@ename", txtename.Text);
            Command.ExecuteNonQuery();        
           Connection.Close();
}

Posted 19-Aug-13 23:40pm

Ali Haider Malik

Comments

dhiraj mane 20-Aug-13 7:35am

thanks bro but u can tell me why to use store procedures or inline query

Ali Haider Malik 20-Aug-13 7:47am

Is this was helpful for you?
store procedures save you from Hackers SQL injections.

dhiraj mane 20-Aug-13 7:51am

ok
can i use asp.net to develop ERP Software like 'Payroll'

Ali Haider Malik 20-Aug-13 8:01am

Yes why not. You can do everything which is possible in web development world.

dhiraj mane 21-Aug-13 2:44am

ok but it work faster?
what should i use to work fast?

dhiraj mane 21-Aug-13 2:54am

but it work faster?
what should i do to make it fast?

dhiraj mane 21-Aug-13 2:53am

but it work faster?
what should do to work fast?

Bala Selvanayagam 21-Aug-13 4:39am

You could use ASP.net(web forms) for payroll development and there are pros & cons. You may not be able to have rich UI features as windows environment unless you use some javascript frame works. Also the web forms needs to be post back most of the time and this may or may not be ideal for you.

If i were you, I will look into the reasons why the application should be web/ windows based

If it is going to be web then will use MVC based single page application with javascript frame works like Angular / knockout for rich user experience.

The performance of the web application is depends on your hosting environment and your optimisation of coding

dhiraj mane · Answer 3 · 2013-08-19T01:54:00

Solution 2

thanks but how to use stored procedures and why? do u have any example project link?

Posted 19-Aug-13 1:54am

dhiraj mane

Updated 19-Aug-13 1:59am

v2

Comments

Maciej Los 19-Aug-13 8:07am

This is not an answer. Please delete it to avoid down-voting. If you want to post a comment, please, use "Have a question or comment" widget.

dhiraj mane 20-Aug-13 5:06am

thanks but how to use stored procedures and why? do u have any example project link?

Maciej Los 20-Aug-13 5:12am

See updated answer ;)

dhiraj mane 20-Aug-13 7:43am

can i use asp.net to develop ERP Software like 'Payroll'

dhiraj mane 21-Aug-13 2:55am

but it work faster?
what should i do to make it fast?

Maciej Los · Answer 4 · 2013-08-19T01:48:00

Sorry, but you're doing it in wrong way. Why? Have ever heard about SQLInjection[^]? If not, please read these articles:
How To: Protect From SQL Injection in ASP.NET[^]
Stop SQL Injection Attacks Before They Stop You[^]

I would suggest you to use stored procedures.
For further information see here: could not open sql server connection[^]

Insert record by using class in asp.net

4 solutions

Solution 4

Solution 3

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us