Currency Conversion using IValueConverter

Question

0.00/5 (No votes)

See more:

Hi,

I am trying to convert a numeric value (Actually from a string variable i.e., "500000.000000000000") in a IValueConverter when my machines currency format was set to Spanish(Chile) in Region settings dialog which results in strange value something like "500,000,000,000,000,000.00" i don't know what actually wrong in my code.

My IValueConverter Converter

C#

public object Convert(object value, Type targetType, object parameter, System.Globalization.CultureInfo culture)
        {
            if (value == null)
                return string.Empty;
            string text = value.ToString();
            double dbl = 0.0;
            if (double.TryParse(text, out dbl))
                    text = dbl.ToString("N2", CultureInfo.InstalledUICulture);
            return text;
        }

Any guess why am getting this strange value?

Posted 30-Apr-15 1:38am

Gold$Coin

Add a Solution

2 solutions

Solution 1

How about something like this instead:

XML

<TextBox Text="{Binding Value, StringFormat=N2}" />
<TextBox Text="{Binding Value, StringFormat={}{0:#,#.00}}" />

Posted 30-Apr-15 2:06am

Kenneth Haugland

Comments

Gold$Coin 30-Apr-15 8:19am

The problem here is i can't specifically mention the string format because the template i am using is common for both string field and numeric field in my DataGrid since the columns are dynamically created. In my converter i will be parsing the converter value, if it is a numeric or double value i will be doing the stuff what i have specified above. so again i am having the above problem.

Kenneth Haugland 30-Apr-15 8:25am

My answer will (almost) give the same result as your valueconverter. You only check if the value is empty, and then turn out nothing.

Gold$Coin 5-May-15 1:12am

hi the below solution actually worked for me thanks a lot.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2015-04-30T03:03:00

When you don't pass an IFormatProvider to the TryParse method, it defaults to using CultureInfo.CurrentCulture[^]. By default, this uses the current regional settings - I suspect that "Spanish (Chile)" uses . as the thousands separator, and , as the decimal separator, so the value is parsed as 500000000000000000.

You're then using the InstalledUICulture[^] to format the value. This is the culture installed with the OS, and will not reflect the user's regional settings. This is probably set to "English (US)", which uses , as the thousands separator, and . as the decimal separator.

(There's a good description of the different culture options on StackOverflow[^].)

To get consistent results, you need to use the same format provider to parse and format your values. There is a CultureInfo parameter passed in to the Convert method, so you should probably use that:

C#

public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
{
    if (value == null) return string.Empty;

    string text = value.ToString();
    
    double dbl;
    if (double.TryParse(text, NumberStyles.Float | NumberStyles.AllowThousands, culture, out dbl))
    {
        text = dbl.ToString("N2", culture);
    }

    return text;
}