BIrthday and Wedding day sms

Question

0.00/5 (No votes)

See more:

C#

Sql = "select s.Name,s.DOB,s.Mobileno,s.Weddingday from BirthDayWish s where s.Active <> 'D'";
Sql = Sql + " and (month(DOB) = month('"+ Convert.ToDateTime(CurDate) + "') and day(DOB) = day ('" + Convert.ToDateTime(CurDate) + "'))";

Sql = Sql + " or (month(Weddingday) = month('" + Convert.ToDateTime(CurDate) + "')  and  day(Weddingday) = day ('" + Convert.ToDateTime(CurDate) + "'))";

in the above query condition day and month fall that year birthdaysms be sent
and also day and month fall that year wedding sms be sent.

it is not conditon both day and month fall of birthday and wedding need not be like that.

Database column as follows;

name      DOB          Mobileno       weddingday

Ramesh    11/12/2013   9840576895      1/1/2035.
          (MM/DD/YYYY)                (MM/DD/YYYY)

in that when i send sms only wedding day sms only to be send.

but when i send sms to this number both birthday and wedding day sms has sent at a time.

because in birthday 11/12/2013 i send sms on today(1.1.2013) to this number(9840576895) only birthdaay falls on 11 dec 2013.

but birthday sms sent why.

only wedding sms to be send.

from the above query wat is the problem help me.

[edit]Code block added - OriginalGriff[/edit]

Posted 1-Jan-13 0:15am

Member 8054539

Updated 1-Jan-13 0:32am

OriginalGriff

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2013-01-01T00:46:00

You should split your code into manageable and (more importantly) testable components. You are using the expression Convert.ToDateTime(CurDate) four times, but nowhere are you checking its result. Are you sure that CurDate is a valid date string? You should do this conversion before you start building your SQL statement so you know it is valid, and you can then easily extract the day, month and year from it. I am assuming that the dates stored in your database are stored as SQL Date or DateTime types. You should also use proper parameterised queries, rather than concatenated strings, so you can check all values at each step.

OriginalGriff · Answer 2 · 2013-01-01T00:46:00

Lets simplify your query a little:

C#

Sql = "select s.Name,s.DOB,s.Mobileno,s.Weddingday from BirthDayWish s where s.Active <> 'D'";
Sql = Sql + " and (month(DOB) = month('"+ Convert.ToDateTime(CurDate) + "') and day(DOB) = day ('" + Convert.ToDateTime(CurDate) + "'))";

Sql = Sql + " or (month(Weddingday) = month('" + Convert.ToDateTime(CurDate) + "')  and  day(Weddingday) = day ('" + Convert.ToDateTime(CurDate) + "'))";

Becomes

SQL

select s.Name,s.DOB,s.Mobileno,s.Weddingday from BirthDayWish s where s.Active <> 'D'
 and (month(DOB) = month('2013-01-01') and day(DOB) = day ('2013-01-01'))
 or (month(Weddingday) = month('2013-01-01')  and  day(Weddingday) = day ('2013-01-01'))

Which becomes:

SQL

select s.Name,s.DOB,s.Mobileno,s.Weddingday from BirthDayWish s 
where s.Active <> 'D'
      and (month(DOB) = 1 and day(DOB) = 1)
      or (month(Weddingday) = 1 and  day(Weddingday) = 1)

And to make it even easier, I'll rewrite it as:

SQL

select s.Name,s.DOB,s.Mobileno,s.Weddingday from BirthDayWish s
where activeEqualsD and DOBMatches or WeddingdayMatches

Now, AND has precedence over OR, so that will be evaluated as:

SQL

select s.Name,s.DOB,s.Mobileno,s.Weddingday from BirthDayWish s
where (activeEqualsD and DOBMatches) or WeddingdayMatches

Which probably isn't what you want!
I'm not exactly sure what you are trying to do here - since the statement will return data based on either condition and I have no idea about your code which uses the data - but I strongly suggest that you work out exactly what you want in a similar way to the above, reversed, and use brackets to ensure execution order and priority.

BIrthday and Wedding day sms

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0