Re: Problem assigning string to CString object - C / C++ / MFC Discussion Boards

Re: Problem assigning string to CString object

Kiran Pinjala31-Jul-06 0:57

31-Jul-06 0:57

USER * pUser = new USER;
if (NULL == pUser)
{
return NULL;
}
ZeroMemory(pUser, sizeof(USER));
pUser->pMember = pMember;
hr = pMember->GetName(&bstr);
if (FAILED(hr))
{
AddLog("Problem with GetName");
}
else
{
name = BSTRtoStr(bstr);// THIS IS MY FUNCTION
//pUser->strName.Insert(0,name); -----******* HERE WHERE IT IS CRASHED
SysFreeString(bstr);
m_ListMembers.InsertString(-1,name);
}

KIRAN PINJARLA

Re: Problem assigning string to CString object

Hamid_RT31-Jul-06 1:05

Hamid_RT

31-Jul-06 1:05

How to create pUser

WhiteSky

Re: Problem assigning string to CString object

Kiran Pinjala31-Jul-06 1:47

Kiran Pinjala

31-Jul-06 1:47

typedef struct USER
{
INmMember *pMember; //INmMember is a componant Interface
CString name;
}USER;

KIRAN PINJARLA

Re: Problem assigning string to CString object

toxcct31-Jul-06 1:48

toxcct

31-Jul-06 1:48

why do you use CString::Insert() instead of CString::Operator = ???moreover, how is declared name ??

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: Problem assigning string to CString object

Kiran Pinjala31-Jul-06 2:11

Kiran Pinjala

31-Jul-06 2:11

Actually i tried all assignments of CString and insert was one of it.
I tried name =..., name.Format("%s",...
But it doesnt work.

KIRAN PINJARLA

Re: Problem assigning string to CString object

toxcct31-Jul-06 2:14

toxcct

31-Jul-06 2:14

it's not what i'm asking. how is declared name ?

1. CString name;
2. char* name;
3. char[] name;
4. other...

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: Problem assigning string to CString object

Kiran Pinjala31-Jul-06 2:19

Kiran Pinjala

31-Jul-06 2:19

its declared as
CString name;

KIRAN PINJARLA

Re: Problem assigning string to CString object

toxcct31-Jul-06 2:25

toxcct

31-Jul-06 2:25

then, where you wrote

pUser->strName.Insert(0,name); -----******* HERE WHERE IT IS CRASHED

what happens with the following code if you dirrecly affect strName ?? :

ASSERT(pUser != NULL);
pUser->strName = _T("hello");

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: Problem assigning string to CString object

Kiran Pinjala31-Jul-06 2:43

Kiran Pinjala

31-Jul-06 2:43

The first thing i did was that. It failed there, then i tried differenct ways.

KIRAN PINJARLA

Re: Problem assigning string to CString object

toxcct31-Jul-06 2:46

toxcct

31-Jul-06 2:46

kiran.pinjarla wrote:
It failed there

well, i cannot help you much ; i'm pretty sure you don't show us all the code...

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: Problem assigning string to CString object

Kiran Pinjala31-Jul-06 2:48

Kiran Pinjala

31-Jul-06 2:48

Its going to afx.inl and showing error at
// CString
_AFX_INLINE CStringData* CString::GetData() const
{ ASSERT(m_pchData != NULL); return ((CStringData*)m_pchData)-1; }

showing m_pchData : NULL;

KIRAN PINJARLA

Re: Problem assigning string to CString object

Zac Howland31-Jul-06 4:12

Zac Howland

31-Jul-06 4:12

You have a few problems here. The biggest one is the cause of the problem you see:

kiran.pinjarla wrote:
ZeroMemory(pUser, sizeof(USER));

Doing this destroys the memory that CString's constructor worked so hard to set up. Your options here are to either make USER into a class and have its constructor do proper initialization, or to make the CString part of the structure into a CString* (and obviously make sure you create it before using it). The first option would be a better choice:

class User
{
	User()
	{
		m_pPtr = NULL;
		m_strData = _T("");
	}

	// other methods for accessing data go here
private:
	MYINTERFACEPTR* m_pPtr;
	CString m_strData;
};

kiran.pinjarla wrote:
name = BSTRtoStr(bstr);// THIS IS MY FUNCTION

This isn't such a big problem, but it is reinventing the wheel. I'm assuming that bstr is some BSTR value that is passed to this function/area of code somehow. That being the case, the type should be changed from BSTR to _bstr_t (which has a constructor and an explicit cast operator to BSTR). Then, to copy that string to your CString object, you would just do the following:

pUser->SetData((const char*)bstr); // SetData being the accessor for your CString member variable

If you decide to become a software engineer, you are signing up to have a 1/2" piece of silicon tell you exactly how stupid you really are for 8 hours a day, 5 days a week

Zac

Re: Problem assigning string to CString object

David Crow31-Jul-06 5:03

David Crow

31-Jul-06 5:03

kiran.pinjarla wrote:
ZeroMemory(pUser, sizeof(USER));

What's this for?

"Money talks. When my money starts to talk, I get a bill to shut it up." - Frank

"Judge not by the eye but by the heart." - Native American Proverb

Re: Problem assigning string to CString object

jpyp31-Jul-06 7:56

jpyp

31-Jul-06 7:56

Have you tried the following:

#pragma pack(push, 1)<br />
your struct declaration<br />
#pragma pack(pop)

Thanks!
jpyp

Re: Problem assigning string to CString object

Christopher Stratmann31-Jul-06 8:08

Christopher Stratmann

31-Jul-06 8:08

Why dont you just do this???

CString s;
s.Format("%s",::ConvertBSTRToString(BSTR));

ConvertBSTRToString is a standard function that should be available to you.

Chris

ICQ

Daniel Kanev30-Jul-06 23:29

Daniel Kanev

30-Jul-06 23:29

I would like to write my own ICQ client. How can I log on to an ICQ server and process messages?

thanks!

modified 9-Mar-17 17:15pm.

controls visible or not at runtime

Desmo1630-Jul-06 22:50

Desmo16

30-Jul-06 22:50

Hi all,

Is there a way to make a control visible/invisible
at runtime ?

Moreover: may i change the position af a control
at runtime ?

Thanx in advance,
Desmo16.

Re: controls visible or not at runtime

see me30-Jul-06 23:00

see me

30-Jul-06 23:00

Please mention some thing about wat language u r using??? D'Oh! | :doh:

do u mean controls in MFC dialg based application??? D'Oh! | :doh:

Dream bigger... Do bigger...Expect smaller
aji

Re: controls visible or not at runtime

toxcct30-Jul-06 23:01

toxcct

30-Jul-06 23:01

GetDlgItem(IDC_MY_CONTROL)->ShowWindow(SW_HIDE);<br />
GetDlgItem(IDC_MY_CONTROL)->ShowWindow(SW_SHOW);

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: controls visible or not at runtime

see me30-Jul-06 23:11

see me

30-Jul-06 23:11

also to move controls
BOOL MoveWindow( int x, int y,int nWidth, int nHeight, BOOL bRepaint = TRUE )
or
SetWindowPos ( const CWnd* pWndInsertAfter, int x, int y, int cx, int cy, UINT nFlags );

Smile | :)

Dream bigger... Do bigger...Expect smaller
aji

Re: controls visible or not at runtime

toxcct30-Jul-06 23:13

toxcct

30-Jul-06 23:13

say this to the OP... i didn't ask the question.

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: controls visible or not at runtime

see me30-Jul-06 23:23

see me

30-Jul-06 23:23

Whats in my mind is, he can also see the answer from here naaa??? Big Grin | :-D

I just want to add my point with your answer. Roll eyes | :rolleyes:

Dream bigger... Do bigger...Expect smaller
aji

Re: controls visible or not at runtime

toxcct30-Jul-06 23:24

toxcct

30-Jul-06 23:24

sure

TOXCCT >>> GEII power

[VisualCalc 3.0 updated ][Flags Beginner's Guide new! ]

Re: controls visible or not at runtime

_AnsHUMAN_ 30-Jul-06 23:04

_AnsHUMAN_

30-Jul-06 23:04

Yes you can change the position of a control at runtime.
See MoveWindow()

Somethings seem HARD to do, until we know how to do them.
Wink | ;-)

_AnShUmAn_

Re: controls visible or not at runtime

Hamid_RT31-Jul-06 1:00

Hamid_RT

31-Jul-06 1:00

See

<br />
MoveWindow(...)//position<br />
ShowWindow(SW_SHOW or SW_HIDE) for visible or not<br />

WhiteSky

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.