C / C++ / MFC

DavidCrow wrote:

strengthen

#include <string.h>
#include <stdio.h>

	char string[] = "A string\tof ,,tokens\nand some  more tokens";
	char seps[]   = " ,\t\n";
	char *token;

	int main( void )
	{
		printf( "Tokens:\n" );

		// Establish string and get the first token:
		token = strtok( string, seps ); // C4996
		// Note: strtok is deprecated; consider using strtok_s instead
		while( token != NULL )
		{
			// While there are tokens in "string"
			printf( " %s\n", token );

			// Get next token: 
			token = strtok( NULL, seps ); // C4996
		}
	}
</stdio.h></string.h>

strtoken

int strtoken(char *str, char *separator, char *token[])
	{
		int i = 0;

		token[0] = strtok(str, separator); //This line crashes

		while ( token[i] ) 
		{
			i++;
			token[i] = strtok(NULL, separator);
		}
		return ( i );
	}

char *token[256]; //I think that is an array of char*, isn't it?
for(int i = 0; i < 256; i++)
{
    token[i] = '\0';
}
Helper::instance()->strtoken(name, ".", token);

char * name = "system.fullscreen";
token[0] = strtok(name, "."); // exception here

char name[] = "system.fullscreen";
token[0] = strtok(name, "."); 

char * name;
name = _strdup("system.fullscreen");
if ( name )
{
  strtoken(name, ".", token);
  free(name); // don't forget to free memory
}

doSomething(char *name)
{
  [...]
  strtoken(name, ".", token); //crashes
}

doSomething(char *name)
{
  [...]
  char foo[] = "hello.world";
  strtoken(foo, ".", token); //does NOT crash
}

doSomething(char * name)
{
  //...
  char * name_writable_copy = _strdup( name );
  if ( name_writable_copy )
  {
    strtoken(name_writable_copy, ".", token);
    free( name_writable_copy );
  }
  else
  {
   // handle (unusual) allocation error 
  }
}

error1408 wrote:

Helper::instance()->strtoken(name, ".", token);

char *temp = new char[strlen(name) + 1];
strcpy(temp, name);
Helper::instance()->strtoken(temp, ".", token);

DavidCrow wrote:

How about something like:

char *temp = new char[strlen(name) + 1];
strcpy(temp, name);
Helper::instance()->strtoken(temp, ".", token);

error1408 wrote:

Why does the param char * not work but the char * thats created here?

void main( void )
{
    char *abc = "First";
    char xyz[] = "Last";
 
    abc[0] = '1';
    xyz[0] = '2';
}

error1408 wrote:

Btw. I have to DELETE the char *temp afterwards, right?

error1408 wrote:

...I can not know if the char *name that I get is a literal or not so to be sure it's not I have to create a temp array?

GetFirstSelectedItemPosition<br />
GetNextSelectedItem<br />
GetItemText