Iterator file count matches and non matches?

Question

1.00/5 (1 vote)

See more:

I have a recrusive filesystem iterator that searches for multiple file extensions. I have a label that counts the matches found but for some reason I have been unable to include the files that do not match to the file count so that I get a full system file count and not just a count of the matches.

for the files that match I wish to do some calculations and for the ones that do not match I wish to just count.

Try
dim filespecs as string = "*.exe;*.com;*.386"
                Using fse As New FindFiles.FileSystemEnumerator(pathToSearchCombo.Text, filespecs, True)
                    Dim ien As IEnumerator(Of FileInfo) = fse.Matches().GetEnumerator()
                    ien.Dispose()
                    For Each fi As FileInfo In fse.Matches
Fcount = fcount +1
label3.text = fcount.tostring
'do some work

Posted 24-Jun-12 17:00pm

Dale 2012

Updated 24-Jun-12 17:32pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2012-06-24T18:32:00

Solution 1

Really?? FilesThatDontMatch = AllFiles - FileThatDoMatch

It should be pretty obvious you have to retrieve ALL the files in the path specified, then find the ones that match. That way, you'll have both pieces of the equation.

Posted 24-Jun-12 18:32pm

Dave Kreskowiak

Comments

Dave Kreskowiak 25-Jun-12 11:36am

AllFiles - FilesThatDoNotMatch IS your solution. If you are only retrieving the files that match the specification, you only get those files. You don't see the remaining files in the folder at all and therefor cannot count them!

There's isn't a single line of code here that doesn't have something wrong with it.

You create a variable called "ien" and then on the next line you Dispose the object it points to?? Why even create it then?? Your also not even using it!

Where did this "FileSystemEnumerator" come from? It's not part of the .NET Framework.

Your loop gets a FileInfo object from the fse.Matches collection, but then you completely ignore it, so yes, this code doesn't work at all.

Your If statement is useless because your are adding 1 to Fcount no matter what the outcome of the evaluation is, so what's the point of it??

All you need to do is look at the extension of the FileInfo objects you get back from the "fse".
For Each fi As FileInfo In fse.Matches
If fi.Extension = "txt" Then
Fcount += 1
Else
nonMatchingCount += 1
Next
Next

Dale 2012 25-Jun-12 20:50pm

My last problem to all of this is only counting the files that do not match and to not carry out any other operations on thoes files. I have tried to add the routine within the if fi.extension statement to finally get it to correctly count the total number of files but for some reason it is still doing the calculations on all files and not just the files that match.

Dale 2012 25-Jun-12 21:15pm

I want to count both files that match and files that do not but only carry out calculations on the files that match

Dave Kreskowiak 25-Jun-12 21:42pm

Seriously, this is 1st grade math. You go through all the files and examine the extension to see if it matches your critieria. If the file doesn't match, increment a counter keeping track of those files. If it does match, increment a seperate counter tracking those files. Since you now know the number of each, any math or presentation you want to do with those number is trivial. The total number of files is both counters added together.

I honestly can't see what you're having a problem with...

Dale 2012 26-Jun-12 0:45am

it does not seem to make any difference if I change

If fi.Extension = filespecscombo Then
Fcount += 1
Label3.Text = Fcount.ToString
Else

to

If fi.Extension = nonfilespecs Then
Fcount += 1
Label3.Text = Fcount.ToString
Else

Dave Kreskowiak 26-Jun-12 1:18am

So, what's the contents of filespecscombo and nonfilespecs?? I'd be willing to bet that you're listing multiple filespecs seperated by some character and the extension being checked only specifies one extension.

Sorry, but "TXT" will never equal "TXT;DAT;BIN;whatever", or any other form of string, besides "TXT". You have to create a list of some kind to contain filespecs and compare the extension to each one of those in the list to see if there is a match.

You cannot just go "If fi.Extension = some list of strings" and expect it to work!

Dale 2012 26-Jun-12 10:47am

Thats correct!! .... my filespecscombo extensions are seperated like so *.exe;*.txt;*.gif and so on. the nonfilespec is just simply *.* to look for all files. both filespecs and nonfilespecs are dim as string, how might I correct this problem?

thank you for responding

Dave Kreskowiak 26-Jun-12 12:12pm

You'll have to put the extensions in a list, such as a List(Of String), then you can simply do

Dim MyExtensions As New List(Of String)
MyExtensions.AddRange({"txt", "exe", "dat"})

If MyExtensions.Contains(fi.Extension.ToLower()) Then...

Dale 2012 26-Jun-12 16:00pm

ok i have tried

Dave Kreskowiak 26-Jun-12 17:02pm

Then step through the code line-by-line, looking at the values of variables after each line. You'll have to break out the fi.Extension.ToLower() call into its own variable so you can see the value.

This is where you MUST learn to use the debugger and inspect your code as it runs.

Dale 2012 27-Jun-12 0:26am

Ok I think I have narrowed the code down to this

Public Sub New(ByVal pathsToSearch As String, ByVal fileTypesToMatch As String, ByVal includeSubDirs As Boolean)
m_scopes = New Stack(Of SearchInfo)()
If Nothing Is pathsToSearch Then
Throw New ArgumentNullException("pathsToSearch")
End If
If Nothing Is fileTypesToMatch Then
Throw New ArgumentNullException("fileTypesToMatch")
End If
If fileTypesToMatch.IndexOfAny(New Char() {":"c, "<"c, ">"c, "/"c, "\"c}) >= 0 Then
Throw New ArgumentException("invalid cahracters in wildcard pattern", "fileTypesToMatch")
End If
m_includeSubDirs = includeSubDirs
m_paths = pathsToSearch.Split(New Char() {";"c, ","c})
Dim specs() As String = fileTypesToMatch.Split(New Char() {";"c, ","c})
m_fileSpecs = New List(Of Regex)(specs.Length)
For Each spec As String In specs
Dim pattern As String = spec.Trim().Replace(".", "\.").Replace("*", ".*").Replace("?", ".?")
m_fileSpecs.Add(New Regex(String.Format("^{0}$", pattern), RegexOptions.IgnoreCase))
Next spec
End Sub

I believe that the error is within this statement and is the reason for the count to be messed up.

you use a format like so
MyExtensions.AddRange({"txt", "exe", "dat"})

and the string format that is being used is

"*.exe;,*.txt;,*.com;"

What needs to change in this sub so that the list of string can read the format of the sting?

thank you for being so parient

Dave Kreskowiak 27-Jun-12 7:22am

Wait, where did THIS code come from??

You cannot pass the contents of MyExtensions to any search spec. You need two seperate values. One search spec, like "*.*" to pass to this code and the other (MyExtensions) to match file extensions to.

Dale 2012 27-Jun-12 14:44pm

yes I have done that with nonfilespec as string = "*.*" which finds all files and I have tried myextensions as new list of string that looks like "txt","exe" and so forth but it does not seem to fit my eariler sub with the parameters given and I have tried to do the work myself for the past few days which may sound pathetic but true. Would you have time to look at the file?

http://www.codeproject.com/Articles/12782/File-System-Enumerator-using-lazy-matching

thank you so much!!

Dave Kreskowiak 27-Jun-12 17:15pm

Let's see. I'm working 12 to 14 hours a day. I'm currently a single parent as my wife is away on business. I've got post-flooded basement work to do. I'm still going to physical therapy 4 times a week post-surgery on my back.

Hmmm... what do you think?

I come around here in what amounts to 10 miuntes in a day. That's the extent of my "free" time.

Dale 2012 27-Jun-12 14:47pm

the file in question is C# which i have converted to vb.net I hope that you will be familar with C# to help me with this as its really the last step that i need

again my main goal of all this is to enumerate all files but only calculate the md5 hash for the files that match my criteria.

Dale 2012 27-Jun-12 17:50pm

I am unaware of your personal life and appologise to ask you sorry for sounding inconsiderate to your time constraints but I thank you for your input I will just have to keep trying...