My code is throwing System.IndexOutOfRangeException How to fix it?

Question

2.00/5 (1 vote)

See more:

C#

DataRow[] Typliste = dsret.Select(String.Format("Label = '{0}'", strFeldnamen));
           
           try
           {
               Datentyp = "";
               Datentyp = Typliste[0].ItemArray[1].ToString();
           }
           catch
           {
               return false;
           }

then its throwing System.IndexOutOfRangeException how to fix it.

Posted 18-Nov-14 3:47am

Member 11000455

Updated 18-Nov-14 9:31am

ZurdoDev

v3

Add a Solution

Comments

PIEBALDconsult 18-Nov-14 9:53am

Either the record wasn't found or it has only one item.
Look before you leap. Use the debugger.

johannesnestler 18-Nov-14 10:10am

You speak german - ok, but "Index out of range" should be easy to understand. You are using 3 indices in this snippet, first is implicit in String.Format - this is ok, So problem could only be that no row was returned by your select or the row hasn't two cells (unlikely you got that wrong but you see there is a reason not to rely on index - what if datarow format changes...). Use the Debugger not a forum for such simple coding errors you will see every day.

[no name] 18-Nov-14 15:51pm

and BTW:

Datentyp = ""; // This line is not really meaningful
Datentyp = Typliste[0].ItemArray[1].ToString();

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2014-11-18T03:55:00

Solution 1

Easy enough. Don't try and use an index that doesn't exist and you won't get the error.

Your code is ASSUMING that are more items in an array than actually are there.

Either the Select is not returning any rows or it's returning fewer columns than your code is assuming are in the results.

Posted 18-Nov-14 3:55am

Dave Kreskowiak

brianriggan · Answer 2 · 2014-11-18T08:45:00

Solution 3

Store the number of elements into a variable and use those to access the list rather than hard coded values.
For example.
int numOfLabels = Typliste.Length();
and/or
if(numOfLabels > 0)
{
Datentyp = Typliste[0].ItemArray[1].ToString();
}

Posted 18-Nov-14 8:45am

brianriggan

Updated 18-Nov-14 8:46am

v2