Direcotry Creation in C#

Question

0.00/5 (No votes)

See more:

Hello,
I'm trying to create directory in c# using this code snippet

C#

public JsonResult Upload()
        {
           
                try
                {
                    DirectoryInfo di =
                        Directory.CreateDirectory("~/Images_LL/Timeline/" + "userid" + Convert.ToInt32(Session["userid"]) + "");
                }
                catch (ArgumentNullException ex)
                {
                    //throw ex;
                }
                catch (Exception ex)
                {
                    throw ex;
                }

          }

this line throws no exception but directory is also not created. I'm running visual studio as administrator.
Please help me figure out I have tried all exceptions one by one in catch block.
Neither throws exception not makes directory.

Posted 30-Nov-15 2:33am

Sohaib Javed

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2015-11-30T02:41:00

You're passing in an app-relative path. The Directory class doesn't know anything about ASP.NET paths. You need to map the app-relative path to a physical path first:

C#

string virtualPath = string.Format("~/Images_LL/Timeline/userid{0}", Convert.ToInt32(Session["userid"]);
string physicalPath = Server.MapPath(virtualPath);
DirectoryInfo di = Directory.CreateDirectory(physicalPath);

Also, don't use throw ex; to re-throw an exception. If you do, you'll destroy the stack-trace. Use throw; instead.

And don't catch exceptions that you're not going to handle. Catching an exception and immediately re-throwing it has no benefit. Just remove the entire catch (Exception ex) { ... } block.

F-ES Sitecore · Accepted Answer · 2015-11-30T02:44:00

Solution 2

Use MapPath to get the physical location of the path in your webspace.

https://msdn.microsoft.com/en-us/library/system.web.httpserverutility.mappath(v=vs.110).aspx[^]

C#

Directory.CreateDirectory(Server.MapPath("~/Images_LL/Timeline/") + "userid" ...

Posted 30-Nov-15 2:44am

F-ES Sitecore

Comments

Sohaib Javed 30-Nov-15 9:18am

Thanks!