Take back the value from the selecteditem Combobox

Question

3.00/5 (1 vote)

See more:

I have this subroutine to fill some comboboxes

Private Sub Fill_Combo_Box(ByVal ParmSQL As String, ByVal ComboName As ComboBox)
    Dim Con As OleDbConnection
    Dim sqlCmd As OleDbCommand = New OleDbCommand(ParmSQL)
    Con = New OleDbConnection(Main_Form.ConString)
    Try
        Con.Open()
        sqlCmd.Connection = Con
        myData = sqlCmd.ExecuteReader
        Do While myData.Read
            ComboName.ValueMember = myData.Item(0)
            ComboName.Items.Add(myData.Item(1).ToString.PadRight(10, " ") & " " & myData.Item(2))
        Loop
    Catch 'ex As OledbException
    End Try
    Con.Close()
End Sub

The subroutine work great but please help me how i can take at any time the
value from the selecteditem??

Thanks and regards...

Posted 15-Apr-11 6:53am

Vagelisr

Add a Solution

2 solutions

Solution 1

If you just want the text of the Item that was selected, you can use

<br />
ComboName.SelectedItem.Text;<br />

if you want the actual value and not the text:

<br />
ComboName.SelectedValue;<br />

You should get the values on the SelectedIndexChanged Event of your comboBox.
I hope this is what you wanted to know. Good Luck my friend

Posted 15-Apr-11 6:59am

mario_silent

Comments

Sandeep Mewara 15-Apr-11 13:38pm

Comment from OP:
I want to take the ComboName.ValueMember = myData.Item(0)
when i perform the write record subroutine

the ComboName.SelectedValue return nothing..............

mario_silent 15-Apr-11 13:43pm

OK I can see a problem here... You are adding the data from the reader dinamycally and when I set the valueMember property is usually when I bind to a dataSource. Maybe it would be a good Idea to assign the datasource of the combo to the reader instead of filling it dynamically and after adding the datasource and assigning the valueMember, you can loop through the items of the list to change the text displayed in the combo to your format

Vagelisr 15-Apr-11 15:09pm

I am really appreciate if you write some code for this.....

Thank you......

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

mario_silent · Accepted Answer · 2011-04-15T09:29:00

Solution 3

Ok, first you should use OleDbAdapter and a dataset instead of the reader. Your code would look like this:

VB

Private Sub Fill_Combo_Box(ByVal ParmSQL As String, ByVal ComboName As ComboBox)    Dim Con As OleDbConnection
Dim adapter as OleDbAdapter    
Dim dataSet as DataSet
Dim sqlCmd As OleDbCommand = New OleDbCommand(ParmSQL)    
Con = New OleDbConnection(Main_Form.ConString)    

Try        
Con.Open()        
sqlCmd.Connection = Con        
adapter.SelectCommand = sqlCmd
adapter.Fill(dataSet)

'Then we set the dataSource to the dataset's table       
ComboName.DataSource = dataSet.Tables(0)
ComboName.ValueMember = "NameOfFirstColumn"
ComboName.DisplayMember = ("NameOfSecondColumn").PadRight(10, " ") & " " & "NameOfThirdColumn"

           
Catch 'ex As OledbException    End Try    Con.Close()End Sub

I'm not too sure about the displayMember being a valid expression, I'm guessing not but maybe you could add a new column to your sql table that has the text in the format you want and then you'd just say:

ComboName.DisplayMember = ("NameOfNewColumnWithTheFormat")

Meanwhile you can test just with the valuemember and not mess with the displayMember by using SelectedItem.Value. Good Luck

Posted 15-Apr-11 9:29am

mario_silent

Comments

Vagelisr 15-Apr-11 15:51pm

I receive an error
Type OleDbAdapter is not define

mario_silent 15-Apr-11 15:55pm

My bad. It's OleDbDataAdapter and I forgot to initialize the Dataset and the adapter as well. Do so or you'll get some error

Vagelisr 15-Apr-11 16:21pm

My friend first of all thank you for your time.
With this 2 lines
ComboName.ValueMember = "NameOfFirstColumn"ComboName.DisplayMember = ("NameOfSecondColumn").PadRight(10, " ") & " " & "NameOfThirdColumn"
i see my id in my combo box.....
i want to see the second and the thierd column and receive the first........

mario_silent 15-Apr-11 16:29pm

Have you thought about what I suggested? adding a fourth column that combines column 2 and 3 and gives it the format you want? then:

ComboName.DisplayMember = "NameOfFourthColumn"

That's a possibility but also you could use a List<>, populate it and bind it to the comboBox. The drawback here would be that you need to create a new class or struct with 2 properties, one for the ID and the other could be the combination of the column 2 and three. So you bind the List<yourclass struct=""> to the combo and set the DisplayMember to the name of the Property containing the column 2 and 3. I can show you how to do it if you like this option or you can try adding the column to your sql table but it might not be a good choice for you. You're welcome1
!

Vagelisr 15-Apr-11 16:36pm

I have try to change the sql in this
"SELECT line_id, Left(line_code & ' ', 11) as code, line_descr FROM Line Order by line_code"

but :(

If you are able to show me it will be very helpfully.

mario_silent 15-Apr-11 16:42pm

Ok you can select the line_id and the code as a concatenation as in here:

"SELECT line_id, code = Left(line_code & ' ', 11) + ' ' + line_descr FROM Line Order by line_code"

that will return 2 columns so de displayMember will be your second column and your valuemember will be the first column. Check the name:
SecondColumn name is code so:

ComboName.DisplayMember = "code"

Hope this helps buddy

Vagelisr 15-Apr-11 16:55pm

Thanks again.OK the Sql is correct but

when i run this MsgBox(cbo_mst_roller_line_id.ValueMember)
i receive line_id
Why??
I want the value that the line_id has........

Vagelisr 15-Apr-11 17:06pm

MY FRIEND....................
2 things.
1)the correct sql finally is
"SELECT line_id, Left(line_code & ' ', 11) + ' ' + line_descr as code FROM Line Order by line_code"
2)to receive the id i need MsgBox(cbo_mst_roller_line_id.SelectedValue)

Thanks a lot for your help........
God bless you!!!!!!!!!!!!!!!!!!!!!
Hope some day to do something for you!!!!!!!

mario_silent 15-Apr-11 17:12pm

Well you had the NameOfFirstColumn incorrect lol there you had to write in your case line_id instead of NameOfFirstColumn so I'm glad you made it work! you're welcome and have a nice day buddy