Stored Procedure is removing all rows

Question

4.00/5 (1 vote)

See more:

I have this procedure: (DDL code extracted directly from MySQL Workbench just to make sure)

SQL

DELIMITER $$
CREATE DEFINER=`root`@`localhost` PROCEDURE `removerContacto`(nome VARCHAR(250),id INT)
BEGIN
DELETE FROM Contactos WHERE Nome = nome AND UsersID = id;
END

and I call it this way:

mysql_query("CALL removerContacto('".$_GET['nome']."','".$_GET['uid']."')");

The problem is removing all rows instead only one (there's only for that WHERE clause). If I try

mysql_query("DELETE FROM Contactos WHERE Nome ='".$_GET['nome']."' AND UsersID=".$_GET['uid']."");

or directly at workbench

DELETE FROM Contactos WHERE Nome = 'someone' AND UsersID = 1;

It works correctly. What am I doing wrong?

Posted 21-Apr-11 6:13am

Maxdd 7

Add a Solution

3 solutions

Solution 1

The fuirst thing I'd do is make sure that $_GET['nome'] and $_Get['uid] actually contained what you're expecting them to contain.

Posted 21-Apr-11 6:51am

#realJSOP

Comments

Maxdd 7 21-Apr-11 16:16pm

Of course. I did that. I didnt said that because I said mysql_query with hardcoded SQL statement worked, but of course I did echo $_GET['nome'].$_GET['uid'];

Solution 2

I suspect there is something wrong on userid and name .
How this is possible to table have a multiple record for same userid and for same username ?
Bye the way I tried this in my Mysql Query Browser 5.0 . It works fine.

It is very helpful for me if you could share the table structure of Contactos .

Posted 21-Apr-11 7:05am

RDBurmon

Comments

Maxdd 7 21-Apr-11 16:19pm

It's not possible because one of the fields it's primary key.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graham Breach · Accepted Answer · 2011-04-21T07:11:00

Solution 3

I would make sure that the procedure parameters do not have the same names as table columns - because variables are case insensitive, Nome = nome will always be true.

Posted 21-Apr-11 7:11am

Graham Breach

Comments

Maxdd 7 21-Apr-11 16:19pm

Accepted! Thank you very much I didnt know that :)