System.formatexception: input string was not in a correct format.

Question

0.00/5 (No votes)

See more:

Quote:
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.FormatException: Input string was not in a correct format.

What I have tried:

Line 42:         {
Line 43:             var test = Convert.ToString(Session["CID"]);
Line 44:             int q = QAdapter.Insert(Convert.ToInt32("txtserial.Text"), (Convert.ToInt32("0")),
Line 45:                 drpQpapername.SelectedItem.Text, txtEname.Text, txtquestion.Text, 
Line 46:                 txta.Text, txtb.Text, txtc.Text, txtd.Text, DropDownListkey.SelectedItem.Text);

Posted 25-Jul-17 23:16pm

sommr0

Updated 25-Jul-17 23:28pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-07-25T23:25:00

Solution 1

Simple: The user input was not a valid integer.
Solution: don't use Convert at all. Always use the appropriate TryParse method, and report user problems back to the user instead of assuming they will always type correctly.

VB

Dim serial As Integer
If Not Integer.TryParse(txtserial.Text, serial) Then
	' Report problem to user
	...
	Return
End If

Posted 25-Jul-17 23:25pm

OriginalGriff

Comments

sommr0 26-Jul-17 5:46am

i'm try parse method but issue still same

OriginalGriff 26-Jul-17 6:10am

Did you try the code I gave you exactly as I showed it?

sommr0 26-Jul-17 6:10am

yeah

sommr0 26-Jul-17 6:13am

i'm trying
protected void btnaddquestion_Click(object sender, EventArgs e)
{
var test = Convert.ToString(Session["CID"]);
int q = QAdapter.Insert(int.Parse("txtserial.Text"), (Convert.ToInt32("0")),
drpQpapername.SelectedItem.Text, txtEname.Text, txtquestion.Text,
txta.Text, txtb.Text, txtc.Text, txtd.Text, DropDownListkey.SelectedItem.Text);
QDT = QAdapter.SELECT_QUESTION();
GridViewADDQuestion.DataSource = QDT;
GridViewADDQuestion.DataBind();
}

OriginalGriff 26-Jul-17 6:19am

Is that exactly what I showed you?
No - it uses int.Parse which *still throws an exception if the value is bad*
That's *why* you use TryParse - it reports errors via a boolean return value, letting you handle it properly instead of assuming the user input is fine.

sommr0 26-Jul-17 6:32am

how to fixed it? please correct my code?

OriginalGriff 26-Jul-17 6:42am

Look at the code I already gave you! There isn't a lot I can add to that - other than to use the converted value in your function call, and I have to assume you can work out how to do that without help...

F-ES Sitecore · Answer 2 · 2017-07-25T23:28:00

Convert.ToInt32("txtserial.Text")

You're converting the literal text of "txtserial.Text" to a number, but you probably mean to use the Text property of the txtserial object so you don't use the quotes (quotes denote a string literal)

Convert.ToInt32(txtserial.Text)

That will still error if whatever is in txtserial can't be converted to a number so google how to use int.TryParse instead.