System.data.sqlclient.sqlexception: procedure or function 'COMPANY_CHANGE_PASS' expects parameter '@password', which was not supplied.

Question

1.00/5 (1 vote)

See more:

<pre lang="c#"> this._commandCollection[1].CommandText = "dbo.COMPANY_CHANGE_PASS";
            this._commandCollection[1].CommandType = global::System.Data.CommandType.StoredProcedure;
            this._commandCollection[1].Parameters.Add(new global::System.Data.SqlClient.SqlParameter("@RETURN_VALUE", global::System.Data.SqlDbType.Int, 4, global::System.Data.ParameterDirection.ReturnValue, 10, 0, null, global::System.Data.DataRowVersion.Current, false, null, "", "", ""));
            this._commandCollection[1].Parameters.Add(new global::System.Data.SqlClient.SqlParameter("@PASSWORD", global::System.Data.SqlDbType.NVarChar, 100, global::System.Data.ParameterDirection.Input, 0, 0, null, global::System.Data.DataRowVersion.Current, false, null, "", "", ""));
            this._commandCollection[2] = new global::System.Data.SqlClient.SqlCommand();
            this._commandCollection[2].Connection = this.Connection;

What I have tried:

<pre lang="c#"> this._commandCollection[1].CommandText = "dbo.COMPANY_CHANGE_PASS";
            this._commandCollection[1].CommandType = global::System.Data.CommandType.StoredProcedure;
            this._commandCollection[1].Parameters.Add(new global::System.Data.SqlClient.SqlParameter("@RETURN_VALUE", global::System.Data.SqlDbType.Int, 4, global::System.Data.ParameterDirection.ReturnValue, 10, 0, null, global::System.Data.DataRowVersion.Current, false, null, "", "", ""));
            this._commandCollection[1].Parameters.Add(new global::System.Data.SqlClient.SqlParameter("@PASSWORD", global::System.Data.SqlDbType.NVarChar, 100, global::System.Data.ParameterDirection.Input, 0, 0, null, global::System.Data.DataRowVersion.Current, false, null, "", "", ""));
            this._commandCollection[2] = new global::System.Data.SqlClient.SqlCommand();
            this._commandCollection[2].Connection = this.Connection;

Posted 22-Aug-17 11:34am

sommr0

Add a Solution

Comments

j snooze 22-Aug-17 17:50pm

Have you verified that your parameter list matches the parameter list of the stored procedure and in the correct order? some code seems to be missing as I don't see where the statement is actually being executed, it looks like you are trying to create a bunch of SQL commands into a command collection and then you must be looping through them to execute?

sommr0 22-Aug-17 17:55pm

ALTER PROCEDURE [dbo].[COMPANY_CHANGE_PASS]
-- Add the parameters for the stored procedure here
@Password NVARCHAR(50)
AS
BEGIN
-- SET NOCOUNT ON added to prevent extra result sets from
-- interfering with SELECT statements.
SET NOCOUNT ON;

-- Insert statements for procedure here
UPDATE COMPANYMST SET Password=@Password

Patrice T 22-Aug-17 19:34pm

Use Improve question to update your question.
So that everyone can pay attention to this information.

sommr0 22-Aug-17 17:55pm

This is a procedure but procedure work properly ...

j snooze 22-Aug-17 17:59pm

did you try adding the password parameter as the first parameter?...and actually the only parameter...I also don't see the return value variable being returned anywhere.

sommr0 22-Aug-17 18:06pm

how it possible??

Dave Kreskowiak 22-Aug-17 18:32pm

That is the ugliest code I've seen in a long time. There are so many things wrong with it that make it near impossible to read, let alone debug.

sommr0 22-Aug-17 18:48pm

but it is debug correctly

Dave Kreskowiak 22-Aug-17 18:55pm

Oh really? Then why did you ask a question about it? There's SO MUCH duplication and unnecessary text in that code it probably took you 20 times longer to type it all than it should have.

You SERIOUSLY made the code so difficult to read as to be useless. Nobody cares if it compiles correctly or executes correctly and does the job.

That code is unsupportable.

The really scary part is that appears to be only a small sample of the code in the entire app. If the entire app looks like that, I would hate to be the person who comes in behind you and has to support that steaming pile of ....

Dave Kreskowiak 22-Aug-17 19:05pm

using System.Data;
using System.Data.SqlClient;

.
.
.

    SqlCommand comm = new SqlCommand(connectionObject);

    comm.CommandText = "dbo.COMPANY_CHANGE_PASS";
    comm.CommandType = CommandType.StoredProcedure;

    // RETURN VALUE parameter removed as the stored procedure doesn't return a value
    passwordParameter = new SqlParameter("@Password", SqlDbType.NVarChar, 100);
    passwordParameter.Value = "newPassword";

    comm.Parameters.Add(passwordParameter);

    // commandCollection[2] stuff removed as it has nothing to do with the above code.

    // The entire commandCollection array concept is probably a bad idea in the first place
    // as there are much better ways of caching the command objects and using them.

Richard Deeming 25-Aug-17 15:02pm

NEVER store passwords in plain text!

Secure Password Authentication Explained Simply[^]
Salted Password Hashing - Doing it Right[^]

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)