I need to figure out how to fix this problem.

Question

1.00/5 (1 vote)

See more:

i am working on a blackjack game , i am still a biganner and i am having some problems with writing functions .
i want to have something like this ...

for example:

Welcome to CS intro Blackjack!
Start by entering a random seed:
5
You currently have 1000 fake dollars. How much do you want to bet?
1300
our bet must be at least 1 and at most 1000, try again:
0
Your bet must be at least 1 and at most 1000, try again:
1000

What I have tried:

C++

int main()
{
  int money=0;
  int seed=0;
  int bet=0;
  printf("Welcome to CS intro Blackjack!\n");
  printf("Start by entering a random seed:\n");
  scanf("%d",&seed);
  bet=bett(money);

  return 0;
}
int bett(int x)
  {
      int y=0;
      printf("You currently have %d fake dollars. How much do you want to bet?",x);
      scanf("%d",&y);
      while(y>x)
      {
         printf("Your bet must be at least 1 and at most %d, try again:",x);
          scanf("%d",&y);
      }
      return(y);
  }

Posted 16-May-16 13:28pm

james7777

Updated 16-May-16 14:33pm

George Jonsson

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Jonsson · Accepted Answer · 2016-05-16T14:33:00

First you have to figure the logic of your program.
I guess this is the first assignment in a school project, so not too complicated yet.

First you have two input limitations: the entered bet must be more than 1 and less than available funds.
Hard coded values is always a bad idea, so start with declaring a constant for the lower limit:
For example

C++

#define MIN_BET 1

If you look at function bett(int x), your logic there is not correct.
You call the function with the variable money, but you have initialized money to zero.
You need to assign an initial value to money first and this should also be a constant.

C++

#define INITIAL_MONEY 1000

then assign

C++

money = INITIAL_MONEY;
bet = bett(money);
or
bet = bett(INITIAL_MONEY);

Also learn from the beginning to use reasonable names for your variables. Naming them x, y and z is a recipe for confusion.

C++

x could be called initialMoney
y could be called riskedMoney

As this is C, you need to define a prototype for your functions before the main() function. Or put the main function last.

C++

// Use descriptive names for functions as well
int GetBetFromPlayer(int initialMoney);

int main()
{
}

In the while loop, you only have one condition, and you need two right.
You need to check that the riskedMoney is within both the upper and lower limits.
so

C++

while(y>x)

should be

C++

while ((riskedMoney < MIN_BET) && (riskedMoney > initialMoney))

You might make a note of which statement you think is more readable.
Don't be afraid of using long names and spaces to make your code more easy to read.

There, I think this will keep you occupied for a while.