Delete Code Not Working

Question

0.00/5 (No votes)

See more:

I have altered a delete code but have no idea what went wrong and why it has stopped working.

To start with the code was made for a simple listbox but then decided to add checklistbox but the same search results are found after deleting and the msgbox that pops up says... File System.windows.forms.checkedlistbox+checkeditemcollection successfully deleted?

VB

Private Sub Button3_Click(ByVal sender As System.Object,
                           ByVal e As System.EventArgs) Handles Button3.Click

  red = Replace(CheckedListBox1.CheckedItems.ToString,"Threat Found:","")        
  Try
    System.IO.File.Delete(red)
    If Dir(red) <> "" Then
      MsgBox("Unable to delete" & red, msgboxstyle.critical)
    Else
      MsgBox(String.Format("File {0} successfully deleted", red),
             MsgBoxStyle.Critical)

      CheckedListBox1.Items.Remove (CheckedListBox1.CheckedItems)
    End If
  Catch ex As Exception
  End Try
End Sub

Posted 31-Oct-10 14:40pm

Dale 2012

Updated 31-Oct-10 14:47pm

Anthony Mushrow

v2

Add a Solution

4 solutions

Solution 3

I re-post my answer again.

VB

Dim arrList As New ArrayList()
        For Each item As Object In CheckedListBox1.CheckedItems
            arrList.Add(item)
        Next
        For Each item As Object In arrList 'iteration
            red = Replace(item.ToString(), "Threat Found:","")
            Try
                System.IO.File.Delete(red)
                If Dir(red) <> "" Then
                    MsgBox("Unable to delete" & red, MsgBoxStyle.Critical)
                Else
                    MsgBox(String.Format("File {0} successfully deleted", red), MsgBoxStyle.Critical)
                    CheckedListBox1.Items.Remove(item)
                End If
            Catch ex As Exception
                Console.WriteLine("{0}", ex.Message)
            End Try
        Next

Posted 2-Nov-10 20:52pm

qontary

Comments

Dale 2012 3-Nov-10 2:58am

once again I have tried your re-posted code but it is the same and has the same effect in my case....nothing happens

Dale 2012 3-Nov-10 2:59am

what can I give you, so that you can see the error I have made?

qontary 3-Nov-10 3:02am

Try to change Console.WriteLine("{0}", ex.Message) with MsgBox(ex.Message). See if any message popped up.

Dale 2012 3-Nov-10 3:26am

Will you be willing to look at my code in full to help determine where I have went wrong?.... I feel that we have different examples of how to generate and populate and am unsure what you have posted will be easy for me to follow. I am 100% sure your way works and dont doubt it for a min but my code does not create a test directory and does not delete directories. It deletes only the file from that directory.....idk maybe thats what your trying to tell me here but I would like it if you could just skim over my code and make some real simple corrections which otherwise would take me far to long to realize on my own.

Dale 2012 3-Nov-10 3:31am

also I am not creating a text file or directory to look for. My scan uses the names within the text file to populate the checklistbox items which i wish to delete from the checklistbox and from my computer. So far it is only removing the item from the checklistbox but the actual file remains on the computer in the folder I have placed it in

Dale 2012 3-Nov-10 3:33am

your code also points to specific and known areas of the computer which is impossible for me if a virus name is found in a location I have no idea about.

qontary 3-Nov-10 3:33am

Sure. You could post your code here.

qontary 3-Nov-10 3:35am

I created the code just to simulate your problem. It has no real use.

Dale 2012 4-Nov-10 1:02am

I would sooner email the code to you if that is ok because it is important for me to complete without others taking my ideas....

Solution 4

This is how I generate the text files

VB

Private Sub GenerateTxtFiles()
        System.IO.Directory.CreateDirectory("c:\test")
        For i As Integer = 0 To 99
            Console.WriteLine("Creating: " & "c:\test\filetest" & i & ".txt")
            Dim fs As System.IO.FileStream = System.IO.File.Create("c:\test\filetest" & i & ".txt")
            fs.Close()
        Next
    End Sub

This is how I populate the CheckedBoxList

VB

Private Sub populateList()
        Dim tempDirectory As String = "c:\test"
        If (Directory.Exists(tempDirectory)) Then
            Try
                Dim Files() As String = Directory.GetFiles(tempDirectory)
                'Clear out directory
                For Each Filename As String In Files
                    CheckedListBox1.Items.Add(String.Format("Threat Found:{0}", Filename), True)
                Next
            Catch ex As Exception
            End Try
        End If
    End Sub

Posted 2-Nov-10 20:59pm

qontary

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nish Nishant · Accepted Answer · 2010-10-31T14:46:00

Solution 1

Well the Delete will certainly fail since the string red is not pointing to a valid file name any more. Surely you did recognize this from the messagebox! Remember that CheckedListBox.CheckedItems is a collection, so you probably need to iterate through that and delete each item.

Posted 31-Oct-10 14:46pm

Nish Nishant

v3

Comments

Dale 2012 31-Oct-10 20:58pm

ok but this message comes even when nothing is checked and I press the delete button. How can I point (red) to a valid file name when I may not know the name to search for?

qontary · Accepted Answer · 2010-10-31T17:11:00

Solution 2

I modified your original code.

VB

Dim arrList As New ArrayList()
        For Each item As Object In CheckedListBox1.CheckedItems
            arrList.Add(item)
        Next
        For Each item As Object In arrList 'iteration
            red = Replace(item.ToString(), "Threat Found:","")
            Try
                System.IO.File.Delete(red)
                If Dir(red) <> "" Then
                    MsgBox("Unable to delete" & red, MsgBoxStyle.Critical)
                Else
                    MsgBox(String.Format("File {0} successfully deleted", red), MsgBoxStyle.Critical)
                    CheckedListBox1.Items.Remove(item)
                End If
            Catch ex As Exception
                Console.WriteLine("{0}", ex.Message)
            End Try
        Next

Posted 31-Oct-10 17:11pm

qontary

Updated 31-Oct-10 22:30pm

v4

Comments

Dale 2012 31-Oct-10 23:29pm

Ok I am going to check this out and then get right back to let you know the outcome......

thank you very much in advance for your help

Dale 2012 1-Nov-10 0:15am

Ok I have tested the code and it corrected the text that is displayed when I click delete but again the file still remains on the computer.... I think something is missing from the code to actually delete the found checklistbox1 item

qontary 1-Nov-10 0:35am

For more info on delete go here...http://msdn.microsoft.com/en-us/library/system.io.file.delete.aspx
Try to display the Exception thrown inside the Catch block. Eg: MsgBox(ex.Message)

Dale 2012 1-Nov-10 0:38am

says sorry page not found........ :(

Dale 2012 1-Nov-10 2:05am

any other ideas to why this still does not delete my file but displays the correct msgbox?

qontary 1-Nov-10 2:29am

Which message would pop up when you try to delete? Any exception occurred?

Dale 2012 1-Nov-10 2:47am

no exception occurred as I can tell but the actual file still remains even thoe the message is correct

Dale 2012 1-Nov-10 2:49am

In the code the message box is set to appear when I click the delete button. at the start the msgbox was displaying the wrong message which tells me I had an exception but now that the iteration is in effect the correct name of the file in question is displayed correctly but the file still remains on the computer that im trying to delete.

qontary 1-Nov-10 2:57am

If you are deleting from local drive this code shouldn't have any problem. If you are trying to delete a file that is opened by other application you would encounter the UnauthorizedAccessException. This may not really related but, could you post some of the file names?

Dale 2012 1-Nov-10 3:18am

The file name I have made is simply a dummy file with the matched name in my text file. My scanner finds the file with the same name and then tries to delete it from my application..... so it is impossible that the file is in use or running

Dale 2012 1-Nov-10 3:19am

not from my application but from my checkedlistbox

qontary 1-Nov-10 3:44am

I'm not sure if that's the case. But it's worth to try. Put CheckedListBox1.Items.Remove(CheckedListBox1.CheckedItems) before the delete line.

qontary 1-Nov-10 3:47am

Sorry the correct line should be CheckedListBox1.Items.Remove(CheckedListBox1.CheckedItems(i))

Dale 2012 1-Nov-10 3:59am

Ok I have tried what you have placed here for me but it throws an array error. Can you maybe copy and paste my code with your correction into the next comment incase I have done what you have suggested wrongly? thank you for getting back to me....

qontary 1-Nov-10 4:25am

I have revised the code above. Seem like you could not remove the item in the ListBox and accessing it at the same time. As for populating the ListBox, do you by any chance use File.Open any where on the code?

Dale 2012 1-Nov-10 4:30am

ok this is the code I have so far after making some changes

For i As Integer = 0 To CheckedListBox1.CheckedItems.Count - 1
red = Replace(CheckedListBox1.CheckedItems.Item(i).ToString(), "Threat Found: ", "")
Try
System.IO.File.Delete(red)
If Dir(red) <> "" Then
MsgBox("Unable to delete" & red, MsgBoxStyle.Critical)
Else
MsgBox(String.Format("File {0} successfully deleted", red), MsgBoxStyle.Critical)
CheckedListBox1.Items.Remove(CheckedListBox1.CheckedItems)
End If
Catch ex As Exception
End Try
Next
While CheckedListBox1.CheckedItems.Count > 0
CheckedListBox1.Items.Remove(CheckedListBox1.CheckedItems(0))
End While
End Sub

I need this delete code to remove the file from my computer which it is not doing but is now clearing itself from the checklistbox. I have created the dummy virus with the name in my text file and all goes well untill I hit delete.

Dale 2012 1-Nov-10 4:31am

sorry I thought the code would add as I have fixed it but it all went into a ball sorry.....

qontary 1-Nov-10 4:50am

Pls check the answer. It will remove the deleted item in the CheckedListBox.
If possible, I would like to see your code for populating the CheckedListBox.

Dale 2012 3-Nov-10 2:28am

I have checked the answer 4 times with no change. What part of the code do you need to see? when you say population... I use a text file with the desired names to search for and the results of that file if found on my computer appear into the checklistbox.