Ignore parameters which are null

Question

0.00/5 (No votes)

See more:

I am trying to run a stored proc from a web application. I have multiple parameters with OR condition but i want the parameters which are left blank by the user to be ignored when the query execute.

What I have tried:

This is what i am trying

ALTER Proc [dbo].[spStatusReport]
@CUST_NAME varchar(20),
@CUST_CODE   varchar(10) = NULL 
as 
SELECT  CUST_CODE, DEPT_CODE,EMPLOYEE_CODE, EST_SCRAP, EXCH_RATE,
F_G_, LINE4, LOCATION
FROM Status_Report 
WHERE 
((@CUST_NAME IS NULL OR [LOCATION] LIKE '%' + @CUST_NAME + '%') OR
(@CUST_CODE IS NULL OR [CUST_CODE] LIKE '%' + @CUST_CODE + '%'))

But when i run

EXEC spStatusReport 'ABC',''

I get everything instead of only the ABC location

Posted 3-Dec-18 9:07am

Member 12336474

Updated 7-Dec-18 7:11am

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2018-12-07T07:11:00

Take another look at your WHERE clause:

    (@CUST_NAME IS NULL OR [LOCATION] LIKE '%' + @CUST_NAME + '%')
OR
    (@CUST_CODE IS NULL OR [CUST_CODE] LIKE '%' + @CUST_CODE + '%')

You've used OR to combine the filters for both parameters. Therefore, if either parameter is NULL, then all records will be returned.

I suspect you mean to use And instead:

    (@CUST_NAME IS NULL OR [LOCATION] LIKE '%' + @CUST_NAME + '%')
AND
    (@CUST_CODE IS NULL OR [CUST_CODE] LIKE '%' + @CUST_CODE + '%')

You also need to appreciate the difference between NULL and an empty string. In your example, you're passing in an empty string, so @CUST_CODE IS NULL will be false. As a result, any rows where CUST_CODE is NULL will be excluded from your results, since they won't pass the LIKE '%%' test.

Therefore, I suspect you need:

    (@CUST_NAME IS NULL OR @CUST_NAME = '' OR [LOCATION] LIKE '%' + @CUST_NAME + '%')
AND
    (@CUST_CODE IS NULL OR @CUST_CODE = '' OR [CUST_CODE] LIKE '%' + @CUST_CODE + '%')

#realJSOP · Answer 2 · 2018-12-03T09:32:00

Solution 1

Observations:

0) Why bother specifying a default value of null if the code in the stored proc handles it?

2) Specifying an empty string for the 2nd parameter is NOT the same as specifying NULL.

Try changing it to the following:

EXEC spStatusRepport @CUST_NAME='ABC', @CUST_CODE=NULL

Posted 3-Dec-18 9:32am

#realJSOP