what is wrong with my update query

Question

1.00/5 (1 vote)

See more:

SQL-Server-2005

C#

string mdlist = ddlModalityList.SelectedItem.Value.ToString();
          string schaetitle=TxtSchdledStAETitle.Text;
          string schaename=TxtSchdleStationAEName.Text;

C#

query = "UPDATE Modality_Master SET Modality='"+mdlist+"', Scheduled_Station_AE_Title='"+schaetitle+"',SCHEDULED_STATION_NAME='"+schaename+"' WHERE Modality_ID='"+ModalityID+"'";
           da = new SqlDataAdapter(query, con);
           ds = new DataSet();
           da.Fill(ds);
           Rp.DataSource = ds;
           Rp.DataBind();

Posted 9-Apr-12 1:34am

Nikhil Dayalpawar

Add a Solution

Comments

Mehdi Gholam 9-Apr-12 7:37am

You will have to supply more information like error messages, we cannot guess.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2012-04-09T01:41:00

Solution 1

You have not described the error you are getting.

The best guess that I can make here is that Modality_ID could be a number and you are trying to insert it as a string in your query. Try Modality_ID="+ModalityID; instead.

Posted 9-Apr-12 1:41am

Abhinav S

Updated 9-Apr-12 1:42am

v2

Comments

[no name] 9-Apr-12 7:52am

i have convert Modality_ID into int but not fire update query..

Anil Avhad [IND] · Answer 2 · 2012-04-09T01:41:00

hi,

If you use Update Query then used Update Method.

SQL

query = "UPDATE Modality_Master SET Modality='"+mdlist+"', Scheduled_Station_AE_Title='"+schaetitle+"',SCHEDULED_STATION_NAME='"+schaename+"' WHERE Modality_ID='"+ModalityID+"'";
           da = new SqlDataAdapter(query, con);
           ds = new DataSet();
           da.Update(ds);

Abhi KA · Answer 3 · 2012-04-09T01:44:00

Solution 3

use stored PRocedure beeter than query
the plus symbols are not using correctly then update query creates
problems.

Posted 9-Apr-12 1:44am

Abhi KA