Problem in stored procedure

Question

1.00/5 (1 vote)

See more:

hello friend,

i make one storeprocedure for my search data but when i use this it fetch all data of my data base i want fecth male and female data

seprate here is my procedure

SQL

ALTER PROCEDURE Database.SelectQuickSearch

(
@Gender varchar(15),
@Age int,
@Height varchar(50),
@MartialStatus varchar(20),
@ReligionId int,
@CasteId int,
@Country varchar(50)

)

AS
    
    
    
    SELECT Registration.RegId, Registration.FirstName, Registration.LastName, Registration.Age, Registration.Gender, Registration.Height, Registration.Weight,
                  ReligionMaster.ReligionName, Registration.Country, CasteMaster.CasteName, Registration.Education
FROM     Registration INNER JOIN
                  ReligionMaster ON Registration.ReligionId = ReligionMaster.ReligionId INNER JOIN
                  CasteMaster ON Registration.CasteId = CasteMaster.CasteId
WHERE  (Registration.Gender = @Gender) OR
                  (Registration.Age = @Age) OR
                  (Registration.Height = @Height) OR
                  (Registration.MartialStatus = @MartialStatus) OR
                  (Registration.ReligionId = @ReligionId) OR
                  (Registration.CasteId = @CasteId) OR
                  (Registration.Country = @Country)

Posted 26-Jul-12 20:30pm

shinebudy

Updated 26-Jul-12 20:35pm

_Amy

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Prasad_Kulkarni · Answer 1 · 2012-07-26T20:39:00

Solution 3

Try this:

SQL

--Use AND instead of OR
ALTER PROCEDURE Database.SelectQuickSearch
(
@Gender varchar(15),
@Age int,
@Height varchar(50),
@MartialStatus varchar(20),
@ReligionId int,
@CasteId int,
@Country varchar(50) 
)
 
AS
SELECT Registration.RegId
	 , Registration.FirstName
	 , Registration.LastName
	 , Registration.Age
	 , Registration.Gender
	 , Registration.Height
	 , Registration.Weight
	 , ReligionMaster.ReligionName
	 , Registration.Country
	 , CasteMaster.CasteName
	 , Registration.Education
FROM
	Registration
	INNER JOIN
		ReligionMaster
		ON Registration.ReligionId = ReligionMaster.ReligionId
	INNER JOIN
		CasteMaster
		ON Registration.CasteId = CasteMaster.CasteId
WHERE
	(Registration.Gender = @Gender)
	AND
	(Registration.Age = @Age)
	AND
	(Registration.Height = @Height)
	AND
	(Registration.MartialStatus = @MartialStatus)
	AND
	(Registration.ReligionId = @ReligionId)
	AND
	(Registration.CasteId = @CasteId)
	AND
	(Registration.Country = @Country)

Posted 26-Jul-12 20:39pm

Prasad_Kulkarni

Comments

shinebudy 27-Jul-12 2:46am

not worked

Prasad_Kulkarni 27-Jul-12 2:47am

What you are passing in @Gender parameter.

shinebudy 27-Jul-12 2:50am

passing through gender

shinebudy 27-Jul-12 2:51am

sorry through session

Prasad_Kulkarni 27-Jul-12 2:52am

so you get male or female there itself then what is the problem?

shinebudy 27-Jul-12 2:53am

it retrive all data male and female both which i don't want

Prasad_Kulkarni 27-Jul-12 2:56am

How could it, if you're sending only male or female in @gender parameter?

shinebudy 27-Jul-12 2:59am

This is the the problem though my chechkbox select only female but display both male and female

Prasad_Kulkarni 27-Jul-12 3:04am

Is it in checkBoxGroup? If not then make it so. And how you're passing chkBox value to your SP. If possible show your code snippets.

Vipin_Arora 27-Jul-12 3:06am

the Same (AND operator) I have suggested and its got downvoted...without any comment

Prasad_Kulkarni 27-Jul-12 3:09am

Someone might not like'd your way of answer and results in downvote.

shinebudy 27-Jul-12 3:08am

<asp:RadioButtonList ID="rbGender" runat="server" RepeatDirection="Horizontal">
<asp:ListItem>Male
<asp:ListItem>Female

Prasad_Kulkarni 27-Jul-12 3:10am

..and how you're passing it to SP?

shinebudy 27-Jul-12 3:10am

SP pass in my class

Vipin_Arora · Answer 2 · 2012-07-26T20:38:00

Solution 1

hi,

There are lots of OR conditions in

SQL

WHERE

clause, which means if any of the condition is true, it will fetch all the data..
Use

SQL

AND

instead of

SQL

OR

.

Also, if you will use

SQL

AND

, make sure that whether relevant data is present in DB or not.

Posted 26-Jul-12 20:38pm

Vipin_Arora