get substring of selected value of combobox on selection changed event

Question

0.00/5 (No votes)

See more:

C#

string sub1 = (Convert.ToString(dateTimeDate.Value)).Substring(3, 2);
           string sub2 = (Convert.ToString(dateTimeDate.Value)).Substring(8, 2);
           txtRefNo.Text = sub1 + sub2;

             string sub = comboDescription.Text.Trim();

               if (comboDescription.SelectedIndex > -1 || sub != string.Empty)
               {
                   sub = (Convert.ToString(sub)).Substring(0, 3);
                   txtRefNo.Text = txtRefNo.Text + sub;
               }

Above is code that i am calling on event

C#

comboDescription_SelectedIndexChanged(object sender, EventArgs e)

My problem is that this caused exception

C#

Index and length must refer to a location within the string.
Parameter name: length

how can i get the required value in same event.

Posted 18-Apr-13 22:32pm

pck.ns

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pheonyx · Answer 1 · 2013-04-18T22:45:00

Your error, I would guess, occurs on one of these three lines:

C#

string sub1 = (Convert.ToString(dateTimeDate.Value)).Substring(3, 2);

C#

string sub2 = (Convert.ToString(dateTimeDate.Value)).Substring(8, 2);

or

C#

sub = (Convert.ToString(sub)).Substring(0, 3);

Before you attempt any substring function, check the length of the string you are trying to extract. If it is less than either the index you are starting with or the index plus X characters you are trying to extract then it will fail.

For example you could try:

C#

string sub2 = (Convert.ToString(dateTimeDate.Value));
sub2 = sub2.length > 9 ? sub2.Substring(8, sub2.length > 11 ? 2 : (sub2.length-1)-8) : "";

What this would do is check to see if sub2 has a length more than 9 (i.e. it has a possible starting index of 8 as per your code. Then it looks to see what length it can extract, be it 1 or 2 characters. If it cannot extract the sub string it sets sub2 equal to "".

I'm not 100% on the code but its just a concept for you to work with.