Stumped by extremely simply Javascript

Question

1.00/5 (2 votes)

See more:

I haven't coded in Javascript directly in almost 3 years and I'm just recently jumping back into it. That being said, I can not for the life of me figure out why this isn't working.

HTML

<!DOCTYPE html>
<html>
<head><title>Hello</title><script>
function changeH1Text()
{
document.getElementById("H1").innerHTML = "I've been changed";
}
</script></head>

<body>

<h1 id="H1"  önload="changeH1Text()">Welcome to Javascript</h1>
<button type="button" onclick="document.getElementID("body").Text = 'The button changed me';">Click Me!</button>
</body>
</html>

Posted 2-Aug-13 2:56am

Kyle Gottfried

Add a Solution

2 solutions

Solution 2

Problem
If you check the console tab of FireBug in FireFox, you can see the following issue there.

Quote:

SyntaxError: syntax error

document.getElementID(

ThirdPage.aspx (line 1, col 22)

It clearly mentions that error is at document.getElementID(.
And here are two problems.

That is document.getElementByID not document.getElementID.
And there is no element in your code, which has a Id as body, it is rather a tag.

Solution
So, get correct Id of the control you want to use in the code with document.getElementByID.

Posted 2-Aug-13 4:03am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Comments

Sergey Alexandrovich Kryukov 2-Aug-13 10:19am

5ed. Not only the answer but also the advice how to deal with problems...
—SA

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 2-Aug-13 10:25am

Thanks a lot Sergey Alexandrovich Kryukov... :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

patrik polakovic · Accepted Answer · 2013-08-02T03:17:00

Solution 1

C#

<html>
<head>
	<title>Hello</title>
	<script>
	function changeH1Text()
	{
		document.getElementById("H1").innerHTML = "I've been changed";
	}
	</script>
</head>
 
<body id="body"  önload="changeH1Text();">
	<h1 id="H1">Welcome to Javascript</h1>
	<button type="button"  önclick="document.getElementById('body').innerHTML = 'The button changed me';">Click Me!</button>
</body>
</html>

I am recommending you to use FireBug. Its really handy plugin ;)

Posted 2-Aug-13 3:17am

patrik polakovic

Updated 2-Aug-13 3:21am

v2

Comments

Sergey Alexandrovich Kryukov 2-Aug-13 10:19am

5ed.
—SA

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 2-Aug-13 10:30am

Hi Sergey,

This will still not work, as body is not a Id of any control in the page, rather it is a tag.
I mentioned this issue in my solution as well.

Thanks,
Tadit

patrik polakovic 2-Aug-13 10:39am

"body" is ID of tag <body> ...

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 2-Aug-13 10:49am

Yeah, sorry.... My Apologies. I missed that...

+5ed... Sorry again. My mistake. :)

Also check my answer, where I have explained OP about the issues.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 2-Aug-13 10:51am

Sorry Sergey, my mistake... he has given Id to body tag as body. So, it i working... :)

Sergey Alexandrovich Kryukov 2-Aug-13 11:54am

It's OK, thanks for the note...
—SA

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 2-Aug-13 12:29pm

:)