How to simplify this LINQ statement?

Question

0.00/5 (No votes)

See more:

C#

if (ds.Tables.Count > 0)
            {
                DataTable dt = ds.Tables[0];
                if (dt.Rows.Count > 0)
                    for (int i = 0; i < ds.Tables.Count; ++i)
                    {
                        listForHyphen.AddRange(ds.Tables[i].AsEnumerable().Distinct().Where(r => r.Field<Int64>("Action") == 1 && r.Field<string>("Terms")!= null).Select(r => "(" + r.Field<string>("Terms") + ")"));
                        listForNdash.AddRange(ds.Tables[i].AsEnumerable().Distinct().Where(r => r.Field<Int64>("Action") == 0 && r.Field<string>("Terms")!= null).Select(r => "(" + r.Field<string>("Terms") + ")"));
                    }
            }

in this i store the values in two list, using linq, any possible to short this statement , it checks column Action is equal to 1 or 0 and its null or not null, then it add the value from column Terms to list

Posted 29-Dec-14 1:17am

smksamy

Updated 29-Dec-14 1:19am

v2

Add a Solution

Comments

Maciej Los 29-Dec-14 8:09am

What you mean by "simplify"?

BillWoodruff 29-Dec-14 10:08am

Could you please simplify what you mean by the question: "What you mean simplify ?" ?

Happy New Year ! :) Bill

Maciej Los 29-Dec-14 11:08am

Thank you, Bill.
Happy New Year for you too!

BillWoodruff 29-Dec-14 10:11am

Is this code working for you now ?

The assumption I see in your code is: if the first Table in ds.Tables has Rows greater than zero: then you enumerate all the Tables in ds.Tables: is that what you want ?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Shaun Blain · Answer 1 · 2014-12-29T12:39:00

The LINQ statement is not that bad compared to many I have seen. Why do you think it needs to be simplified?

If you just want to simplify the entire block of code, use a foreach statement on the rows in the table like so:

C#

foreach (DataRow row in ds.Tables[0].Rows)
{
   if ( Convert.ToInt64( row["Action"].ToString()) == 1 &&                            !string.IsNullOrEmpty( row["Terms"].ToString() ))
      listForHyphen.Add( "(" + row["Terms"].ToString() + ")" );
   if( Convert.ToInt64(row[ "Action" ].ToString()) == 0 && !string.IsNullOrEmpty(row[ "Terms" ].ToString()) )
      listForNdash.Add("(" + row[ "Terms" ].ToString() + ")");
}

This will end up being more efficient than using the LINQ and is very easy to understand.

Maciej Los · Answer 2 · 2015-01-11T09:04:00

Why to loop through the collection of rows?

This should works too:

C#

for (int i = 0; i < ds.Tables.Count; ++i)
                    {
                        listForHyphen.AddRange(ds.Tables[i].AsEnumerable().Distinct().Where(r => r.Field<Int64>("Action") == 1 && r.Field<string>("Terms")!= null).Select(r => "(" + r.Field<string>("Terms") + ")"));
                        listForNdash.AddRange(ds.Tables[i].AsEnumerable().Distinct().Where(r => r.Field<Int64>("Action") == 0 && r.Field<string>("Terms")!= null).Select(r => "(" + r.Field<string>("Terms") + ")"));
                    }

See: List<t>.AddRange Method[^]

How to simplify this LINQ statement?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0