Re: How to load text file into an array of structures..? - C / C++ / MFC Discussion Boards

Jeffrey Walton18-Feb-07 5:44

18-Feb-07 5:44

Hi ,

IIRC, there is a problem between VS and the SDK. For example, using Visual Studio 6.0 and the February 2005 SDK.

It finally made me move to Visual Studio .NET and Visual Studio 2005. I personally prefer VS 6.0.

Jeff

Re: VC++ linker error

cruppstahl18-Feb-07 7:35

cruppstahl

18-Feb-07 7:35

check if the file log4cxx.dll is corrupt (i.e. has a size of 0 bytes) and/or try to download/install log4cxx.dll again.

Code Snippets Manager

marvviki18-Feb-07 2:42

marvviki

18-Feb-07 2:42

What is the best Code Snippets Manager? I’ve found only this:

1) Total .NET SourceBook
http://www.fmsinc.com/dotnet/SourceBook/index.asp

2) Code Library .NET
http://myweb.hinet.net/home4/s630417/CodeLib.htm

3) Code Warehouse 2007
http://www.xcca.com

memory mapped I/O and private copies

cruppstahl18-Feb-07 2:28

cruppstahl

18-Feb-07 2:28

Hi!

I'm porting a library from unix/posix to Win32, and i have some troubles with the memory mapped file access.

I use mmap to read pages from the file, but use the normal write API to write the pages.

On unix, it looks like this:

buffer=mmap(0, size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, position);

On win32, it's a bit longer, as usual:

DWORD fsize=GetFileSize(fd, 0);

mmaph=CreateFileMapping(fd, 0, PAGE_READONLY, 0, fsize, 0);

buffer=MapViewOfFile(mmaph, PAGE_READWRITE, 0, (unsigned long)position, size);

My first problem is that CreateFileMapping is called whenever i read a page from the file. Is it an expensive operation? I just don't see a way to avoid this. If i cache the mmaph handle, and the file is resized because a page is appended, then this page is not covered by the file mapping...

The second problem: it just doesn't work. CreateFileMapping returns 0 and GetLastError is 5 (ACCESS_DENIED) when it's called for the very first time (fd is a valid file handle, and fsize is 4096).

The file handle was created with
CreateFile(filename, GENERIC_WRITE, 0, 0, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL|FILE_FLAG_OVERLAPPED, 0);

Thanks for any help
Chris

Re: memory mapped I/O and private copies

Waldermort18-Feb-07 3:17

Waldermort

18-Feb-07 3:17

I never used mapped files on Unix so I am unable to give you a comparison. If you wish to append data to a mapped file, try to specify a larger file size. In you code example you get the file size and use that, but it's perfectly safe to specify larger ( try to round it up to a 4k boundary for best performance ). Opening and closing the file is more expensive than mapping. I believe there is a flag to automatically grow the file for win2000+, but for the moment I just can't remember.

For your second problem, try using GENERIC_READ|GENERIC_WRITE, and try dropping the FILE_FLAG_OVERLAPPED.

Re: memory mapped I/O and private copies

cruppstahl18-Feb-07 7:23

cruppstahl

18-Feb-07 7:23

According to the MSDN documentation, you can specify a larger size for the view, but then the file is resized:

"If an application specifies a size for the file mapping object that is larger than the size of the actual named file on disk, the file on disk is increased to match the specified size of the file mapping object."

And that's not what i want, because my library is a database library, and it depends on the user if he wants to insert a lot of data - or insert nothing. in the first case, my view has to "grow", in the second case, the file should stay small...

But anyway, this is the smaller problem of the two. I tried using GENERIC_READ|GENERIC_WRITE and dropped the FILE_FLAG_OVERLAPPED, but i still get error 5 (ACCESS_DENIED) when calling CreateFileMapping...

How to load text file into an array of structures..? [modified]

Software_Specialist18-Feb-07 2:06

Software_Specialist

18-Feb-07 2:06

Hi all
i have created a simple console application calculating quotations for carpet cost. At the moment it ask user for name, lenght of room and do all calculation and produce output giving detail of the cost.

But now i want that details of previous customer quotation records which are held in a file named “quotes.txt” (a file of records qordered by unique uotation reference numbers). At the start of the program, the file will be loaded into an array of structures called “Quotes” in order that new quote records can be appended and the records can be viewed on screen. The updated file will be saved when the program exits.

So i am stucked here, please help me out. Please see the code below and guide me the right way to add the above functionality...

Thanks a lot

void main()
{
float Length=0, Width=0, Area=0, Cost=0, DeliveryCharge=0;
int UnitPrice=0, GuaranteePeriod=0, DelDistance=0, QuoteNum=INITIAL_QUOTE_REF_NUM;
char AnotherQuote, DelRequired;
char Name[NAME_LEN];
bool ValidPrice;
fstream InputFile;

do
{
//clrscr();

cout << "\nPlease enter surname and initials: ";
cin >> ws;
cin.getline(Name,NAME_LEN);

cout << "Please enter length of room: ";
cin >> Length;

cout << "Please enter width of room: ";
cin >> Width;

do
{
DeliveryCharge=0;
ValidPrice = true;

cout << "Please enter the price per square metre from the following price range:\n\n";
cout << POUND_SIGN << QUALITY_1 << ", " << POUND_SIGN << QUALITY_2 << ", " << POUND_SIGN
<< QUALITY_3 << ", " << POUND_SIGN << QUALITY_4 << ", " << POUND_SIGN << QUALITY_5 << "\n\n" << POUND_SIGN;
cin >> UnitPrice;

cout << "\n\n";

//Assign correct guarantee period for unit price entered.
switch(UnitPrice)
{
case QUALITY_1 : GuaranteePeriod=GUARANTEE_Q1; break;
case QUALITY_2 : GuaranteePeriod=GUARANTEE_Q2; break;
case QUALITY_3 : GuaranteePeriod=GUARANTEE_Q3; break;
case QUALITY_4 : GuaranteePeriod=GUARANTEE_Q4; break;
case QUALITY_5 : GuaranteePeriod=GUARANTEE_Q5; break;
default : cout << "\n\nInvalid price.\n\n";
ValidPrice = false;
}

}while (!ValidPrice);

Area = Length * Width;
Cost = Area * UnitPrice;

cout << "Do you require delivery? (Y/N) ";
cin >> DelRequired;

//Force correct input to delivery question.
while(toupper(DelRequired)!='Y' && toupper(DelRequired)!='N')
{
cout << "Invalid character - enter Y or N:";
cin >> DelRequired;
}

if(toupper(DelRequired)=='Y')
{
cout << "\n\nPlease enter delivery distance in miles: ";
cin >> DelDistance;

if(DelDistance >=0 && DelDistance <=ZONE1)
{
DeliveryCharge = Cost * ZONE1_CHARGE;
}
else
{
if(DelDistance <=ZONE2)
{
DeliveryCharge = Cost * ZONE2_CHARGE;
}
else
{
if(DelDistance <=ZONE3)
{
DeliveryCharge = Cost * ZONE3_CHARGE;
}
else
{
DeliveryCharge = Cost * ZONE4_CHARGE;
}
} //end else > ZONE2
} //end else > ZONE1
} //end delivery required

cout << endl << endl << endl
<< setfill('_') << setw(TABLE_WIDTH) << "" << "\n\n"
<< setfill(' ')
<< setw(7) << " Ref | " << setw(NAME_COL_WIDTH) << " Name | " << setw(COST_COL_WIDTH) << "Carpet | " << setw(DELIVERY_COL_WIDTH)
<< "Delivery | " << setw(TOTAL_COL_WIDTH) << " Total | " << setw(GUARANTEE_COL_WIDTH+7) << "Guarantee |" << endl
<< setfill('_') << setw(TABLE_WIDTH) << "" << "\n\n" << setfill(' ');

cout << fixed << showpoint << setprecision(2);

cout << setfill(' ')
<< setw(7) << QuoteNum << " | "
<< setw(NAME_COL_WIDTH) << Name << " | "
<< setw(1) << POUND_SIGN << setw(COST_COL_WIDTH-4) << Cost << " | "
<< setw(1) << POUND_SIGN << setw(DELIVERY_COL_WIDTH-4) << DeliveryCharge << " | "
<< setw(1) << POUND_SIGN << setw(TOTAL_COL_WIDTH-1) << Cost + DeliveryCharge << " | "
<< setw(7) << "Years: " << setw(GUARANTEE_COL_WIDTH) << GuaranteePeriod << " |"
<< endl;

cout << "\n\nEnter another quote?";
cin >> AnotherQuote;

} while(AnotherQuote=='Y'||AnotherQuote=='y');
///THIS IS WHAT I TRIED, BUT ITS NOT READING THE FILE.........////
/*char FileString[512];

InputFile.open("\\Quotes\\CarpetQuotes.txt", ios::in);
if(InputFile.is_open())
{
InputFile.getline(FileString, sizeof(FileString));
}
*/
cout << "\n" << endl;
system("pause");
}

-- modified at 8:12 Sunday 18th February, 2007

Re: How to load text file into an array of structures..?

Waldermort18-Feb-07 3:11

Waldermort

18-Feb-07 3:11

Before we can help you, we need to know exactly how the text file is structured. ie, is it 1 customer per line, are items seperated by anything? Perhaps if you show us an example of the first few customers.

Also, you say you want to load it into a struct, how is the struct defined? What iformation does it hold and in what format?

Also, it's necessary to post so much code in the forum. Always try to keep your snippets as small as possible and only show us the section you feel has a problem, unless asked otherwise.

Re: How to load text file into an array of structures..?

Software_Specialist18-Feb-07 4:36

Software_Specialist

18-Feb-07 4:36

The format of the text is as follows:-

Quote Number
Customer Surname & Initials
Cost of carpet
Delivery cost
Guarantee

So text file is like below:-

1000
Snape LC
3003.00
900.90
2

1001
Bond J
6936.00
0.00
4

Well i have not defined the struct as yet. I am lil confused about this part. If you could refer me any example or something similar then it would be gr8..
And yeh ill keep in mind about snippets...
Thanks for replying

Re: How to load text file into an array of structures..?

Waldermort18-Feb-07 5:11

Waldermort

18-Feb-07 5:11

OK, now I see.

For this to work correctly, you must be certain that each customer is layed out the same. IE, if you have yet to create a cost, within the text file you should place 0 and not an empty line.

For the struct, I would do something like

struct CUSTOMER<br />
{<br />
DWORD QuoteNumber;<br />
CHAR  Surname[56];<br />
CHAR  Initials[2];<br />
DWORD CarpetCost; // in Pence/Cents<br />
DWORD DeliveryCost;<br />
SHORT Guarantee; // mind the pun<br />
}

Now since the file is layed out with 5 lines per customer, I would create a function to read a single customer then call this in a loop until there are non remaining.

bool ReadCustomerDetails( FILE* hFile, CUSTOMER* pCustomer )

Open the file with fopen(), read each line with gets() then depending on the which line you read convert it to the datatype in the struct.

Have a go at coding that, need any help just say the word.

Re: How to load text file into an array of structures..?

David Crow18-Feb-07 16:29

David Crow

18-Feb-07 16:29

WalderMort wrote:
Now since the file is layed out with 5 lines per customer, I would create a function to read a single customer then call this in a loop until there are non remaining.

bool ReadCustomerDetails( FILE* hFile, CUSTOMER* pCustomer )

Open the file with fopen(), read each line with gets() then depending on the which line you read convert it to the datatype in the struct.

Your struct is good, but I would opt for reading/writing it as binary instead so that one fread() could be used per record, rather than multiple fgets() calls.

"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15

"Judge not by the eye but by the heart." - Native American Proverb

Re: How to load text file into an array of structures..?

Waldermort18-Feb-07 18:24

Waldermort

18-Feb-07 18:24

If I were to code something like this myself, I probably would. But given that the OP comes across as a bit of a newbie I don't want to confuse him too much Smile | :)

Re: How to load text file into an array of structures..?

Software_Specialist19-Feb-07 1:53

Software_Specialist

19-Feb-07 1:53

Thanks, its making some sence now...
I was confused with this part as in specs it was written that file would be loaded to array of structurs in order that new records can be appended and the records can be viewed on screen. So i guess its just to create a struct with all the fields which are included in text..and then text is just called and saved...
I have started coding for it. Would ask you if i face any further problems..

Thanks a lot..

Re: How to load text file into an array of structures..?

Bram van Kampen19-Feb-07 13:30

Bram van Kampen

19-Feb-07 13:30

Why on earth use a Text File for this! If it HAS to be a Text File, I would add a Sync Key at the start of each record. (This is Line of Text such as:"$$$***&&&?//??**<<>>"). You scan this line at the start of each record, and compare it with your Hardcoded String. If it does not compare, you're out of sync. This means that you are alerted to something being wrong, and you have atleast some hope of recovery.
The way I would approach this would be to store the structures directly in the file as binary. Keep in mind that what starts now as small data, will in time grow into a huge record. Searching in a Huge textfile ends up time consuming. Weeding out redundant records can be problematic.

LateNightsInNewry

dispaly thambnails of the images on the view

vasu_sri18-Feb-07 0:33

vasu_sri

18-Feb-07 0:33

how can i display the thumbnail preview of the images on the view?

Regards,
Srinivas

Re: dispaly thambnails of the images on the view

Hamid_RT18-Feb-07 4:41

Hamid_RT

18-Feb-07 4:41

You dont need to ask a same question Wink | ;)

WhiteSky

Re: dispaly thambnails of the images on the view

Mark Salsbery18-Feb-07 7:19

Mark Salsbery

18-Feb-07 7:19

Do you know what a thumbnal IS? If so, then you should also know that displaying a mini-version
of a bitmap image is done the same way as displaying the big one, right?

Great job, team. Head back to base for debriefing and cocktails.

Resource Localization (Polish Character)

Anik3318-Feb-07 0:28

Anik33

18-Feb-07 0:28

I am using Visual Studio 6.0. VS resource editor does not support unicode. So when I write some polish characters in string table or dialog controller "??" values are shown. How should I make a resource file/ resource dll for Polish language?
Thanks in advance.

Re: Resource Localization (Polish Character)

ovidiucucu18-Feb-07 12:38

ovidiucucu

18-Feb-07 12:38