The Weird and The Wonderful

@DaysBack 

SELECT CASE
    WHEN Field1 = 'Something #1' THEN 'Result #1'
    WHEN Field1 = 'Something #2' THEN 'N/A'
    WHEN Field1 = 'Something #3' THEN '(Empty)'
    ELSE 'N/A'
    END

djj55 wrote:

What was I thinking

if (someBooleanVariable == true)
    return true;
else
    return false;

return someBooleanVariable == true ? true : false;

return someBooleanVariable ? true : false

return someBooleanVariable

return someBooleanVariable ? Boolean.Parse(Boolean.TrueString) : Boolean.Parse(Boolean.FalseString);

return someBooleanVariable.ToString() == Boolean.TrueString? Boolean.Parse(Boolean.TrueString) : Boolean.Parse(Boolean.FalseString);

Chris Maunder wrote:

You mean they missed the totally obvious contraction to

C#

return someBooleanVariable ? true : false

They should hang their head in shame!

return (someBooleanVariable == true)

if (((Boolean)someBooleanVariable).equals(true)) {
  return someBooleanVariable == true ? someBooleanVariable : false;
} else {
  return someBooleanVariable == false ? someBooleanVariable : true;
}

G James wrote:

Later they refactored it to this thinking it was an improvement.

C#

return someBooleanVariable == true ? true : false;

interface IBooleanConverter {
 bool BooleanToBoolean(bool value);
}

class BooleanConverter : IBooleanConverter {
 public BooleanToBoolean(bool value) {
  return value == true ? true : false;
 }
}

interface IBooleanConverterFactory {
 IBooleanConverter CreateBooleanConverterFactory();
}

class ConfigurationBooleanConverterFactory : IBooleanConverter {
 public IBooleanConverter CreateBooleanConverter() {
  return (IBooleanConverter)
         Activator.CreateInstance(ConfigurationManager.AppSettings["Types.BooleanConverter"]);
 }
}

static class BooleanConverterFactoryFactory {
 public IBooleanConverterFactory CreateBooleanConverterFactory() {
  return (IBooleanConverterFactory)
         Activator.CreateInstance(ConfigurationManager.AppSettings["Types.BooleanConverterFactory"]);
 }
}

// ...

return BooleanConverterFactoryFactory.CreateBooleanConverterFactory().CreateBooleanConverter().BooleanToBoolean(someBooleanVariable == true ? true : false);

public static T As<T>(this object obj) {
 return obj as T;
}

Sentenryu wrote:

it's so dificult to believe i'm seeing so well structured sh*t-code