|
Easier isn't always better.
|
|
|
|
|
AddWithValue can cause problems where conversions may not be as expected: better to use Add and be explicit about what you are doing. And what harm the @? Just because something is optional doesn't mean you shouldn't use it - verbosity is king - it promotes clarity.
"If you think it's expensive to hire a professional to do the job, wait until you hire an amateur." Red Adair.
nils illegitimus carborundum
me, me, me
|
|
|
|
|
Notice anything else about why the code is strange?
|
|
|
|
|
Yes indeed, but I didn't think that was your point.
"If you think it's expensive to hire a professional to do the job, wait until you hire an amateur." Red Adair.
nils illegitimus carborundum
me, me, me
|
|
|
|
|
My only point is to make fun of as many things as is possible in that code snippet. However, the only real thing wrong with it is converting an integer to a string and then using that string as the value of a parameter that was just explicitly specified to be an integer.
|
|
|
|
|
Indeed - but you missed the smiley! I took you seriously! I wouldn't do it in that way (even with correct typing), in any case - too clumsy and not reusable. 
"If you think it's expensive to hire a professional to do the job, wait until you hire an amateur." Red Adair.
nils illegitimus carborundum
me, me, me
|
|
|
|
|
AspDotNetDev wrote: "@" is optional when specifying parameters.
Actually I believe the "@" symbol only became optional in .Net Framework 2.0 and above, before that it was a requirement. Please don't take my word for that, but its coming from a rusty memory of my own personal experience.
|
|
|
|
|
Well, in the codebase I handle I'm enforcing a standard of explicitly stating the parameter type when using ADO.net. Granted, we're autogenerating the DAL using an internal tool, but it helps in a lot of situations. Example: when using a string field, if you specify the length, ADO.net will truncate the parameter to the expected maximum length. Otherwise it gets passed to the underlying db and the query will error out. For us, the former behaviour is preferred. YMMV
Luca
The Price of Freedom is Eternal Vigilance. -- Wing Commander IV
En Það Besta Sem Guð Hefur Skapað, Er Nýr Dagur.
(But the best thing God has created, is a New Day.)
-- Sigur Ròs - Viðrar vel til loftárása
|
|
|
|
|
I believe this line:
cmd.Parameters("@SomeID").Value = Session("SomeID").ToString()
Should be this:
cmd.Parameters("@SomeID").Value = Int32.Parse(Session("SomeID").ToString())
|
|
|
|
|
The best thing I ever saw while debugging code was comments in Polish. The variables were also given Polish names so discerning the possible usage was more difficult. I asked a Polish programmer to please translate the comments and he told me there was not an English translation possible. I've always thought that was funny. To this day, in the code, when someone wants to use the buffer class they construct a CBoffo, usually called Boffo. It always reminds me of Hans and Franz doing a SNL skit.
|
|
|
|
|
We outsourced the programming of an application to a pole (or whatever people from poland are called) contractor once. What did we get? The whole program written in polish, even the documentation was in polish.
|
|
|
|
|
That is pretty funny . Have you outsourced anything since then?
Soren Madsen
"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty
|
|
|
|
|
SoMad wrote: Have you outsourced anything since then?
Nope. We are now writing the code in english on-site. And we still try to retranslate the polish code back to english.
|
|
|
|
|
|
SoMad wrote: Sorry, I feel bad for you guys.
No need to do so. We just hired another polish dev to write the code for updates of the app until we fully translated the source.
|
|
|
|
|
You did what!!! Hmmm...I think I need some time to figure out if that is a brilliant move or if it is the mother of bad decisions 
Soren Madsen
"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty
|
|
|
|
|
I am not sure but I certainly hope that the new pole is writing the additional code in english 
|
|
|
|
|
[Dear Lord. Please let the new Polak code and document in Polish too] 
I am so sorry, but this is the funniest thing I have seen all week. I don't want it to end 
Soren Madsen
"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty
|
|
|
|
|
That's what you get when after the first review you provide the feedback "it's mostly good but needs more polish" 
|
|
|
|
|
Hahaha, kind of hilarious, but easily avoidable. Should have asked for a code review early in the dev cycle to make sure this new contractor was up to snuff.
|
|
|
|
|
Mike Marynowski wrote: Should have asked for a code review early in the dev cycle to make sure this new contractor was up to snuff.
We shouldn't have asked him "to polish the app a bit".
|
|
|
|
|
Did he use Polish diacritic in the variable names (like "ą ę ó" etc.)? That would be awful. BTW I have no idea what the hell is "Boffo"... it sounds like a joke to me.
Once I was working on a project in which there was a requirement to name database columns in Polish.  Maybe it's because the rest of it was in Deutsch. The code was in English, though, while comments still in Polish...
Greetings - Jacek
|
|
|
|
|
While I was in a telephonic conference at work, I heard someone speak "Can we get someone to enhance the bugs in the application?". I'm still wondering how on Earth someone can enhance a bug.
|
|
|
|
|
What's so odd about this?? It's done every minute of every day when someone sits in front of a computer and writes code. We call them "features". 
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
