C#

Rob Philpott wrote:

we'll be able to zip anything up in just 6 digits..

candogu wrote:

I need to encode a string to a 6 or 8 digits hash and decode it to original string

Quote:

We do not do your homework: it is set for a reason. It is there so that you think about what you have been told, and try to understand it. It is also there so that your tutor can identify areas where you are weak, and focus more attention on remedial action.

if (condition1) 
{
    //code to be executed for condition 1
} 
else if (condition2) 
{
    //code to be executed for condition 2
}
else
{
    //code to be executed otherwise
}

If String.IsNullOrEmpty(txt_batchcode.Text) Then
    System.Windows.MessageBox.Show("Batch Cod Field Is blank Please Select Batch")
Else
    Try
        cmd.Parameters.AddWithValue("@flag", flag)
        cmd.Parameters.AddWithValue("@sno", txtsno.Text)

Dim es As Input.KeyEventArgs
If String.IsNullOrEmpty(txt_pname.Text) Then ' good this is better than comparing to ""
comlibobj.msg("Please Enter Name", "Warning")
e.Handled = True
Else
cmd = New SqlCommand("", sqlcn)
cmd.CommandType = CommandType.StoredProcedure
Dim flag As String = ""

'BAD! this allows for SQL injection.
Dim schcmd As New SqlCommand("SELECT * FROM mschemst WHERE scode='" + txt_pcode.Text + "'", sqlcn)
Dim schrd As SqlDataReader = schcmd.ExecuteReader
While schrd.Read
Dim sxm As String = schrd("scode")
If sxm.Count > 0 Then
userCh = "Modify"
End If
' not wrong but you could do something If txt_schfree1.Text = txt_schfree2.Text = txt_schfree3.Text = ... = "0" Then
' but that´s semantics, you are checking this within the while loop though, can´t you take it out and assign a boolean?
If txt_schfree1.Text = "0" And txt_schfree2.Text = "0" And txt_schfree3.Text = "0" And txt_schqty1.Text = "0" And txt_schqty1.Text = "0" And txt_schqty2.Text = "0" And txt_schqty3.Text = "0" Then
userCh = "Delete"
End If
End While
schrd.Close()' what if txt_batchcode.Text is empty or wrong input value or whatever?
If txt_batchcode.Text.Count > 0 Then
Batchno = txt_batchcode.Text
Else
Batchno = Batchno
End If
If userCh = "Add New" Then
flag = "A"
ElseIf userCh = "Modify" Then
flag = "M"
ElseIf userCh = "Delete" Then
flag = "D"
End If
batch = ""
batch = DirectCast(cmb_batch.SelectedItem, ComboBoxItem).Content.ToString()
txtsno.Text = Val(comlibobj.cdmaker("", "mschemst", "sno", 9999))

' again UI stuff where you just touched the database  
If cmb_batch.Visibility = Windows.Visibility.Visible Then
If cmb_batch.Visibility = Windows.Visibility.Visible And cmb_batch.SelectedIndex = 0 Then
System.Windows.MessageBox.Show("Please Select Batch If use Batch Wise Product And enable Select Bacth")
Else
If cmb_batch.SelectedIndex = 1 Then
' OUCH: SQL injection
cmd = New SqlCommand("SELECT BATCHNO FROM mbachmst WHERE BCODE='" + txt_pcode.Text + "'", sqlcn)
rdr = cmd.ExecuteReader
While rdr.Read
Batchno = rdr("BATCHNO").ToString
txtsno.Text = Val(comlibobj.cdmaker("", "mschemst", "sno", 9999))
' this piece of code returns 3 times!  Perhaps a function call instead?
Try
cmd.Parameters.AddWithValue("@flag", flag)
cmd.Parameters.AddWithValue("@sno", txtsno.Text)
cmd.Parameters.AddWithValue("@scode", txt_pcode.Text)
cmd.Parameters.AddWithValue("@SBATCHNO", Batchno)
cmd.Parameters.AddWithValue("@sqty1", txt_schqty1.Text)
cmd.Parameters.AddWithValue("@sfree1", txt_schfree1.Text)
cmd.Parameters.AddWithValue("@sqty2", txt_schqty2.Text)
cmd.Parameters.AddWithValue("@sfree2", txt_schfree2.Text)
cmd.Parameters.AddWithValue("@sqty3", txt_schqty3.Text)
cmd.Parameters.AddWithValue("@sfree3", txt_schfree3.Text)
cmd.Parameters.AddWithValue("@sfromdt", comlibobj.Datecheck(txt_sfromdt.Text))
cmd.Parameters.AddWithValue("@senddt", comlibobj.Datecheck(txt_senddt.Text))
cmd.Parameters.AddWithValue("@smes", txt_smes.Text)
cmd.Parameters.AddWithValue("@sminstk", IIf(txt_minstk.Text = 0, 0, txt_minstk.Text))
cmd.ExecuteNonQuery()
Catch agex As Exception
' users are generally not interested in Exception messages. Log the details and generate a user friendly message.
' alternatively you can say "an error occurred, please provide following details to sysadmin" + agex.Message;
MsgBox(agex.Message)
End Try
cmd.Dispose()
End While
rdr.Close()
Me.Close()
comlibobj.upd()
ElseIf cmb_batch.SelectedIndex = 2 Then
If String.IsNullOrEmpty(txt_batchcode.Text) Then
System.Windows.MessageBox.Show("Batch Cod Field Is blank Please Select Batch")
Else
Try
cmd.Parameters.AddWithValue("@flag", flag)
cmd.Parameters.AddWithValue("@sno", txtsno.Text)
cmd.Parameters.AddWithValue("@scode", txt_pcode.Text)
cmd.Parameters.AddWithValue("@SBATCHNO", Batchno)
cmd.Parameters.AddWithValue("@sqty1", txt_schqty1.Text)
cmd.Parameters.AddWithValue("@sfree1", txt_schfree1.Text)
cmd.Parameters.AddWithValue("@sqty2", txt_schqty2.Text)
cmd.Parameters.AddWithValue("@sfree2", txt_schfree2.Text)
cmd.Parameters.AddWithValue("@sqty3", txt_schqty3.Text)
cmd.Parameters.AddWithValue("@sfree3", txt_schfree3.Text)
cmd.Parameters.AddWithValue("@sfromdt", comlibobj.Datecheck(txt_sfromdt.Text))
cmd.Parameters.AddWithValue("@senddt", comlibobj.Datecheck(txt_senddt.Text))
cmd.Parameters.AddWithValue("@smes", txt_smes.Text)
cmd.Parameters.AddWithValue("@sminstk", IIf(txt_minstk.Text = 0, 0, txt_minstk.Text))
cmd.ExecuteNonQuery()
Catch agex As Exception
MsgBox(agex.Message)
End Try
cmd.Dispose()
Me.Close()
comlibobj.upd() ' is this executed after calling Close?  (could be, not sure)
End If
End If
End If
Else
Try
cmd.Parameters.AddWithValue("@flag", flag)
cmd.Parameters.AddWithValue("@sno", txtsno.Text)
cmd.Parameters.AddWithValue("@scode", txt_pcode.Text)
cmd.Parameters.AddWithValue("@SBATCHNO", Batchno)
cmd.Parameters.AddWithValue("@sqty1", txt_schqty1.Text)
cmd.Parameters.AddWithValue("@sfree1", txt_schfree1.Text)
cmd.Parameters.AddWithValue("@sqty2", txt_schqty2.Text)
cmd.Parameters.AddWithValue("@sfree2", txt_schfree2.Text)
cmd.Parameters.AddWithValue("@sqty3", txt_schqty3.Text)
cmd.Parameters.AddWithValue("@sfree3", txt_schfree3.Text)
cmd.Parameters.AddWithValue("@sfromdt", comlibobj.Datecheck(txt_sfromdt.Text))
cmd.Parameters.AddWithValue("@senddt", comlibobj.Datecheck(txt_senddt.Text))
cmd.Parameters.AddWithValue("@smes", txt_smes.Text)
cmd.Parameters.AddWithValue("@sminstk", IIf(txt_minstk.Text = 0, 0, txt_minstk.Text))
cmd.ExecuteNonQuery()
Catch agex As Exception

MsgBox(agex.Message)
End Try
cmd.Dispose()
Me.Close()
comlibobj.upd()
End If