|
Do you really think the person who broke it, has the skill set to fix it?
Public shaming doesn't work and it is terrible for morale.
|
|
|
|
|
Slacker007 wrote: Public shaming doesn't work and it is terrible for morale.
I saw a plugin or something (years ago) for Continuous Integration servers which on a failed build adds the avatar of the dev who broke it and displays it on the page.  I think it's part of the game, it's not real shaming, just an incentive to quickly fix what you broke. No one wants his mugshot to be posted next to a failed build.
|
|
|
|
|
|
LOL. That's awesome. 
|
|
|
|
|
Pawel Krakowiak wrote: it's not real shaming
I would say that's up the shamed person to decide.
Wrong is evil and must be defeated. - Jeff Ello
(√-sh*t) 2
|
|
|
|
|
Pawel Krakowiak wrote: Another dev went in and changed how some code works
Pawel Krakowiak wrote: This really grinds my gears.
This brings back old memories. Years ago at a large corp. I was forced to write code over a weekend, because "it had to be comleted". I did the work, wrote some documentation, wrote test cases and put the code out for QA team.
Of course, even though it had to be done immediately, they never got around to the code for weeks later. Oh, yes, this was HIGH PRIORITY. Whatever.
Anyways, weeks later, the guy puts the stuff into production and someone comes to me.
"That fails upon start up. Can you have a look."
I looked at the code. What? Wait. I've never seen this code. Even though it's supposedly my code. What is going on?
After much searching I find a contractor. An architect who is certainly my genius master.
He says, "Oh, I rewrote that code."
"Well, you did a bang up job," I said. "It doesn't even start. You're going to have to fix it."
"I don't do that," he said.
Later my boss told me I had to fix The Genius Architect's code even though I had already written code that worked and the GENIUS rewrote my code.
What?!? (deployment of interrobang)
That is utter stupidity!!!
I totally understand your frustration. He who touches code should fix it!!!
|
|
|
|
|
newton.saber wrote: He who touches code should fix it!!!
THIS.
|
|
|
|
|
newton.saber wrote: Later my boss told me I had to fix The Genius Architect's code even though I had
already written code that worked and the GENIUS rewrote my code.
What?!?
(deployment of interrobang)
At which point you just reverted the architards checkin to the prior working version?
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason?
Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful?
--Zachris Topelius
Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies.
-- Sarah Hoyt
|
|
|
|
|
Dan Neely wrote: reverted the architards checkin to the prior working version?
That's exactly what I wanted to do, but I wasn't allowed. It was completely political.
Basically, without examining anything my boss said, "His unworking code is better than your working code."
Now you could assume I'm an idiot and my code is complete crap. But, honestly, the code worked very well and was actually designed and I had unit tests, etc.
Here's the kicker...
The code was never put into production anyway, because the entire project went belly-up after they spent millions $$$ paying for contractors (such as the architect) who never could get the final product running. ugh!
|
|
|
|
|
Pawel Krakowiak wrote: I feel that whoever breaks stuff should be publicly shamed
That would include everyone at some point then. 
There are only 10 types of people in the world, those who understand binary and those who don't.
|
|
|
|
|
Of course it would! I have never met a developer who never introduces any bugs. I am fully aware I'd be shamed on occasion as well.
|
|
|
|
|
Pawel Krakowiak wrote: I am fully aware I'd be shamed on occasion as well.
If you think that would help then I suggest bringing it up to your manager.
There are only 10 types of people in the world, those who understand binary and those who don't.
|
|
|
|
|
Quote: I have never met a developer who never introduces any bugs
You should go down to the job center, I'm sure you'll find a few developers down there who haven't introduced bugs in months.
|
|
|
|
|
What, there are unemployed software engineers?!
|
|
|
|
|
They know regex. That's a coding language, right?
|
|
|
|
|
I used to list HTML under known programming languages on my CV.
|
|
|
|
|
Pawel Krakowiak wrote: ... web app ... modal dialog ...
Hopefully not using showModalDialog? That's been disabled in Chrome[^], and deprecated in Firefox[^].
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Sorry, but I'm with Pete on this one. Public shaming is never going to work out well.
|
|
|
|
|
Why not? I did not mean real shaming (there was a winking emoticon), rather something like described here[^]. It's a joke. 
|
|
|
|
|
Any developer introduces bugs. It is the direct consequence of writing code. There is no point in shaming, even playfully - just point it out and correct it, or ask the one who introduced it to fix it (maybe there was some good reason and you yourself break something trying to fix it).
One thing that must be clear is that any relevant change must be tagged in the comments and in the changelog, so that it is backtrackable. I work duo with a colleague, and when I change some established code I never remove it, just comment out the prevoius lines, insert my own and tag with "[NAMEOFTHEMODIFICATION] xx/mm/yyyy Denis: I did this because...". The same does he (ok, not really, but if it's not tagged it's him )
|
|
|
|
|
|
|
Pawel Krakowiak wrote: I feel that whoever breaks stuff should be publicly shamed
(for example in the CI server's website, but of course my client doesn't have
CI...) and responsible for fixing it.
Let's see. Two weeks ago I fixed a few security issues in C code written in 1994 by someone I don't know who worked for a company that exists no more. As much as I would like to find the original coder and make him fix the bug, somehow I feel that won't work.
|
|
|
|
|
Is this not the path of progress?
One person creates something useful; which the stakeholders want to expand functionality for. This then gets worked upon by new team members who will not have the same knowledge levels as the creator - they add new features, and also "inject" bugs. These bugs need to be worked upon - and unfortunately (or fortunately?) in this case, it is the creator himself assigned to fix them
Not just software, but automobiles, airplanes, bridges, etc. - would have had the same path towards their current state, isn't it?
|
|
|
|
|
Message Closed
modified 20-Oct-19 21:02pm.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
