|
I think code / peer review is one of the most important aspects for any programmer who isn't working solo. My belief is based on the following reasons;
A) Learning, a novice can be mentored by a developer with years of experience. An experienced developer could benefit from a novice just out of college, who may have been taught a new trick or two.
B) Everyone makes mistakes, you are arrogant if you believe you cannot benefit from someone reviewing your code. Developers get into "patterns" of thought and much like a writer of a novel they could miss the obvious.
C) Auditting & Security, it's important to the client that as a company you can show your practices are designed for quality, peer review is part of that.
I understand that everyone has there own way of doing things but in my opinion thats a different discussion.
Simon Lee Shugar (Software Developer)
www.simonshugar.co.uk
"If something goes by a false name, would it mean that thing is fake? False by nature?" By Gilbert Durandil
|
|
|
|
|
Simon Lee Shugar wrote: you are arrogant if you believe you cannot benefit from someone reviewing your code.
I agree with this statement very much. 
It is sad, but there are many arrogant people in our field, and on this site. 
|
|
|
|
|
1) As has been mentioned a few times already finding other devs who actually engage during reviews is hard. A better option I've found (after spending multiple months trying to get the team to participate in reviews rather than just say "yup that's fine") is pair programming. Either a full on formal approach where you have all devs working in pairs or a less formal approach where you identify features that will be complicated to implement and have two people pair up to work on it. I've found that the devs are more engaged and it's easier to spot the bad stuff as it's being written.
2) Pretty much only works if you're going the full open-source route. Otherwise, as has been previously stated, you'll probably run afoul of NDAs and IP rights.
|
|
|
|
|
I think the biggest problem with good code reviews are finding reviewers that are familiar enough with the problem or subject matter to give good feedback. Since we are one deep in all positions where I work and everyone is working at 120% capacity that isn't easy. Without that code reviews degenerate into trivial complaints about variable naming, code factoring, and the like. For me having the time to do good unit testing is more valuable than code reviews.
|
|
|
|
|
tom1443 wrote: I think the biggest problem with good code reviews are finding reviewers that are familiar enough with the problem or subject matter to give good feedback
Very good point.
tom1443 wrote: good unit testing
Is always helpful and mandatory for us.
|
|
|
|
|
Both 1 and 2, but because I was the sole developer for a few years.
Now, there's another young person working with me. For the first bit, while he was getting going understanding the app/data/environment/etc, we'd discuss approaches and I'd at least give a quick glance at checkins and discuss alternatives.
He's proven himself to be quite competent though. Now it's when one of us knows we're doing something a bit off, we'll talk with the other..."what do you think about this approach".
It seems to be working well. For such a small company, I don't think we have (or choose not to have) the resources for a more formal review structure. This makes me sad, as I know getting more eyes on the project would only make it stronger.
|
|
|
|
|
I agree, that with small companies, things have to be tweaked in such a way that it works.
|
|
|
|
|
Love 'em, but I do a lot of one man coding myself.
Honestly, I have my editor(s) setup to do a lot of the formatting automatically,
and to reformat my code.
I can't share my code because of NDAs as mentioned elsewhere. But that does NOT mean you
cannot review your own code! As a note, we did all of our code reviews on Fridays. Usually
after lunch, through the end of the day. It was designed to discourage working over the weekend,
and to help us unwind and not be stressed out. I felt it was the perfect way to end the week.
But before coded reviews are started, coding standards must exist. If you have those, then I would
take some time out at the end of the week, and review your own code. Eventually you will find it is second nature. Also, once we determined something to be dangerous (or bug inducing), we updated our coding standards to prevent it. Like declaring a stack based buffer of a fixed size to read in from a stream of unknown length (buffer overflow, anyone?).
I think if you review your own code, and look it over, and would be proud to show it to anyone who asked... You are ahead of 70% of the coders out there. Also, when you find yourself referring to your old code, you will appreciate it and reuse it more...
Kirk Out!
|
|
|
|
|
Code reviews are great for showing new team members "how we do it here".
I usually work alone, but will occasionally ask a colleague, "what do you think of this method/function/whatever?"
On the other hand I'm mostly working with SSIS now, and that isn't code.
|
|
|
|
|
No arguments here. Agree that code reviews are important.
|
|
|
|
|
1) When I make changes that affect a lot of behavior of the application, or I've had to discuss the changes with others at length, I have someone do a code review. The rest of the time I trust that I know what I'm doing.
2) Never, it would be a waste of my time. Nobody who doesn't understand the domain and structure of the rest of the program is going to be able to make any meaningful observations.
We can program with only 1's, but if all you've got are zeros, you've got nothing.
|
|
|
|
|
patbob wrote: I trust that I know what I'm doing.
I hear you but that is a very, very dangerous stance. Just my opinion on that. 
|
|
|
|
|
Ice formed with a twist: Look at it[^] 
modified 29-Jan-15 10:50am.
|
|
|
|
|
A small description would be dandy... especially when the link is in Finish (or something like that)
I'd rather be phishing!
|
|
|
|
|
Its in Norwegian[^], but I didnt post the translate.google link as the pictures went away.
|
|
|
|
|
If you use Chrome, then you can just open the page and an icon will appear at the right end of the address/search bar. Looks like two grey squares with a couple of dots. Click it, and you get the option to translate the page in situ.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
I know, but there are actually people out there that doesn't use chrome  
PS: I want that ice in my drinks from now on. 
|
|
|
|
|
I'd rather be phishing!
|
|
|
|
|
Chrome offered to translate it for me and seemingly did a great job.
Contrary to popular belief, nobody owes you anything.
|
|
|
|
|
We sometimes get stuff like this happen at Niagara Falls when the conditions are right. The falls give of a constant spray. With temperatures that are not cold enough to freeze the spray as it forms, but surfaces that are below freezing ice forms (much like freezing rain). Add the "right" kind of winds/air turbulence, interesting ice sculptures form naturally.
I've only been there once when conditions were perfect; it was like a scene from Narnia.
Life is like a s**t sandwich; the more bread you have, the less s**t you eat.
|
|
|
|
|
Personally I haven seen an freezing rain on a waterfall, but the pictures i found were truly stunning.
|
|
|
|
|
We get freezing rain here on a regular basis. Because it's normally a transition condition, it doesn't usually last long, but when it does, it's truly nature's savage beauty. Roads become like glass and trees get so heavily coated with ice that they start shedding branches and even limbs. I still have poplars on my property from last years "ice storm" where a 30' tree's top is almost touching the ground. I've cut most of those down for firewood, but there are still a few.
Life is like a s**t sandwich; the more bread you have, the less s**t you eat.
|
|
|
|
|
We don't really get the conditions for freezing rain here, as most of Norway is coastal and heavily influenced by the gulf stream, thereby reducing the factors in which it can appear. But we do get wild storms that stir up the sea in a truly wild way. Its much the same feeling I'd assume, if calm it can be the most tranquil place on earth and give a true feeling of serendipity, but given a storm, its so savage and violent that it more resembles Dante's inferno.
Speaking of which, we do have a storm in the north now. It tore down some key power lines, so the three most northern states are without power.
|
|
|
|
|
Last Christmas (after aforesaid ice storm) we were without power for 4 days. We had a small generator that I managed to keep the fridge and freezer going with and we have a wood stove which kept us warm.
This year I installed a 30amp generator with a transfer switch! 
Life is like a s**t sandwich; the more bread you have, the less s**t you eat.
|
|
|
|
|
> How cool is that?
Cool enough for ice to form? Is that a trick question?
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
