Re: C# WPF listbox binding to selected item does not update my property - WPF Discussion Boards

Re: UserControl

Kevin Marois6-Dec-16 4:47

Kevin Marois

6-Dec-16 4:47

You were right. Thanks!

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

C# WPF listbox binding to selected item does not update my property

Member 128805954-Dec-16 5:54

Member 12880595

4-Dec-16 5:54

Hello!
I am trying to make a Contact Book, where i can have my contacts and conversations(+other activities related to them) in C# WPF.I am also trying to learn MVVM with this.

I have 2 listboxes each bound to an observable collection populated from a database using LinqToSQL.
Listbox 1(ContactsLstBx) is displaying a list of contact names, and in Listbox 2(ConversationLstBx), i want to display the conversations i had with the selected contact in Listbox 1.

The problem i have is that(besides being a "noob") the SelectedContact property, does not update after i set it in MainViewModel constructor. If i set it manually it displays the conversation list correctly based on the ContactId.

What i am trying to achieve is: when the program starts, the only listbox loaded is the ContactsLstBxd after i select a contact, to get the SelectedContact, and load the other listbox.
Should i use a SelectionChanged event? Can i load the conversation listbox if i add a call to PopulateConversationList() in my SelectedContact setter?

Any help/advice is greatly apreciated.

Thanks!

C#:

public class MainViewModel : ViewModelBase
    {
        private Contact selectedContact;
 
        public ObservableCollection<Contact> ContactList;
        public ObservableCollection<Conversation> ConversationList;
 
        public MainViewModel()
        {
            ContactList = new ObservableCollection<Contact>(cbdc.Contacts);
            SelectedContact = ContactList.FirstOrDefault();
            PopulateConversationList();


        }

        public Contact SelectedContact
        {
            get { return selectedContact; }
            set
            {
                if (selectedContact == value)
                    return;

                    selectedContact = value;
                    RaisePropertyChanged("SelectedContact");
            }
        }

        public void PopulateConversationList()
        {
            if (selectedContact != null)
            {
                var conversations = from c in cbdc.Conversations
                                    where c.ContactID == SelectedContact.Id
                                    select c;
                ConversationList = new ObservableCollection<Conversation>(conversations);
            }
         }

public class ViewModelBase: INotifyPropertyChanged
{
    public ContactLinqToSQLClassesDataContext cbdc = new ContactLinqToSQLClassesDataContext();


    #region INotifyPropertyChanged

    public event PropertyChangedEventHandler PropertyChanged;
    internal void RaisePropertyChanged(string propertyName)
    {
        if (PropertyChanged != null)
        {
            PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
        }
    }
    #endregion
}

XAML:

XML

<ListBox x:Name="ContactsLstBx" HorizontalAlignment="Left" Height="289" Margin="10,50,0,0" VerticalAlignment="Top" Width="115" ItemsSource="{Binding ContactList}" SelectedItem="{Binding SelectedContact, UpdateSourceTrigger=PropertyChanged}">
            <ListBox.ItemTemplate>
                <DataTemplate>
                    <TextBlock Text="{Binding Path=Name}" />
                </DataTemplate>
            </ListBox.ItemTemplate>
        </ListBox>
        <ListBox x:Name="ConversationLstBx" HorizontalAlignment="Left" Height="134" Margin="333,50,0,0" VerticalAlignment="Top" Width="115" ItemsSource="{Binding ConversationList}" >
            <ListBox.ItemTemplate>
                <DataTemplate>
                    <TextBlock Text="{Binding Path=Title}" />
                </DataTemplate>
            </ListBox.ItemTemplate>
        </ListBox>

Re: C# WPF listbox binding to selected item does not update my property

Richard Deeming5-Dec-16 1:58

Richard Deeming

5-Dec-16 1:58

You're replacing the entire conversation list, so you need to make it a property, and call RaisePropertyChanged when you replace it.

You'll also need to call PopulateConversationList when the selected contact changes.

You can simplify the calls to RaisePropertyChanged by using the CallerMemberName attribute[^] on the parameter. You should also store the event handler delegate in a local variable before testing and calling it, since other threads might modify it between the null test and the invocation.

public event PropertyChangedEventHandler PropertyChanged;

protected void RaisePropertyChanged([CallerMemberName] string propertyName = null)
{
    var handler = PropertyChanged;
    if (handler != null) handler(this, new PropertyChangedEventArgs(propertyName));
}

public class MainViewModel : ViewModelBase
{
    private Contact selectedContact;
    private ObservableCollection<Contact> contactList;
    private ObservableCollection<Conversation> conversationList;
    
    public MainViewModel()
    {
        contactList = new ObservableCollection<Contact>(cbdc.Contacts);
        SelectedContact = contactList.FirstOrDefault();
    }
    
    public ObservableCollection<Contact> ContactList
    {
        get { return contactList; }
    }
    
    public Contact SelectedContact
    {
        get
        {
            return selectedContact;
        }
        set
        {
            if (selectedContact != value)
            {
                selectedContact = value;
                RaisePropertyChanged();
                PopulateConversationList();
            }
        }
    }
    
    public ObservableCollection<Conversation> ConversationList
    {
        get
        {
            return conversationList;
        }
        private set
        {
            if (conversationList != value)
            {
                conversationList = value;
                RaisePropertyChanged();
            }
        }
    }
    
    private void PopulateConversationList()
    {
        if (selectedContact == null)
        {
            ConversationList = null;
        }
        else
        {
            var conversations = from c in cbdc.Conversations
                                where c.ContactID == SelectedContact.Id
                                select c;
            
            ConversationList = new ObservableCollection<Conversation>(conversations);
        }
    }
}

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: C# WPF listbox binding to selected item does not update my property

Member 128805955-Dec-16 9:08

Member 12880595

5-Dec-16 9:08

Thank You!
I have modified my code, but my SelectedContact still doesnt update.
The XAML code for the listbox bindings remains the same as in my first post.
What should i do next?
(sorry if its something obvious that i havent noticed)

public class MainViewModel : ViewModelBase
   {
       private Contact selectedContact;

       private ObservableCollection<Contact> contactList;
       private ObservableCollection<Conversation> conversationList;

       public MainViewModel()
       {
           ContactList = new ObservableCollection<Contact>(cbdc.Contacts);
           SelectedContact = ContactList.FirstOrDefault();
       }

       public ObservableCollection<Contact> ContactList
       {
           get
           {
               return contactList;
           }

           private set
           {
               if (contactList != value)
               {
                   contactList = value;
                   RaisePropertyChanged();
               }
           }
       }

       public ObservableCollection<Conversation> ConversationList
       {
           get
           {
               return conversationList;
           }
           private set
           {
               if (conversationList != value)
               {
                   conversationList = value;
                   RaisePropertyChanged();
               }
           }
       }

public Contact SelectedContact
       {
           get
           {
               return selectedContact;
           }

           set
           {
               if (selectedContact != value)
               {
                   selectedContact = value;
                   RaisePropertyChanged();
                   PopulateConversationList();
               }
           }
       }

       public void PopulateConversationList()
       {
           if (selectedContact == null)
           {
               ConversationList = null;
           }
           else
           {
               var conversations = from c in cbdc.Conversations
                                   where c.ContactID == SelectedContact.Id
                                   select c;
               ConversationList = new ObservableCollection<Conversation>(conversations);
           }

       }

   }

public class ViewModelBase: INotifyPropertyChanged
  {
      public ContactLinqToSQLClassesDataContext cbdc = new ContactLinqToSQLClassesDataContext();


      #region INotifyPropertyChanged

      public event PropertyChangedEventHandler PropertyChanged;
      internal void RaisePropertyChanged([CallerMemberName] string propertyName = null)
      {
          var handler = PropertyChanged;
          if (handler != null)
          {
              handler(this, new PropertyChangedEventArgs(propertyName));
          }
      }
      #endregion
  }

public class ViewModelBase: INotifyPropertyChanged
{
    public ContactLinqToSQLClassesDataContext cbdc = new ContactLinqToSQLClassesDataContext();


    #region INotifyPropertyChanged

    public event PropertyChangedEventHandler PropertyChanged;
    internal void RaisePropertyChanged([CallerMemberName] string propertyName = null)
    {
        var handler = PropertyChanged;
        if (handler != null)
        {
            handler(this, new PropertyChangedEventArgs(propertyName));
        }
    }
    #endregion
}

public partial class MainWindow : Window
{
    public MainWindow()
    {
        InitializeComponent();
        MainViewModel cvm = new MainViewModel();
        ContactsLstBx.ItemsSource = cvm.ContactList;
        ConversationLstBx.ItemsSource = cvm.ConversationList;
    }
}

Re: C# WPF listbox binding to selected item does not update my property

Jon McKee5-Dec-16 10:59

Jon McKee

5-Dec-16 10:59

ItemsSource binds to a collection. There is a default CollectionView generated that is what you are actually seeing. The CollectionView listens for a CollectionChanged event not a PropertyChanged event. Now, you may assume that ObservableCollection handles all this for you, and generally it does. But you are not performing any actions that are monitorable by this class (Add, Move, Remove, Replace, Reset[^]) and instead are completely replacing the instance itself. Try this:

public void PopulateConversationList()
{
   if (selectedContact == null)
   {
       ConversationList = null;
   }
   else
   {
       var conversations = from c in cbdc.Conversations
                           where c.ContactID == SelectedContact.Id
                           select c;
       ConversationList.Clear();
       foreach (Conversation c in conversations)
       {
         ConversationList.Add(c);
       }
   }
}

I highly recommend anyone learning WPF to read the MSDN Data Binding Overview[^] article. If you skip down to "Binding to Collections" you'll see relevant information for both your question and my answer Smile | :)

Haven't had a chance to actually run the code but this definitely seems like the issue since I've run into the same problem before.

Re: C# WPF listbox binding to selected item does not update my property

Member 128805956-Dec-16 7:38

Member 12880595

6-Dec-16 7:38

I have modified the PopulateConversationList() method, and before

ConversationList.Clear();

i have added

if (ConversationList == null)
{
   ConversationList = new ObservableCollection<Conversation>();
}

because i was getting a NullRefferenceException.

The code works as before(SelectedContact doesnt updates).
What else should i check?

public void PopulateConversationList()
        {
            if (selectedContact == null)
            {
                ConversationList = null;
            }
            else
            {
                var conversations = from c in cbdc.Conversations
                                    where c.ContactID == SelectedContact.Id
                                    select c;

                if (ConversationList == null)
                {
                    ConversationList = new ObservableCollection<Conversation>();
                }
                ConversationList.Clear();

                foreach (Conversation c in conversations)
                {
                    ConversationList.Add(c);
                }


            }

Re: C# WPF listbox binding to selected item does not update my property

Jon McKee6-Dec-16 8:23

Jon McKee

6-Dec-16 8:23

The whole point of my post was to remove the re-assignment. Unless you want to implement your own CollectionChanged event to cover the re-assignment, the default CollectionView won't know the collection was modified. I forgot to change the null assignment in your if-statement. Also, you should instantiate in your constructor.

public MainViewModel()
{
    ContactList = new ObservableCollection<Contact>(cbdc.Contacts);
    //Add this
    ConversationList = new ObservableCollection<Conversation>();
    //--------
    SelectedContact = ContactList.FirstOrDefault();
    PopulateConversationList();
}

public void PopulateConversationList()
{
if (selectedContact == null)
{
    //Change ConversationList = null; to this
    ConversationList.Clear();
}
else
{
    var conversations = from c in cbdc.Conversations
                        where c.ContactID == SelectedContact.Id
                        select c;

    ConversationList.Clear();

    foreach (Conversation c in conversations)
    {
        ConversationList.Add(c);
    }
}

If you really want to remake the collection each time you can but you will have to implement INotifyCollectionChanged to cover your re-assignment which is not as friendly as INotifyPropertyChanged. That's a lot of extra mess when you can simply re-use the collection like this.

Re: C# WPF listbox binding to selected item does not update my property

Member 128805956-Dec-16 9:10

Member 12880595

6-Dec-16 9:10

I have modified the code and i get the same results as before.
Sorry, i dont want to remake the collection, but i am a little(maybe a little more) confused.

Should i check something else?

public class MainViewModel : ViewModelBase
{
    private Contact selectedContact;

    private ObservableCollection<Contact> contactList;
    private ObservableCollection<Conversation> conversationList;

    public MainViewModel()
    {
        ContactList = new ObservableCollection<Contact>(cbdc.Contacts);
        ConversationList = new ObservableCollection<Conversation>();
        SelectedContact = ContactList.FirstOrDefault();
        PopulateConversationList();
    }

    public ObservableCollection<Contact> ContactList
    {
        get
        {
            return contactList;
        }

        private set
        {
            if (contactList != value)
            {
                contactList = value;
                RaisePropertyChanged();
            }
        }

    }

    public Contact SelectedContact
    {
        get
        {
            return selectedContact;
        }

        set
        {
            if (selectedContact != value)
            {
                selectedContact = value;
                RaisePropertyChanged();
                PopulateConversationList();
            }
        }
    }

    public ObservableCollection<Conversation> ConversationList
    {
        get
        {
            return conversationList;
        }

        private set
        {
            if (conversationList != value)
            {
                conversationList = value;
                RaisePropertyChanged();
            }
        }
    }

    public void PopulateConversationList()
    {
        if (selectedContact == null)
        {
            ConversationList.Clear();
        }
        else
        {
            var conversations = from c in cbdc.Conversations
                                where c.ContactID == SelectedContact.Id
                                select c;

            ConversationList.Clear();

            foreach (Conversation c in conversations)
            {
                ConversationList.Add(c);
            }
        }
    }
}

Re: C# WPF listbox binding to selected item does not update my property

Jon McKee6-Dec-16 10:30

Jon McKee

6-Dec-16 10:30

So I mocked up a DB and used your code with some optimizations I explain in comments. Works for me. If you're still having an issue it might be a DB issue or some code that isn't posted. Here's the code I used:

MainWindow.xaml: Nothing important changed, just some formatting for my screen

XML

<Window x:Class="ContactsList.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d"
        Title="MainWindow" Height="350" Width="525">
    <DockPanel LastChildFill="True">
        <ListBox x:Name="ContactsLstBx" Width="200" ItemsSource="{Binding ContactList}" SelectedItem="{Binding SelectedContact, UpdateSourceTrigger=PropertyChanged}" DockPanel.Dock="Left">
            <ListBox.ItemTemplate>
                <DataTemplate>
                    <TextBlock Text="{Binding Path=Name}" />
                </DataTemplate>
            </ListBox.ItemTemplate>
        </ListBox>
        <ListBox x:Name="ConversationLstBx" Width="200" ItemsSource="{Binding ConversationList}" DockPanel.Dock="Right" HorizontalAlignment="Right" >
            <ListBox.ItemTemplate>
                <DataTemplate>
                    <TextBlock Text="{Binding Path=Title}" />
                </DataTemplate>
            </ListBox.ItemTemplate>
        </ListBox>
    </DockPanel>
</Window>

MainWindow.xaml.cs

public partial class MainWindow : Window
{
    public MainViewModel ViewModel { get; private set; }

    public MainWindow()
    {
        InitializeComponent();
        ViewModel = new MainViewModel();
        DataContext = ViewModel;
    }
}

MainViewModel.cs

public class MainViewModel : ViewModelBase
{<br />
    //The collections can just be auto-implemented properties since we have no reason
    //to use custom logic like PropertyChanged.  Remember, the view doesn't listen for that.
    public ObservableCollection<Contact> ContactList { get; private set; }
    public ObservableCollection<Conversation> ConversationList { get; private set; }
    private Contact selectedContact;
    public Contact SelectedContact
    {
        get
        {
            return selectedContact;
        }
        set
        {
            if (selectedContact != value)
            {
                selectedContact = value; 
                PopulateConversationList();
                RaisePropertyChanged();
            }
        }
    }
    public MainViewModel()
    {
        ContactList = new ObservableCollection<Contact>(cbdc.Contacts);
        ConversationList = new ObservableCollection<Conversation>();
        SelectedContact = ContactList.FirstOrDefault();
        //Don't need the PopulateConversationList() call because it's already called
        //when setting SelectedContact
    }

    public void PopulateConversationList()
    {
        //Just optimized the if-statement a bit since Clear() is called regardless
        ConversationList.Clear();
        if (selectedContact != null)
        {
            /*
            var conversations = from c in cbdc.Conversations
                                where c.ContactID == SelectedContact.Id
                                select c;
            */
            //My simulated database call, use your call in your application
            var conversations = cbdc.GetConversations(selectedContact);

            foreach (Conversation c in conversations)
                ConversationList.Add(c);
        }
    }
}

ViewModelBase.cs Not really important, just me mocking up DB objects

public class ViewModelBase : INotifyPropertyChanged
{
    protected MockDB cbdc;
    public event PropertyChangedEventHandler PropertyChanged;
    public ViewModelBase()
    {
        cbdc = new MockDB();
    }
    protected void RaisePropertyChanged([CallerMemberName] string propertyName = null) =>
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
}
public class MockDB
{
    private Dictionary<Contact, List<Conversation>> conversations;
    public List<Contact> Contacts { get; private set; }
    public MockDB()
    {
        Contacts = CreateContacts();
        conversations = CreateConversations(Contacts);
    }
    public List<Conversation> GetConversations(Contact c) =>
        conversations[c];
    private List<Contact> CreateContacts()
    {
        return new List<Contact>()
        {
            new Contact("Jim"),
            new Contact("Bob"),
            new Contact("Mary")
        };
    }
    private Dictionary<Contact, List<Conversation>> CreateConversations(List<Contact> contacts)
    {
        Dictionary<Contact, List<Conversation>> conversationMap = new Dictionary<Contact, List<Conversation>>();
        foreach (Contact c in contacts)
            conversationMap.Add(c, CreateConversationList(c));
        return conversationMap;
    }
    private List<Conversation> CreateConversationList(Contact contact)
    {
        return new List<Conversation>()
        {
            new Conversation($"Hi {contact.Name}!"),
            new Conversation("Pleasant day today.")
        };
    }
}

public class Contact
{
    public string Name { get; private set; }

    public Contact(string contactName)
    {
        Name = contactName;
    }
}

public class Conversation
{
    public string Title { get; private set; }

    public Conversation(string conversationText)
    {
        Title = conversationText;
    }
}

Hopefully this helps Smile | :)

Re: C# WPF listbox binding to selected item does not update my property

Member 128805957-Dec-16 8:10

Member 12880595

7-Dec-16 8:10

Thank you very much, it works!
I wasnt setting the datacontext right(i was thinking that the datacontext generated by my LinqToSql classes was the only one i have to interact with).

Thank you again!
Smile | :)

Re: C# WPF listbox binding to selected item does not update my property

Jon McKee5-Dec-16 10:13

Jon McKee

5-Dec-16 10:13

Richard Deeming wrote:
You should also store the event handler delegate in a local variable before testing and calling it, since other threads might modify it between the null test and the invocation.

If C# 6.0 is available in your environment this is no longer necessary with the new null-conditional operator. Just an fyi Smile | :)

public event PropertyChangedEventHandler PropertyChanged;

protected void RaisePropertyChanged([CallerMemberName] string propertyName = null)
{
    PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
}

Re: C# WPF listbox binding to selected item does not update my property

Gerry Schmitz5-Dec-16 5:51

Gerry Schmitz

5-Dec-16 5:51

Consider using a "CollectionView(Source)" to dynamically filter the "conversations list" instead of reloading it each time the contact changes.

(May need to consider performance if there are "too many" conversations).

This link uses a textbox for the filter value; you should be able to use the selected contact. You can set the filter however way you wish; just insure the view is refreshed.

c# - Filter items of a ListBox based on the text of a TextBox using only XAML in WPF - Stack Overflow[^]

Re: C# WPF listbox binding to selected item does not update my property

Member 128805955-Dec-16 9:10

Member 12880595

5-Dec-16 9:10

Thank You!
I will look into this.

TabControl views are not disposed

Leif Simon Goodwin23-Nov-16 4:55

Leif Simon Goodwin

23-Nov-16 4:55

I have a WPF application which consists of a main window containing a TabControl whose items are populated dynamically from the model. This is a simplified version:

<Window x:Class="WpfDemo.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:view="clr-namespace:WpfDemo.View"
        xmlns:viewmodel="clr-namespace:WpfDemo.ViewModel" 
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        Title="MainWindow" Height="350" Width="525" Background="#DCE8F3">
    <Grid>
        <TabControl Grid.Row="0" x:Name="ViewTabControl" ItemsSource="{Binding ViewModels}" SelectedItem="{Binding SelectedTab, Mode=TwoWay}" IsSynchronizedWithCurrentItem="True" Background="LightBlue" Margin="6">
            <TabControl.Resources>
                <DataTemplate DataType="{x:Type viewmodel:ImageCaptureViewModel}">
                    <view:ImageCaptureView />
                </DataTemplate>
                <DataTemplate DataType="{x:Type viewmodel:ProfileDesignerViewModel}">
                    <view:ProfileDesignerView/>
                </DataTemplate>
            </TabControl.Resources>
            <TabControl.ItemTemplate>
                <DataTemplate>
                    <TextBlock Text="{Binding Name}"/>
                </DataTemplate>
            </TabControl.ItemTemplate>
        </TabControl>
    </Grid>
</Window>

The view model class - MainWindowViewModel - has an observable collection called ViewModels:

private ObservableCollection<Object> _viewModels;

        public ObservableCollection<Object> ViewModels
        {
            get
            {
                if (_viewModels == null)
                {
                    _viewModels = new ObservableCollection<Object>();
                }
                return _viewModels;
            }
        }

The views are created thus:

public MainWindowViewModel()
        {
            _profileDesignerViewModel = new ViewModel.ProfileDesignerViewModel();
            ViewModels.Add(_profileDesignerViewModel);
            _imageCaptureViewModel = new ViewModel.ImageCaptureViewModel();
            ViewModels.Add(_imageCaptureViewModel);
        }

So far so good. Unfortunately this has a peculiarity. A view is instantiated each time the user selects the corresponding tab. The problem is that the old view is not disposed until the application shuts down.

Does anyone know how to ensure that the old view is disposed, or how to keep the old view and not create a new one? This is creating a serious memory problem for us.

Re: TabControl views are not disposed

Pete O'Hanlon23-Nov-16 5:30

Pete O'Hanlon

23-Nov-16 5:30

The WPF TabControl is well known for not persisting views. Fortunately, there are many implementations that work around this - Sacha Barber has one such here[^]

This space for rent

Re: TabControl views are not disposed

Leif Simon Goodwin23-Nov-16 21:09

Leif Simon Goodwin

23-Nov-16 21:09

Thanks. I tried that code (from a different web site) some months back for another project and it did not work. However, after reading your post I found the one below which works:

c# - Stop TabControl from recreating its children - Stack Overflow[^]

It is the exact same control class as per your link, but with the addition of a style in the XAML. I cannot as yet see why the syle makes the difference to the behaviour.

Thanks again, very helpful.

Is there any way to automate the silverlight application using Eclipse-testng-selenium-java frameowork

Ashish khanduri20-Nov-16 18:23

Ashish khanduri

20-Nov-16 18:23

I am not familiar with silverlight application, can anyone suggest if there is a way to automate the silverlight application using testng - selenium - java framework.

Re: Is there any way to automate the silverlight application using Eclipse-testng-selenium-java frameowork

Mycroft Holmes20-Nov-16 19:39

Mycroft Holmes

20-Nov-16 19:39

I've not used selenium but there seems to be quite a few who have! Google[^]

Never underestimate the power of human stupidity
RAH

Re: Is there any way to automate the silverlight application using Eclipse-testng-selenium-java frameowork

Ashish khanduri20-Nov-16 19:50

Ashish khanduri

20-Nov-16 19:50

I found some supports like silvernium which are used for selenium, but not for eclipse java. still finding the solution

Sound Command that can intercept the Active Thread

Vimalsoft(Pty) Ltd15-Nov-16 17:56

Vimalsoft(Pty) Ltd

15-Nov-16 17:56

Good Day all

i am working on a Kinect Sensor Program, but i think this question can best be answered by the WPF forum.

In my Kinect Project , the User can use Kinect Gestures or Voice Commands. THe Gestures work nicely its like one is using a mouse. i have a challenge with the Voice Commands which follow a certain Process. Please note that this functionality works well when one is not using voice commands.

Let me make a simple example.

i have a 3 Buttons

Button 1 = "System Ok "

Button 2 = " View Error"

Button 3 = "System Reboot"

Step 1: Now the logic say , if a user enter a wrong command , the System must play a sound for Error and the button for " View Error" must Animate.

Step 2: The Rule goes on and say if the User has not click the " View Error" within 5 seconds , Stop the Animation on the " View Error"

Step 3: and Animate the "System Reboot" and play the Sound for "System Reboot"

Now on a normal button click with a Mouse , this would work. But now i am not clicking the Button Physically, i am using Voice Commands and i have trapped the SpeechRecognized event which is defined like this

private void SpeechRecognized(object sender, SpeechRecognizedEventArgs e)
        {
            // Speech utterance confidence below which we treat speech as if it hadn't been heard
            const double ConfidenceThreshold = 0.3;

            // Number of degrees in a right angle.
            const int DegreesInRightAngle = 90;

            // Number of pixels turtle should move forwards or backwards each time.
            const int DisplacementAmount = 60;

            this.ClearRecognitionHighlights();

            if (e.Result.Confidence >= ConfidenceThreshold)
            {
                switch (e.Result.Semantics.Value.ToString())
                { 

                    case "VIEWERROR":
                        Error_Escaped = true;
                        btnViewError_Click(null, null); 
                        break;
                    case "SYSTEMREBOOT":
                        btnSystemReboot_Click(null, null);
                        break;
                    case "SYSTEMSTATUS":
                        SystemStatus_Click(null, null); 
                        break; 
                }
            }
            else
            {
                // set the status text
                this.Status.Content = Properties.Resources.GrammarConfidenceLow;
                Logger.NormalLog("The Confidence is low , the Grammar is not Recognised as a Command", Generics.Generics.ActivePage) ;
            }
        }

as you can see i am clicking the Buttons programmatically. So if i don't click the "View Error" button within 5 seconds , the System Reboot will start playing another sound.

That was about the Process. Now my challenge is that. After i used a wrong option according to my Process, the "View Error" button will give a sound and i will give a Voice Command to Stop the Sound , the next in the Process will still be fired. So i debugged the code and i realised that the Program , runs all the code that was running and when its done, it hit the "SpeechRecognized" event later, i want to intercept and give the Voice Command the same ability as a button click done with a mouse can do.

This is a function that runs , when there is an Error

private void ViewError()
{

    Error_Escaped = false;
    ResetBlinking(this.btnViewError);
    AnimateButton(this.btnViewError);
     Generics.Generics.WaitNSeconds(5);
     if (Error_Escaped == false)
     {
         SystemReboot();
     }
}

This will set the Flag for "Error_Escape = false " Which means no one has clicked the button. and it will Animate the Button and wait for 5 second which is my custom interval calculator. Now while its waiting i would keep saying some Voice Command to Stop it. it will still continue while i wait , it will jump to System Reboot which will have its sound. i want the

SpeechRecognized(object sender, SpeechRecognizedEventArgs e)

event to fire when i need it not after the other event of buttons are fired.

Tanks

Vuyiswa Maseko

Vuyiswa Maseko,

Spoted in Daniweb-- Sorry to rant. I hate websites. They are just wierd. They don't behave like normal code.

C#/VB.NET/ASP.NET/SQL7/2000/2005/2008
http://www.vimalsoft.com
vuyiswa[at]vimalsoft.com

Re: Sound Command that can intercept the Active Thread

Gerry Schmitz16-Nov-16 6:07

Gerry Schmitz

16-Nov-16 6:07

I would launch a timer from ViewError(); instead of putting it into a wait state.

The speech recognition event can kill the timer if it still running; else the timer sets off whatever needs to be done after time has elapsed.

(A basic "timeout" pattern).

Can't Move Label with mouse in WPF

Dadou5512-Nov-16 22:44

Dadou55

12-Nov-16 22:44

I'm working on a WPF application for my company that can show the routing of cables on picture.
The Goal is to let the user choose a Part Number of a cable and the cable routing will be shown on the picture of the tool.

I will make two kinds of Access Control:

- Guest - that give only Read-Only access
- Admin - that will give the possibility to change the route on the picture (for example: adding new points, adding labels and connections between points) with Admin Panel

My problem is that i can't move the Label with the mouse, it's working with the point (the point is Path) and the Line.

Also i would like to understand why when i'm clicking on the Label it recognizes it like a TextBlock.

Here's my code:

public void Label_Edit_Mode(MouseButtonEventArgs e, Canvas canvas, bool lbledit)
        {
            if (lbledit == true)
            {
                IInputElement clickedElement = Mouse.DirectlyOver;
                if (clickedElement is TextBlock)
                {
                    label = clickedElement as TextBlock;
                    Mouse.Capture(label);
                    captured = true;
                    Vector offset = VisualTreeHelper.GetOffset(label);
                    x_label = offset.X;
                    x_canvas = e.GetPosition(canvas).X;
                    y_label = offset.Y;
                    y_canvas = e.GetPosition(canvas).Y;
                }
            }
        }

            public void Move_Points(MouseEventArgs e, Canvas canvas, bool isclicked)
        {
            if (e.LeftButton != MouseButtonState.Released)
            {
                if (captured == true && isclicked == false)
                {
                    double x = e.GetPosition(canvas).X;
                    double y = e.GetPosition(canvas).Y;
                    {
                        if (path != null)
                        {
                            x_path += x - x_canvas;
                            Canvas.SetLeft(path, x_path);
                            x_canvas = x;
                            y_path += y - y_canvas;
                            Canvas.SetTop(path, y_path);
                            y_canvas = y;
                        }

                        else if (label != null)
                        {
                            x_label += x - x_canvas;
                            Canvas.SetLeft(label, x_label);
                            x_canvas = x;
                            y_label += y - y_canvas;
                            Canvas.SetTop(label, y_label);
                            y_canvas = y;
                        }

                        else if (line != null)
                        {
                            x_line += x - x_canvas;
                            Canvas.SetLeft(line, x_line);
                            x_canvas = x;
                            y_line += y - y_canvas;
                            Canvas.SetTop(line, y_line);
                            y_canvas = y;
                        }
                    }
                }
            }
            else
            {
                captured = false;
            }
        }

here's a picture of how my application looks like:

[My App]

Thank you for your help

Re: Can't Move Label with mouse in WPF

Richard Deeming14-Nov-16 2:13

Richard Deeming

14-Nov-16 2:13

Dadou55 wrote:
Also i would like to understand why when i'm clicking on the Label it recognizes it like a TextBlock.

Look at the remarks on the Mouse.DirectlyOver property:

Mouse.DirectlyOver Property (System.Windows.Input)[^]:

Controls can be composed of multiple elements. DirectlyOver reports the specific element in the composite control the mouse pointer is over and not the control itself. For example, depending on which part of a Button the pointer is over, the DirectlyOver property could report the TextBox of the Content property or the ButtonChrome.

A Label[^] is a ContentControl. When you add text to it, that gets added as a TextBlock. When the mouse is over the text, DirectlyOver returns the TextBlock from the Content part of the Label control.

Basically, you're looking at the visual tree, not the logical tree. You'll need to use VisualTreeHelper.GetParent[^] to walk up the visual tree until you find the control you're looking for.

Trees in WPF[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

How to achieve grouping and ungrouping usercontrol in wpf application programmatically

Pankaj Deharia10-Nov-16 3:05

Pankaj Deharia

10-Nov-16 3:05

I want to group , ungroup canvas user control in wpf application.Though this can be achieved with microsoft visual studio in built function Group and Ungroup which we get from Object and Timeline window.Through ungrouping we are removing unwanted canvas and making only one parent(canvas) to child controls.
Phis i need to achieve programmatically.Please suggest how can I achieve this through programmatically though I want to process my xaml file without doing this manual step and handle it through code behind.

Below mentioned is code snippet of xaml data which is not yet grouped and after that grouping.

Code before ungrouping :

<Canvas Name="_01" RenderTransform="1, 0, 0, 1, 130.919685, -4.32">
          <Canvas Name="_64" RenderTransform="-0.999991, 0.004316, -0.004316, -0.999991, 14.637921, 2145.991988">
            <Path Name="_64_G0__MrkrEnd" Visibility="Collapsed" RenderTransform="3.31258, -1.721798, -1.721798, -3.31258, 5.998991, 1066.51392" StrokeLineJoin="Round" Data="M -1 -1 L 0 0 L 1 -1 ">
            </Path>
          </Canvas>
 </Canvas>
     
 Code after Ungrouping and grouping into a canvas, which allow a single parent node to the child.

 <Canvas Name="_01" RenderTransform="1, 0, 0, 1, 130.919685, -4.32">
        	<Path x:Name="_64_G0__MrkrEnd" Visibility="Collapsed" StrokeLineJoin="Round" Data="M -1 -1 L 0 0 L 1 -1 " Canvas.Left="14.637" RenderTransformOrigin="0.5,0.5" Canvas.Top="2145.992"/>
        </Canvas>

Regards
Pankaj Deharia
Technologies in Mobile World
Online Test conduction Process and Search Jobs

Re: How to achieve grouping and ungrouping usercontrol in wpf application programmatically

Gerry Schmitz10-Nov-16 7:01

Gerry Schmitz

10-Nov-16 7:01

Since WPF is one of your "specialties", you would know that most "container" controls have a "Children" collection; and to "ungroup" and (re)group controls, you remove them from one collection, and add them back to another collection (of a different "parent" control).

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.