|
OK this is what I have now and it seems to be working. A couple of questions/issues:
1. If you look at the commented out code below with the .ToString, I have PickupStoreInfo and then PickupDueDateDetails which is setup similar to the TrackingEventHistory and TrackingEventDetail, so would that be set up the same way with the Cast or should that be setup differently or is it ok like it is now.
rspxml.Root.Add(new XElement("PickupStoreInfo"));
2. You mentioned about using one of either XDocument or XmlDocument, I tried this and when I change to XDocument on this line:
XmlDocument doc = new XmlDocument();
I get errors 'XDocument' does not contain a definition for 'XmlResolver' and no extension method 'XmlResolver' accepting a first argument of type 'XDocument' could be found (are you missing a using directive or an assembly reference?).
Same error definition for FirstChild, LoadXML.
If I change everything to XmlDocument like on this line from XDocument to XmlDocument:
rspxml = XDocument.Parse
I get 'XmlDocument does not contain definition for 'Parse'.
3.Is all of my syntax correct, specifically all of the parentheses after this line:
new XElement("CountryCode", prc.History)
I really appreciate all of your help and look forward to your response.
Here is the full code for this method:
public string ProcessXML(string xmlRequest)
{
XDocument rspxml = null;
try
{
if (bool.Parse(WebConfigurationManager.AppSettings["Debug"]) == true)
File.WriteAllText(Path.Combine(Server.MapPath("Log"), DateTime.Now.ToString("MMddyyy_HHmmss") + ".xml"), xmlRequest);
XmlDocument doc = new XmlDocument();
doc.XmlResolver = null;
doc.LoadXml(xmlRequest);
string method = doc.FirstChild.Name;
XmlNode mainNode = doc.FirstChild;
if (method.ToLower() == "xml")
{
method = doc.FirstChild.NextSibling.Name;
mainNode = doc.FirstChild.NextSibling;
}
if (method == "AmazonTrackingRequest")
{
Saia.Data.General.Shipment prc = new Data.General.Shipment();
string pronum = mainNode.SelectSingleNode("TrackingNumber").InnerText;
prc.GetByProNumber(decimal.Parse(pronum));
if (string.IsNullOrEmpty(pronum))
{
rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion >4.0</APIVersion><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_101</ErrorDetailCode><ErrorDetailCodeDesc>INVALID TRACKING NUMBER</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
}
else
{
decimal tn = 0.0m;
if (decimal.TryParse(pronum, out tn))
{
prc.GetByProNumber(tn);
}
else
{
Console.WriteLine("Unable to parse '{0}'.", pronum);
}
}
rspxml = XDocument.Parse("<AmazonTrackingResponse xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'></AmazonTrackingResponse>");
rspxml.Root.Add(new XElement("APIVersion", "4.0"));
var errorInfo = rspxml.Descendants("TrackingErrorInfo").FirstOrDefault();
if (errorInfo != null)
{
string packtrackinginfo = (string)errorInfo.Element("PackageTrackingInfo");
var detail = errorInfo.Element("TrackingErrorDetail");
if (detail != null)
{
string errorCode = (string)detail.Element("ErrorDetailCode");
string errorMessage = (string)detail.Element("ErrorDetailCodeDesc");
}
}
rspxml.Root.Add(
new XElement("API", "4.0"),
new XElement("PackageTrackingInfo",
new XElement("TrackingNumber", prc.ProNumber)
),
new XElement("PackageDestinationLocation",
new XElement("City", prc.Consignee),
new XElement("StateProvince", prc.Consignee),
new XElement("PostalCode", prc.Consignee),
new XElement("CountryCode", prc.Consignee)
),
new XElement("PackageDeliveryDate",
new XElement("ScheduledDeliveryDate", prc.Consignee),
new XElement("ReScheduledDeliveryDate", prc.Consignee)
),
new XElement("TrackingEventHistory",
prc.History.Cast<Saia.Data.General.Shipment.HistoryItem>().Select(item => new XElement("TrackingEventDetail",
new XElement("EventStatus", prc.History,
new XElement("EventReason", prc.History),
new XElement("EventDateTime", prc.History)
),
new XElement("EventLocation",
new XElement("Street1", prc.History),
new XElement("City", prc.History),
new XElement("StateProvince", prc.History),
new XElement("PostalCode", prc.History),
new XElement("CountryCode", prc.History),
new XElement("SignedForByName", prc.History)
),
new XElement("PickupStoreInfo",
new XElement("PickupDueDateDetails",
new XElement("Date", prc.History),
new XElement("UTCOffset", prc.History)
),
new XElement("PickupID",
new XElement("StoreName",
new XElement("LocationID",
new XElement("StoreLocation",
new XElement("Street1", prc.History),
new XElement("City", prc.History),
new XElement("StateProvince", prc.History),
new XElement("PostalCode", prc.History),
new XElement("CountryCode", prc.History)
)
)
)
)
)
)
)
)
);
}
}
catch (CodeException e)
{
rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion>4.0</APIVersion ><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_203</ErrorDetailCode><ErrorDetailCodeDesc>XML DOCUMENT NOT WELL FORMED</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
Core.Framework.Debug.CodeException(xmlRequest, e);
}
catch (Exception e)
{
rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion>4.0</APIVersion ><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_203</ErrorDetailCode><ErrorDetailCodeDesc>XML DOCUMENT NOT WELL FORMED</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
Core.Framework.Debug.Exception(xmlRequest, e);
}
return rspxml.ToString();
}
|
|
|
|
|
1) It's not clear what you're trying to do here. You're not adding an element for each history item, so you don't need the Select; you just need to pass in the correct values to the elements.
rspxml.Root.Add(new XElement("PickupDueDateDetails"),
new XElement("Date", prc.PickupDueDate),
new XElement("UTCOffset", prc.PickupDueDateOffset)
);
2) You can't just change the type and expect the existing code to work. You need to fix the existing code to use the correct methods for the type.
For example, this:
XmlDocument doc = new XmlDocument();
doc.XmlResolver = null;
doc.LoadXml(xmlRequest); would become:
XDocument doc = XDocument.Parse(xmlResult);
This:
string method = doc.FirstChild.Name;
XmlNode mainNode = doc.FirstChild;
if (method.ToLower() == "xml")
{
method = doc.FirstChild.NextSibling.Name;
mainNode = doc.FirstChild.NextSibling;
} would become:
XElement mainNode = doc.Root;
string method = mainNode.Name.LocalName;
This:
string pronum = mainNode.SelectSingleNode("TrackingNumber").InnerText; would become:
string pronum = (string)mainNode.Element("TrackingNumber");
3) I don't know. Does it compile? Does it do what you expect it to do?
I very much doubt that prc.History is the correct property to use for all of those elements.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
1) This may help explain. This is some of the XML I am trying to write out:
</PackageDeliveryDate>
<TrackingEventHistory>
<TrackingEventDetail>
<EventStatus>LK</EventStatus>
<EventReason>AQ</EventReason>
<EventDateTime>2004-08-22T11:00:00-
08:00</EventDateTime>
<EventLocation>
<City>SEATTLE</City>
<StateProvince>WA</StateProvince>
<PostalCode>98107</PostalCode>
<CountryCode>US</CountryCode>
</EventLocation>
<SignedForByName>JOHN GALT</SignedForByName>
</TrackingEventDetail>
<PickupStoreInfo>
<PickupDueDateDetails>
<Date>2004-08-25</Date>
<UTCOffset>-07:00</UTCOffset>
</PickupDueDateDetails>
<PickupID>92253</PickupID>
<StoreName>US-PRI-DEL-03</StoreName>
<LocationID>19632</LocationId>
<StoreLocation>
<Street1>NW Market St</Street1>
<City>SEATTLE</City>
<StateProvince>WA</StateProvince>
<PostalCode>98107</PostalCode>
<CountryCode>US</CountryCode>
</StoreLocation>
</PickupStoreInfo>
</TrackingEventHistory>
Am I doing a rspxml.Root.Add for each section or can I use like this:
new XElement("PickupStoreInfo",
new XElement("PickupDueDateDetails",
new XElement("Date", prc.History),
new XElement("UTCOffset", prc.History)
),
So based off this, how would that be written out in the code.
2) I updated the code and that seems to be working ok.
3) It does compile. And yes those are supposed to be prc.History. There are only two elements/fields that I'm concerned with and that is the Consignee and History so yes they should be prc.History. I just need to pull in the fields for in those two areas.
|
|
|
|
|
Bootzilla33 wrote:
new XElement("PickupStoreInfo",
new XElement("PickupDueDateDetails",
new XElement("Date", prc.History),
new XElement("UTCOffset"</span>, prc.History)
),
Since PickupDueDateDetails is a child of PickupStoreInfo, that's the correct way to do it.
But passing prc.History as the value for every node isn't going to produce the correct values in the resulting XML. Instead, you'll get the result of calling prc.History.ToString() inserted into every node.
If you don't need to pass a value in the node, it would be better to not pass a value to it, or exclude it from the document.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
I have the same thing for prc.Consignee. So what would you suggest something like this:
),
new XElement("PickupStoreInfo",
new XElement("PickupDueDateDetails",
new XElement("Date"),
new XElement("UTCOffset")
),
I pretty much have to pass a value in the node or else how else would I get the values?
|
|
|
|
|
If you have to pass a value, then pass the value that the API is expecting. Passing the same (invalid) string for each node will most likely cause the API to return an error.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Richard Deeming wrote: If you have to pass a value, then pass the value that the API is expecting.
What would that be?
Something like:
new XElement("PickupStoreInfo",
new XElement("PickupDueDateDetails",
new XElement("Date", Date),
new XElement("UTCOffset", UTCOffset)
),
Not sure???
|
|
|
|
|
Pass in the values that the API is expecting you to pass in for the request.
You've presumably read the API documentation? The expected values should be documented there.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Yes i've read it and if that is the case then the values in the API are the same as the XElement so
Here the a piece of the API schema:
<xsd:element
name="EventStatus" type="xsd:string">
<xsd:annotation>
<xsd:documentation>Event Status</xsd:documentation>
</xsd:annotation>
</xsd:element>
I guess it will look like this?
new XElement("EventStatus", "Event Status"),
),
modified 21-Sep-17 13:50pm.
|
|
|
|
|
Bootzilla33 wrote:
Here the a piece of the API schema:
<xsd:element
name="EventStatus" type="xsd:string">
<xsd:annotation>
<xsd:documentation>Event Status</xsd:documentation>
</xsd:annotation>
</xsd:element>
I guess it will look like this?
new XElement("EventStatus", "Event Status"),
),
Just need help with this and I think I'm done.
|
|
|
|
|
Someone please help me with this. I would greatly appreciate it.
Thanks
|
|
|
|
|
The old adage Exceptions should be Exceptional applies here. Rather than using multiple try ... catch blocks, my advice is to validate your known inputs up front. While I personally find it ugly to use a series of If (!x) { return; } it is a solid method of keeping your code simple and implicit. I am not sure what the bold issue is because you are using static values so I don't know what you would catch there. Starting at the third element, though, I would advocate writing a validator of some sort to validate the Shipment object.
And to possibly save you some grief, might I suggest cutting out some of the craziness and just using a serializer to serialize the shipment object? IT can save you a TON of grief trying to validate the XML> If you can't serialize the Shipment directly because of schema differences, try creating a DTO that matches the XML you want and serializing that.
Working with raw XML like this should be a last resort.
That is my 2c
|
|
|
|
|
@eddieangel,
how would you code what I'm trying to do with API Version, Tracking Number using If (!x) {return}?
|
|
|
|
|
I am not sure what the validation looks like for your situation, but there are a couple of methods.
The most simple is to validate to see if the string exists.
if (string.isNullOrEmpty(apiVariableName)) { return ; }
Since the first two bold items are static text there really isn't anything to validate there unless there is something else we aren't seeing. That said, one of the best methods to validate your data is to set validation attributes on your model class (Data.General.Shipment() and write a method that validates that. For example:
internal class Shipment {
[Required]
[StringLength(12)]
public string ShippingNumber { get; set; }
[Required(ErrorMessage = "City cannot be empty.")]
public string City { get; set; }
[Required(ErrorMessage = "Zip is Required")]
[RegularExpression(@"^\d{5}(-\d{4})?$", ErrorMessage = "Invalid Zip")]
public string PostalCode { get; set; }
}
The trick here is that you really want to leave your model validating to the model or validator class and not be trying to validate when you are building the XML. It is good defensive programming to cover null possibilities and such, but you really want to uncomplicate things as much as possible if you are crafting an XML by hand.
|
|
|
|
|
So where would the model class go in relation to my code. Would it be outside of the XElement code? Before it? After it?
|
|
|
|
|
To put an easy stamp on your original question, you can have many try catch blocks but it is going to be a very iterative process for you to figure them out and consider all of the permutations. So you have to ask yourself what the goal is. Is there a recovery path through these exceptions or are you trying to send different error messages to the user? Or maybe just log more detail?
Either way if your try/catch is at the point of building out the XML all you are likely to get is XML formatting exceptions, which do not encapsulate your business rules. A couple notes on generally being defensive in the code you have written:
1. Do not use decimal.Parse. Since you are using the null check operator getting the tracking number, you expose the possibility of errors there. Try this:
var prc = new Data.General.Shipment();
var node = mainNode.SelectSingleNode("TrackingNumber");
if (node == null)
{
return;
}
decimal trackingNumber;
if (!decimal.TryParse(node.InnertText, out trackingNumber))
{
return;
}
prc.GetByProNumber(trackingNumber);
try
{
rspxml.Root.Add(new XElement("API", "4.0"));
rspxml.Root.Add(new XElement("PackageTrackingInfo"));
rspxml.Root.Element("PackageTrackingInfo").Add(new XElement("TrackingNumber", prc.ProNumber.ToString()));
rspxml.Root.Add(new XElement("PackageDestinationLocation"));
rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("City", prc.Consignee.ToString()));
rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("StateProvince", prc.Consignee.ToString()));
rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("PostalCode", prc.Consignee.ToString()));
rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("CountryCode", prc.Consignee.ToString()));
}
catch (NullReferenceException n)
{
}
At very least, make sure you validate that the tracking number comes up and hydrates an object.
|
|
|
|
|
I am using XML because I'm outputting it to AWS. So I don't have a choice unfortunately.
|
|
|
|
|
Hi,
I make my question after some research in web without any clear response to my problem.
I have the following XML and I need to apply an XSL transformation to get only nodes which haven't child.
Input :
<Root_Element Att_Name="XXX">
<right Id="100">
<right Id="110" />
<right Id="111">
<right Id="112" />
<right Id="113">
<right Id="114" />
<right Id="115" />
</right>
<right Id="116" />
</right>
<right Id="117">
<right Id="118" />
<right Id="119">
<right Id="120" />
<right Id="121" />
</right>
</right>
</right>
</Root_Element>
Expected output :
<Root_Element Att_Name="XXX">
<right Id="110" />
<right Id="112" />
<right Id="114" />
<right Id="115" />
<right Id="116" />
<right Id="118" />
<right Id="120" />
<right Id="121" />
</Root_Element>
|
|
|
|
|
What does this have to do with C#? BTW, when you post a question, it helps if you show us what you've already tried. That way, we won't duplicate things you've already ruled out.
This space for rent
|
|
|
|
|
sorry for the misunderstood , i will move it
|
|
|
|
|
hi
i need Visual Studio .NET 2002 prerequisites cd
or all Visual Studio .NET 2002
Because I have a program using Crystal Reports 9.1.3300.0
I have searched everywhere on the internet and I can not find this version, can you help me?
p.s
i cant use another version for Visual Studio the program i use refuses
|
|
|
|
|
We can't really help you here: VS2002 is fifteen years old, and did not come in an Express edition - so it's a paid-for product and any download version would be pirated.
So you are going to have to scratch around on the internet and see if you can find a copy for sale - good luck with that - we can;t do that for you.
But ... that's probably not going to be your worst problem! VS2002 was a 32bit product that will apparently not install on 64 bit systems at all - so you are probably going to need a 32bit version of XP running to actually install and use it ...
Me? I'd look at the program source, or the person you got it from, and see if you can get an updated version that is a bit more modern...
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Message Closed
modified 20-Sep-17 3:58am.
|
|
|
|
|
No.
One of them doesn't compile.
SqlTransaction does not expose public constructors: you create a transaction via the SqlConnection object.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
sir please explain i am confusing between begintransaction and sqltransaction objcet.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
