|
Kayembi wrote:
However, using these instructions means that anyone using my program can open the INI file in a text editor and look at the stored information.
Is this a bad thing? If the settings are related to your application, what's the harm?
Ideally, Win32 programs use the registry instead of text-based INI files. It's no more secure, at least not to any experienced person, but it does give your application more flexibility.
|
|
|
|
|
Thanks for the replies.
I can live with INI files - it's not really a bad thing - but I just think it would be a little more "professional" if people can't look in the file. Also, I may need to store a password in there, in which case (although I could encrypt it in an INI file), a non-readable file would be better.
Thanks again for the replies, I'm looking into all the suggestions on the MSDN site and trying to work it all out... It's still a bit complex for me as I'm still learning, but I'm trying...
Cheers,
KB
|
|
|
|
|
Kayembi wrote:
but I just think it would be a little more "professional" if people can't look in the file.
Sometimes editing a file outside the app is the only way to get it to work.
Kayembi wrote:
Also, I may need to store a password in there...
A very bad design.
|
|
|
|
|
"A Very bad design" - you're right; I think I have eliminated the need for a password to be stored in the file, fortunately.
Maybe you're right about leaving the files as INI files... The main reason I want to do it is that there is information in there that, if changed, will definitely cause the program to crash, or at least behave oddly. This is probably bad design again... Essentially I am writing a launcher app and a wizard. Through the wizard, users can choose different styles and settings for the launcher app. It then copies the launcher app, with the files it is launching, and the settings file (which is the file I am trying to save/load, currently an INI) to a new directory. Thus all of the settings they chose through the wizard (JPG to display while launching, titlebar name etc) are all saved in the INI file, and the launcher reads that in order to find the files it need to launch and to find the picture files it needs to display, etc.
In an ideal world there would be no need for an INI or saved file at all - all the information would be stored inside a newly generated launcher executable, along with the JPG files that have been selected for use by the launcher. This would be tidier and more professional, but as I have no idea where to begin in trying something like that, I have to instead go the route of external files and an INI (or save file of another format).
Many thanks for all your help, I really appreciate it,
KB
|
|
|
|
|
Kayembi wrote:
The main reason I want to do it is that there is information in there that, if changed, will definitely cause the program to crash, or at least behave oddly. This is probably bad design again...
A well-behaved app would indeed not crash, but should instead detect when "bad data" is present and respond accordingly. For example, if you were storing the window coordinates of the app when it was last shut down (t=0, r=1024, b=768, l=0) so that it could be positioned in the same spot next time, and someone changed those coordinates to something non-sense (t=768, r=1024, b=0, l=0), the app would know to correct the problem, or use some default values at the very least.
|
|
|
|
|
Thanks. I guess I need to add lots of error-handling code to sort this out. I ought to get into good habits now, so thanks for the advice.
Cheers,
KB
|
|
|
|
|
Hi,
I'm trying to use a timer call back function but I can't get it to compile.
I set up the timer for a 1 second interval like this:-
m_uSampleTimerID = SetTimer( 1,1000,TimerTakeSample );
My function is declared like this:-
void CALLBACK EXPORT COxygraphView::TimerTakeSample(HWND hWnd, UINT nMsg, UINT nTimerID, DWORD dwTime)
BUT the SetTime command gives the following error:-
:\Oxygraph\OxygraphView.cpp(575) : error C2664: 'SetTimer' : cannot convert parameter 3 from 'void (struct HWND__ *,unsigned int,unsigned int,unsigned long)' to 'void (__stdcall *)(struct HWND__ *,unsigned int,unsigned int,unsigned l
ong)'
This is all in the View part of an MFC app. It doesn't seem to like the return type of the function.
Any ideas what's wrong with it?
Thanks
Ali
|
|
|
|
|
Hey can i suggest u one thing..
Check out if u like this thing
instead of calling a call back function
just go to class wizard map the WM_TIMER for the view class
then call the set timer function with parameters(1000, timeasperuwant, NULL)
in this case the Functiopn mapped for WM_TIMER will be called..
please check out and let me know
bye
Thanx
TAKE CARE
|
|
|
|
|
this thing will work if u calling the set timer function in the view class itself..
Thanx
TAKE CARE
|
|
|
|
|
Thanks for the suggestion. In fact I have got my code working like that at the moment, but I have several timers and I wanted to assign each one its own handling function.
Thanks anyway 
Ali
|
|
|
|
|
The problem is with the declaration of your TimerTakeSample function. I think its probably got something to do with that EXPORT (try removing it?) because the CALLBACK simply defines the function type as an _stdcall* and so that should compile.
|
|
|
|
|
Thanks for the suggestion, I've tried it but the compiler still doesn't want to know (still the same error message).
Thanks anyway
Ali
|
|
|
|
|
The actual problem is that the compiler is expecting a void (_stdcall*) (arglist...)function and your function has somehow been defined as a mere void (arglist...) function hence the error. Since the CALLBACK statement defines the (_stdcall*) you should not be having this issue, unless the EXPORT statement is doing something dopy (so try removing it), or the TimerTakeSample referred to in the SetTimer function is being linked to a different function? try specifying COxygraphView::TimerTakeSample(blah...) in your SetTimer function to make sure your linkage is correct (can't tell from your example where the SetTimer is being called from). I'm sure the answer will reveal itself
|
|
|
|
|
The function must be declared as static
Hope this helps,
Ryan "Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"
|
|
|
|
|
Haha, yes the declaration should be static void CALLBACK etc. well done ryan
|
|
|
|
|
To expand on Ryan's post - it's all to do with pointers to member functions. Take a look at this[^] site - it will explain all!
Phil
|
|
|
|
|
Thanks, the link looks really helpful, looks like I need to do some reading!
Ali
|
|
|
|
|
You're right changing the funstionto static gets rid of the compiler error. However, now I have more errors calling functions from the timer function. Looks like I need to read up on static functions!
Thanks for the help, much appreciated
Ali
|
|
|
|
|
You're welcome
Alison Pentland wrote:
However, now I have more errors calling functions from the timer function. Looks like I need to read up on static functions!
Good idea  Your errors at the moment are probably because you're calling non-static members from your static function. You can't do that . The general way of using static functions as callbacks is to pass a pointer to the object as the lParam value that gets passed to the callback function, and then using that pointer to access the other class members.
Ryan "Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"
|
|
|
|
|
Declaring a member function of class as static will remove the need for an instance of the class to be associated with it - i.e. no this pointer. What this means is that it can't access any of the normal member functions/variables - precisely because there is no associated this pointer. However, supply the static function with a pointer to an instance of the class and you can access all functions/variables (even private ones) via that pointer - because the static function is still declared in the scope of the class.
In terms of pointers to functions, because a static member function has no associated this pointer you can obtain it's address directly (just like a C function) - this is why Ryan's suggestion worked. Any normal member function must have an associated this pointer with it, so even when you take the address of a member function you must still use it with a pointer to an instance of the class as well.
class CMyClass<br />
{<br />
public:<br />
void MyFn (void);<br />
static void MyStaticFn (CMyClass *);<br />
};<br />
<br />
typedef void(* FnPtr)(CMyClass*);
typedef void(CMyClass::* MemberFnPtr)();
<br />
CMyClass* pMyClass = new CMyClass;<br />
<br />
MemberFnPtr pMFn = &CMyClass::MyFn;<br />
pMyClass->MyFn();
pMyClass->*pMFn();
<br />
FnPtr pFn = &CMyClass::MyStaticFn;<br />
(*pFn)( pMyClass );
[edit]
You could try using the nIDEvent parameter of SetTimer to hold the pointer to your class instance - cast it back to the correct type and use within your static fn.
[/edit]
Hope this helps,
Phil
|
|
|
|
|
Hi Alison,
I am not sure that "static" is right method. See following:
The citation:
-The lpfnTimer callback function need not be named TimerProc, but it must be defined as follows:
-void CALLBACK EXPORT TimerProc(
- HWND hWnd, // handle of CWnd that called SetTimer
- UINT nMsg, // WM_TIMER
- UINT nIDEvent // timer identification
- DWORD dwTime // system time
-);
So, TimerProc should be a function insted class method.
|
|
|
|
|
Talik wrote:
So, TimerProc should be a function insted class method.
There is nothing wrong with using a static member. The compiler treats functions and static members in exactly the same way.
Ryan "Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"
|
|
|
|
|
Hi everyone,
Having a nightmare problem - hoping someone can help!
When I catch OnDropdown for a combo box and try programmatically selecting an item different than the current selection the control reselects a different item!
I have a list box, let's say it's got these items:
_________________
| Paul Maddox
| Paul Mdx
| Paul
|_________________
If "Paul Mdx" was selected last time, when I open the dropdown I want it to select "Paul".
So, I've hooked the OnDropdownMyCombo function and done:
m_combo.SetCurSel(m_combo.FindExactMatch(-1,"Paul"));
After the selection I do GetCurSel and GetLBText to double-check the correct selection is made, which it is.
However, the control will show "Paul Maddox" as being selected in the dropped down list, BUT "Paul" shown in the edit box.
If anyone has come across this or has any suggestions, I'm more than open to hear them!
Many thanks,
Paul.
|
|
|
|
|
The framework sets the new selection after OnDropdownMyCombo is called, so your code has no effect. Your code would work if you put it in the ON_CBN_SELCHANGE handler.
HPS HwndSpy - GUI developer's aid to visually
locate and inspect windows. For the month of August
only, use coupon code CP-81239 for 30% off.
|
|
|
|
|
Hi all
I create a file by using CStdioFile.
I want to sent this file to Printer, which function should i use?
Thanks
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
