Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')

Question

1.00/5 (1 vote)

See more:

SQL-Server-2012

Hello Team,
please provide some solution for this SQL injection flaw in veracode and find below code.

source code:

flaws @ both com.ExecuteNonQuery();

C#

string sql = "";
int length = 30;

adr = adr.Trim();
									
if(adr.Length<length)>
adr = adr.Substring(0,length);

cl.DTime = DateTime.Now.ToString("dd.MM.yy");

sql += "INSERT INTO Report (Datum,VG_UG,NameVN,VstNr,ArtPr,Sti,Prov,ArtEnt) ";
sql += "VALUES ( ";
sql += "'" + cl.DTime + "'," + "'" + vg + "'," + "'" + adr + "'," + cl.VSTNr 
+ ",'Risiko'," + "'" + sti
+ "'," + pRisik.ToString().Replace(",",".") + ",'Bestan');";  
com.CommandText =  sql;
com.ExecuteNonQuery();///flaw at this line

sql = "INSERT INTO Report (Datum,VG_UG,NameVN,VstNr,ArtPr,Sti,Prov,ArtEnt)";
sql += "VALUES ( ";
sql += "'" + cl.DTime + "'," + "'" + vg + "'," + "'" + adr + "'," + cl.VSTNr
+ ",'Sparpr'," + "'" + sti
+ "'," + pSparp.ToString().Replace(",",".") + ",'Bestan');";  					
com.CommandText =  sql;
com.ExecuteNonQuery();

sql = "INSERT INTO Report (VG_UG) VALUES ('')";
com.CommandText = sql;
com.ExecuteNonQuery();/// flaw at this line

Posted 15-Jul-15 1:55am

priyanka arava

Updated 15-Jul-15 2:03am

Wendelius

v4

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Answer 1 · 2015-07-15T02:00:00

Solution 1

The problem is that you're concatenating data directly to the SQL statement. The correct way is to use SqlParameter[^]

So for all values use parameters and define the values for them.

Posted 15-Jul-15 2:00am

Wendelius

Thava Rajan · Answer 2 · 2015-07-15T02:05:00

Solution 2

may be this link will help you
How To: Protect From SQL Injection in ASP.NET[^]

Posted 15-Jul-15 2:05am

Thava Rajan

Sergey Alexandrovich Kryukov · Answer 3 · 2015-07-15T02:11:00

Your approach is wrong from the very beginning. The query composed by concatenation with strings taken from UI. Not only repeated string concatenation is inefficient (because strings are immutable; do I have to explain why it makes repeated concatenation bad?), but the possibility of SQL injection is way more important issue here.

This is how it works: http://xkcd.com/327.

Are you getting the idea? The string taken from a control can be anything, including… a fragment of SQL code.

What to do? Just read about this problem and the main remedy: parametrized statements: http://en.wikipedia.org/wiki/SQL_injection.

With ADO.NET, use this: http://msdn.microsoft.com/en-us/library/ff648339.aspx.

Please see my past answers for some more detail:
EROR IN UPATE in com.ExecuteNonQuery();,
hi name is not displaying in name?.

—SA