How to search data from database in vb.net

Question

0.00/5 (No votes)

See more:

Sir,
I have table name Attn in sql server with columns Emp_Id Emp_Name and Modify.
Modify have data like(Admin 30/08/2015). Now i want to search data from this table as
if Emp_Id=Idtxt.Text and Modify= TxtDate.text(here i want to pick only date not name Admin).
How can i do this...........
My original code below is:----------

VB

Sub LoadData_ID_Date()
        Dim cn As New SqlConnection(cnSettings2())
        cn.Open()
        da2 = New SqlDataAdapter("SELECT SqNo,Emp_Id,Emp_Name,Desig,Present,Modify,Verify_By from Attn where Emp_Id='" & TxtID.Text & "' and Modify = '" & Txt_Date.Text & "'", cn)
        dt2 = New DataTable
        da2.Fill(dt2)
        sBuilder2 = New SqlCommandBuilder(da2)
        dgv.Columns("SlNo").DataPropertyName = "SqNo"
        dgv.Columns("id").DataPropertyName = "Emp_Id"
        dgv.Columns("Nm").DataPropertyName = "Emp_Name"
        dgv.Columns("Desig").DataPropertyName = "Desig"
        dgv.Columns("Prsnt").DataPropertyName = "Present"
        dgv.Columns("Modi").DataPropertyName = "Modify"
        dgv.Columns("VerifyBy").DataPropertyName = "Verify_By"
        dgv.RowsDefaultCellStyle.BackColor = Color.White
        dgv.AlternatingRowsDefaultCellStyle.BackColor = Color.AliceBlue
        dgv.AllowUserToAddRows = True
        dgv.Columns(0).Visible = False
        dgv.Columns(1).ReadOnly = True
        dgv.Columns(2).ReadOnly = True
        dgv.Columns(3).ReadOnly = True
        dgv.Columns(4).ReadOnly = False
        dgv.Columns(5).ReadOnly = False
        dgv.Columns(6).ReadOnly = True
        'list_items.Columns(0).DataPropertyName = "item_id"
        dgv.DataSource = dt2
        cn.Close()
        TxtID.Enabled = False
        Txt_Date.Enabled = False
        Txt_Vby.Focus()
    End Sub

Posted 30-Aug-15 17:27pm

hspl

Updated 30-Aug-15 17:30pm

Wendelius

v2

Add a Solution

2 solutions

Solution 2

In addition to solution 1 by Mika Wendelius[^], i would say that:
1) you can use Linq[^] to filter dataset/datatable object,
2) your code is SQL Injection[^] vulnerable.

Ad 1)
LINQ to DataSet Examples[^]
Filtering with DataView (LINQ to DataSet)[^]

Ad 2)
How To: Protect From SQL Injection in ASP.NET[^]
How To: Protect From Injection Attacks in ASP.NET[^]
Do Stored Procedures Protect Against SQL Injection?[^]
SQL Injection and how to avoid it[^]
Dynamic SQL & SQL injection[^]

Posted 30-Aug-15 20:48pm

Maciej Los

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2015-08-30T17:34:00

If I undestand your question correctly, you need to change the condition. If you search by name the include only

SQL

WHERE Emp_Id=@empid

in the WHERE clause and if you search by date then

SQL

WHERE Modify = @modifydate

The example code is different from what you have used since you should never concatenate values directly to the SQL statement. This leaves you for example open to SQL injections.

For more discussion, have a look at Properly executing database operations[^]