No value given one or more parameters(vb.net)

Question

0.00/5 (No votes)

See more:

What is the problem with my code i tried many code for this kind of error but apparently nothing's change . all i want is when i click normal(radiobutton) and select A(combobox) then in RoomNo(combobox) it will display all RoomNo that roomtype = "normal" and building = "A" .

here's all the code i tried :

VB

Try
         cn.Open()

         If rdbNormal.Checked = True Then
             Dim selectquery As String

             selectquery = " SELECT * from RoomTable Where Building='" & cmbBuilding.Text & "' and RoomType = Normal"

             Dim selectcommand As New OleDbCommand
             With selectcommand
                 .CommandText = selectquery
                 .Connection = cn
                 .ExecuteNonQuery()
             End With
             cn.Close()
         End If
     Catch ex As Exception
         MsgBox(ex.Message)
     End Try

my 2nd code :

VB

Try
           cn.Open()
           If rdbNormal.Checked = True Then
               Dim DataSet As New DataSet
               Dim DataTable As New DataTable
               Dim DataAdapter As New OleDbDataAdapter("SELECT * FROM RoomTable Where Building = '" & cmbBuilding.Text & "' And RoomType = Normal ", cn)
               DataAdapter.Fill(DataTable)

               If DataTable.Rows.Count > 0 Then
                   With cmbRoomNo
                       .Items.Clear()
                       For i As Integer = 0 To DataTable.Rows.Count - 1
                           .Items.Add(DataTable.Rows(i).Item(3))
                       Next
                       .SelectedIndex = -1
                   End With
               End If
               DataTable.Dispose()
               DataAdapter.Dispose()
           End If
       Catch ex As Exception
           MsgBox(ex.Message)
       End Try
       cn.Close()

Posted 25-Sep-15 1:27am

Member 12011194

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2015-09-25T02:38:00

Solution 1

Firstly please do not use string concatenation in SQL statements, it exposes your database to SQL injection, as described at http://bobby-tables.com/about.html[^]. Use proper parameterised queries.
Secondly, a few seconds with your debugger would have shown you what value cmbBuilding.Text is returning.

Posted 25-Sep-15 2:38am

Richard MacCutchan

Comments

Member 12011194 25-Sep-15 9:04am

Hi sir Richard,

why i get error like "No value given one or more required parameters" is there's any wrong with my code ?

Richard MacCutchan 25-Sep-15 9:29am

Why not try what I suggested and find out? You will be amazed how much you can learn by trying things, and getting skilled at debugging your code.

Member 12011194 25-Sep-15 9:33am

my 1st code or my 2nd code ?

Member 12011194 25-Sep-15 9:35am

can you give me where part should i debug my code ? need idea so that i can recode my code .

Member 12011194 25-Sep-15 10:15am

Hi sir Richard,

i do what you said but apparently it's not working .

<pre lang="vb"> Try
If rdbNormal.Checked = True Then
Dim str As String = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\Users\Sherlyn\Desktop\Pernz&She5(No update)\Hospital Management System\Hospital Management System\HospitalDB.accdb"
cn = New OleDbConnection(str)
cn.Open()

Dim Selectqry As String
Selectqry = "SELECT * FROM RoomTable WHERE" & " Building = @Building AND RoomType = @RoomType "

Dim Selectcmd As New OleDbCommand
With Selectcmd
.CommandText = Selectqry
.Connection = cn
.Parameters.AddWithValue("@Building", cmbBuilding.Text)
.Parameters.AddWithValue("@RoomType", txtRT.Text)
.ExecuteNonQuery()

End With
cn.Close()
End If
Catch ex As Exception
MsgBox(ex.Message)
End Try
</pre>

Richard MacCutchan 25-Sep-15 10:55am

What are the values of the parameters when you create the Select statement?