File.Copy do not copy all the folder and directories

Question

0.00/5 (No votes)

See more:

Hi guys,i called file.copy to copy file and folder from source to destination. When i run it without debugger the File.copy did not copy everything to destination. When I debug the program with debugger the code works like a charm, anyone have any idea why the file.copy do not copy everything without debugger? Below is the code:

C#

public bool CopyFileAndFolder(string sourceFolder, string replacePath)
{
    bool result = false;
    try
    {
        foreach (string extractPath in Directory.GetDirectories(sourceFolder, "*", SearchOption.AllDirectories))
        {
            string destFolder = extractPath.Replace(sourceFolder, replacePath);
            if (!Directory.Exists(destFolder))
                Directory.CreateDirectory(destFolder);
        }

        foreach (string extractFile in Directory.GetFiles(sourceFolder, "*.*", SearchOption.AllDirectories))
        {
            string destFile = extractFile.Replace(sourceFolder, replacePath);
            File.Copy(extractFile, destFile, true);
        }
        result = true;

    }
    catch (Exception ex)
    {
        result = false;
        Trace.WriteLine(ex.Message);
    }
    return result;
}

Posted 16-Nov-15 16:21pm

Soon Ee

Updated 16-Nov-15 16:32pm

George Jonsson

v2

Add a Solution

Comments

Garth J Lancaster 16-Nov-15 22:38pm

I'd check for two things
a) that you're getting properly formed filenames when you form 'destFile'
b) that you're not running into permissions errors - are you running VS under admin ? - try running the exe as Admin outside of VS and see if you get the same result

Soon Ee 16-Nov-15 22:52pm

yeah i have method to check for the file path format and permission

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Jonsson · Answer 1 · 2015-11-16T16:40:00

You could try to change the code like this

C#

public bool CopyFileAndFolder(string sourceFolder, string replacePath)
{
    bool result = false;
    try
    {
        foreach (string extractPath in Directory.GetDirectories(sourceFolder, "*", SearchOption.AllDirectories))
        {
            string destFolder = extractPath.Replace(sourceFolder, replacePath);
            if (!Directory.Exists(destFolder))
                Directory.CreateDirectory(destFolder);

            foreach (string extractFile in Directory.GetFiles(sourceFolder, "*.*", SearchOption.AllDirectories))
            {
                string destFile = Path.Combine(destFolder, Path.GetFileName(extractFile));
                File.Copy(extractFile, destFile, true);
            }      
        }
 
        result = true;
 
    }
    catch (Exception ex)
    {
        result = false;
        Trace.WriteLine(ex.Message);
    }
    return result;
}

That is, move the file copy loop into the directory search loop and change the destination path a bit.

[UPDATE]
I found it easier to make this method recursive instead. As far as I can tell it works for me.

C#

// Recursive version
public bool CopyFileAndFolder(string sourceFolder, string backupPath)
{
    bool retVal = false;
    try
    {
        // First create the new backup directory
        if (!Directory.Exists(backupPath))
            Directory.CreateDirectory(backupPath);


        // Then copy all the files in this directory
        foreach (string fileName in Directory.GetFiles(sourceFolder, "*.*", SearchOption.TopDirectoryOnly))
        {
            string destFile = Path.Combine(backupPath, Path.GetFileName(fileName));
            File.Copy(fileName, destFile, true);
        }

        // Get the sub-diretories
        string[] directories = Directory.GetDirectories(sourceFolder, "*", SearchOption.TopDirectoryOnly);
        // This check is just to make the recursion break point more clear
        if (directories.Length == 0)
            return true;

        foreach (string directory in directories)
        {
            string destFolder = Path.Combine(backupPath, Path.GetFileName(directory));
            retVal = CopyFileAndFolder(directory, destFolder);
            if (!retVal)
                break;
        }
    }
    catch (Exception ex)
    {
        retVal = false;
        Trace.WriteLine(ex.Message);
    }
    return retVal;
}