Parameter is not valid.

Question

1.00/5 (1 vote)

See more:

this code i had written:

C#

private Bitmap CreateBarcode(string s)
       {
           Bitmap barcode = new Bitmap(1, 1);
           Font font = new Font("Free Font", 60, FontStyle.Regular, GraphicsUnit.Point);

           Graphics graphic = Graphics.FromImage(barcode);

           SizeF size = graphic.MeasureString(s, font);

     barcode = new Bitmap(barcode,size.ToSize());// here is error/ here is error;      

           graphic = Graphics.FromImage(barcode);
           graphic.Clear(Color.White);

           graphic.TextRenderingHint = TextRenderingHint.SingleBitPerPixel;
           graphic.DrawString(s, font, new SolidBrush(Color.Black), 0, 0);
           graphic.Flush();
           font.Dispose();
           graphic.Dispose();

           return barcode;

       }

What I have tried:

i had change the size parameter but it does not work

Posted 29-Feb-16 1:47am

kp564

Updated 29-Feb-16 21:51pm

Add a Solution

3 solutions

Solution 1

I pasted your code into my app, and the only way I could get teh error you do is you pass it an empty string:

C#

Bitmap b = CreateBarcode("");

Which would give you a size of (0,0) and that would cause the error.

So check your method argument for null, all whitespace, or empty - and return a blank bitmap.

Posted 29-Feb-16 2:14am

OriginalGriff

Solution 2

OriginalGriff was a bit faster than me.. but I have a suggestion on how to otherwise improve your code: Instead of explicitly disposing objects, use using-blocks. It will ensure that your object is being disposed "no matter what" when leaving the scope and it improves readibility (well, most people think so at least). Also, by re-assigning a second Graphics-object to your variable graphics you're not disposing the first one.

C#

private Bitmap CreateBarcode(string text)
{
    if (String.IsNullOrEmpty(text))
        throw new ArgumentException(nameof(text) + " may not be null or empty.");

    Bitmap barcode;

    using (Font font = new Font("Free Font", 60, FontStyle.Regular, GraphicsUnit.Point))
    {
        using (Bitmap dummyBitmap = new Bitmap(1, 1))
        using (Graphics graphic = Graphics.FromImage(dummyBitmap))
        {
            SizeF size = graphic.MeasureString(text, font);
            barcode = new Bitmap(dummyBitmap, size.ToSize());
        }

        using (Graphics graphic = Graphics.FromImage(barcode))
        {
            graphic.Clear(Color.White);
            graphic.TextRenderingHint = TextRenderingHint.SingleBitPerPixel;
            graphic.DrawString(text, font, new SolidBrush(Color.Black), 0, 0);
            graphic.Flush();
        }
    }

    return barcode;
}

Posted 29-Feb-16 2:29am

Sascha Lefèvre

Updated 29-Feb-16 2:30am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

kp564 · Accepted Answer · 2016-02-29T21:51:00

Solution 3

Thanks both of you

it's solved by other way but there is other issue occurred which is regarding GDI+ error

which is

at save path

C#

Bitmap barcode = CreateBarcode(txtGenearte.Text);
barcode.Save(@"C:\barcode.gif",ImageFormat.Gif);=>A generic error occurred in GDI+.

Posted 29-Feb-16 21:51pm

kp564