Hi expert ! ! ! hash table in C code problem. ...

Question

1.00/5 (1 vote)

See more:

C++

#include<stdio.h>

typedef struct node_type{
    int data;
    struct node_type *link;
}node;

typedef node *list;

void add_to_list(int,int);
void show();

list bucket[10];

main()
{   
    int number;
    list tet;
    char ch;
    printf("Enter y if u want to input:\n");
    tet=bucket[0];
    scanf("%c",&ch);
    while(ch=='y'){
        printf("Enter numbers\n");
        scanf("%d\n",&number);
        add_to_list(number/10,number);
        scanf("%c",&ch);
        }
    show();
}


void  add_to_list(int index,int cut){
     list q,r,temp;
     int i;
     if (bucket[index] == NULL){
              q = bucket[index] =(list)malloc(sizeof (node));
              q->data=cut;
              q->link=NULL;
}
     else{  q=bucket[index];
            while(q->link!=NULL) q=q->link;
            if(q->link==NULL){
            temp=(list)malloc(sizeof(node));
            temp->data=cut;
            temp->link=NULL;
            q->link=temp;
}
}
}
/*To show every element in the table*/

void show(){

         int i;
         list pemp;
         for(i=0;i<10;i++){
             pemp= (list)malloc(sizeof(node));
             pemp=bucket[i];
             while(pemp!=NULL){
                      printf("%d ",pemp->data);
                      pemp=pemp->link;}
}
}

What I have tried:

Could anyone please suggest me what can I do here? The problem is when I gave same input for twice or, more than twice, the program crashed. But when I got two distinct value or even more value the program worked well......

Posted 8-Mar-16 7:58am

Member 12378355we

Updated 22-Mar-16 9:07am

v7

Add a Solution

Comments

jeron1 8-Mar-16 14:07pm

What exactly do you mean by "But it didn't work"?

Member 12378355we 8-Mar-16 14:16pm

When I compiled the code on code blocks, it crashed!!!

jeron1 8-Mar-16 14:19pm

By 'crashed' do you mean, it did not compile?

Member 12378355we 8-Mar-16 14:22pm

Yes.

jeron1 8-Mar-16 14:25pm

You should post the compilation error messages then.

RedDk 8-Mar-16 14:44pm

For starters be sure to reference "malloc.h". What tool, Visual Studio?

RedDk 8-Mar-16 15:20pm

Also, I don't see (either of these ... which is which I can't tell) an index in add_to_list just this "number/10"; and why is "cut" not colorful enough for me to determine what "cut" actually IS if I'm reading the code and you're ... dead?

RedDk 8-Mar-16 16:40pm

And note that "index" is defined but never used.

RedDk 8-Mar-16 17:18pm

And will "while" ever terminate when the expression (which technically it's not) becomes zero (no, because it's type is char)?

Hello?

Member 12378355we 12-Mar-16 16:22pm

Sorry for not replying on time...I updated my code. But could u suggest any idea on that...as the code still failed while i was putting same value for twice.:):)

RedDk 13-Mar-16 14:57pm

It's ok. I'm also no expert. But ... have a look at this guy's GITHUB entry:

https://gist.github.com/tonious/1377667

You've accepted some answer here but I don't see anything that even remotely qualifies as an answer as robust as the above link contents'.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

bling · Accepted Answer · 2016-03-09T10:41:00

Solution 3

"When I compiled the code on code blocks, it crashed!!!"

C++

q=bucket[index];
if(q==NULL){
    q->data=cut;
    q->link=NULL;

Yup. That will crash. Try this.

C++

if (bucket[index] == NULL)
{
    q = bucket[index] = (struct node *)malloc(sizeof node);
    q->data=cut;
    q->link=NULL;

This should get you started.

Posted 9-Mar-16 10:41am

bling

Comments

Member 12378355we 12-Mar-16 16:36pm

You are welcome! But when I input two same numbers then the program crashed again..... Help me please. I updated my code...

[no name] 14-Mar-16 12:44pm

In your else statement, you need to assign q to something before using it.

Member 12378355we 15-Mar-16 5:53am

Yes. And it's done. You real helpful........:)

OriginalGriff · Accepted Answer · 2016-03-08T08:35:00

Do yourself a favour and sort out your indentation!
If nothing else, it would make it obvious to you what the problem is!

main()
{   int number,index;
    list tet;
    char ch;
    printf("Enter y if u want to input:\n");
    tet=bucket[0];
    scanf("%c",&ch);
    while(ch=='y'){
        printf("Enter numbers\n");
        scanf("%d\n",&number);
        add_to_list(number/10,number);
        scanf("%c",&ch);
    }
    show();
}
} // <<<--- What is this closing?

Formatted:

main(){
    int number,index;
    list tet;
    char ch;
    printf("Enter y if u want to input:\n");
    tet=bucket[0];
    scanf("%c",&ch);
    while(ch=='y'){
        printf("Enter numbers\n");
        scanf("%d\n",&number);
        add_to_list(number/10,number);
        scanf("%c",&ch);
    }
    show();
}
}  // <<<--- It's obvious that is spurious.

Or better, don't use 1TB

main()
    {
    int number,index;
    list tet;
    char ch;
    printf("Enter y if u want to input:\n");
    tet=bucket[0];
    scanf("%c",&ch);
    while(ch=='y')
        {
        printf("Enter numbers\n");
        scanf("%d\n",&number);
        add_to_list(number/10,number);
        scanf("%c",&ch);
        }
    show();
    }
}  // <<<---- Still very obvious.

Your other code is even better at hiding things...:laugh:

Patrice T · Accepted Answer · 2016-03-08T08:37:00

Solution 2

I think there is one } too many at the end of main.

You should use an editor for programmer like UltraEdit or notepad++ or any other.
these editors are said "programmer editor" because they have feature that allow language highlight and automatic indentation or re-indentation.

Posted 8-Mar-16 8:37am

Patrice T

Comments

OriginalGriff 8-Mar-16 16:07pm

You can tell VS to support "straight" C rather than C++ as well.

Patrice T 8-Mar-16 16:13pm

Thank you.
I don't use VS :)

OriginalGriff 8-Mar-16 16:34pm

It's damn good, as IDEs go.
And being able to change the code while debugging it? Luxury! :laugh:

Patrice T 8-Mar-16 17:04pm

Unfortunately, my language of choice is not supported by VS
since 25 year A make and maintain apps in xBase family languages.

Hi expert ! ! ! hash table in C code problem. ...

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us