Why this simple code running too slowly on mobile phone?

Question

0.00/5 (No votes)

See more:

package MyGame;

import javax.microedition.lcdui.game.GameCanvas;
import javax.microedition.lcdui.game.Sprite;
import javax.microedition.lcdui.*;
///////

public class clsCanvas extends GameCanvas implements Runnable {

    private boolean isRunning = true;
    private Graphics g;
    private midMain fParent;

    ////////
    public Sprite cursor;
    public GameDesign gameDesign;
    ////
    public clsCanvas(midMain m) {
        super(true);
        fParent = m;
    }

        public void start(){
        Thread runner = new Thread(this);
        runner.start();
    }


    public void run() {
        this.gameDesign = new GameDesign();
        try{
        this.cursor = this.gameDesign.getCurs();
        this.cursor.defineReferencePixel(cursor.getWidth(), cursor.getHeight());
        }
        catch(Exception x){}
        int iKey = 0;
        g = getGraphics();
        g.setColor(200);
        g.fillRect(0, 0, 50, 50);
        cursor.paint(g);
        while (isRunning) {
            iKey = getKeyStates();

            if ((iKey & GameCanvas.FIRE_PRESSED) != 0) {
                isRunning = false;
            }

            if ((iKey & GameCanvas.RIGHT_PRESSED) != 0) {
        g.setColor(200);
        g.fillRect(0, 0, getWidth(), getHeight());
                cursor.setPosition(cursor.getX()+5, cursor.getY());
                cursor.paint(g);
            }
            if ((iKey & GameCanvas.LEFT_PRESSED) != 0) {
        g.setColor(200);
        g.fillRect(0, 0, getWidth(), getHeight());
                cursor.setPosition(cursor.getX()-5, cursor.getY());
                cursor.paint(g);
            }
            if ((iKey & GameCanvas.DOWN_PRESSED) != 0) {
        g.setColor(200);
        g.fillRect(0, 0, getWidth(), getHeight());
                cursor.setPosition(cursor.getX(), cursor.getY()+5);
                cursor.paint(g);
            }
            if ((iKey & GameCanvas.UP_PRESSED) != 0) {
        g.setColor(200);
        g.fillRect(0, 0, getWidth(), getHeight());
                cursor.setPosition(cursor.getX(), cursor.getY()-5);
                cursor.paint(g);
            }
            flushGraphics();
            try {
                Thread.sleep(10);
            } catch (Exception ex) {
            }
        }
        g = null;
       fParent.destroyApp(false);
       fParent = null;
    }

}

Moving cursor I'm waiting ~ 250ms per 1 step. Where is a problem?
I tried with Thread.sleep(50), 30 and 10 - all the same:(
(Filling full screen not affect on speed)
Please, help.

EDIT:
I replace IFs with this and any difference.

     while ((iKey & GameCanvas.RIGHT_PRESSED) != 0) {
                g.setColor(200);
                g.fillRect(0, 0, width, height);
                cursor.setPosition(cursor.getX()+5, cursor.getY());
                cursor.paint(g);
                flushGraphics();
                try{
                Thread.sleep(10);}
                catch(Exception x){}
            iKey = getKeyStates();
}

And if I quickly pressing RIGHT, cursor moving faster than I press and hold RIGHT key.

Posted 13-Sep-10 9:32am

halabella

Updated 15-Sep-10 0:50am

v4

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ARopo · Answer 1 · 2010-09-13T23:53:00

Solution 1

Is you code relying on an exception?

Why would Thread.Sleep ever throw an exception?

I suggest you do some analysis on each section of your code to findout how long it is in each section.

Sleep(10) in a loop should be enough.

Posted 13-Sep-10 23:53pm

ARopo

Comments

[no name] 15-Sep-10 6:49am

Works without any exceptions, and without "try{" I can't build the code.

#realJSOP · Answer 2 · 2010-09-15T02:07:00

I would refactor the code:

JavaScript

int height = getHeight();
int width  = getWidth();
while (isRunning) 
{
    iKey = getKeyStates();
    isRunning = ((iKey & GameCanvas.FIRE_PRESSED) != 0);
    if (isRunning)
    {
        int cursorX = cursor.GetX();
        int cursorY = cursor.GetY();
        bool refresh = false;
        if ((iKey & GameCanvas.RIGHT_PRESSED) != 0) 
        {
            refresh = true;
            cursorX += 5;
        }
        if ((iKey & GameCanvas.LEFT_PRESSED) != 0) 
        {
            refresh = true;
            cursorX -= 5;
        }
        if ((iKey & GameCanvas.DOWN_PRESSED) != 0) 
        {
            refresh = true;
            cursorY += 5;
        }
        if ((iKey & GameCanvas.UP_PRESSED) != 0) 
        {
            refresh = true;
            cursorY -= 5;
        }
	if (refresh)
        {
            g.setColor(200);
            g.fillRect(0, 0, width, height);
            cursor.setPosition(cursorX, cursorY);
            cursor.paint(g);
            flushGraphics();            
        }
    } 
    Thread.sleep(10);
}