Display function is not working in my linked-list program ?

Question

0.00/5 (No votes)

See more:

i am trying to add node at the starting of linked-list my code all the time just printing the last value which i entered what is the problem can any one clear it.

What I have tried:

#include <stdio.h>

struct node
{
    int data;
    struct node *next;

};

typedef struct node node ;
node *head;

void create(int num);
void display();

main()
{
    int num,i,n;

    printf("enter the nno of node to create : ");
    scanf("%d",&n);

    for(i=0;i<n;++i)
    {
        printf("enter data for node %d= ",i+1);
        scanf("%d",&num);
        create(num);
        display();
    }
}

void create(int num)
{
    head=NULL;
    node *temp;
    temp=(node*)malloc(sizeof(node));
    temp->data=num;
    temp->next=head;
    head=temp;
    return;
}
void display()
{
    node *temp1;
    temp1=head;

    while(temp1!=NULL)
    {
        printf("data : %d-> ",temp1->data);
        temp1=temp1->next;
    }
    return;
}

Posted 27-Jul-16 6:44am

Member 12656797

Updated 27-Jul-16 8:25am

Jochen Arndt

v2

Add a Solution

Comments

jeron1 27-Jul-16 12:59pm

head=NULL;
node *temp;
temp=(node*)malloc(sizeof(node));
temp->data=num;
temp->next=head; <== temp->next = head , which is always NULL

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2016-07-27T06:57:00

You are setting the head to NULL inside create() and assign that (now NULL) to next:

void create(int num)
{
    // This sets head to NULL. Remove it.
    head=NULL;
    node *temp;
    temp=(node*)malloc(sizeof(node));
    temp->data=num;
    // This will be NULL because head has been set to NULL above
    temp->next=head;
    head=temp;
    return;
}

So remove the indicated line and initialise head when declaring it:

C++

node head = NULL;

Patrice T · Answer 2 · 2016-07-27T08:25:00

You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jdb.html[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]

You have got an answer in solution 1.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
When the code don't do what is expected, you are close to a bug.

[Update]
In complement to Solution 1, put this line

C++

node head = NULL;

at beginning of main.

Display function is not working in my linked-list program ?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us