Take input from user console application C#

Question

1.00/5 (1 vote)

See more:

I am trying that when i input 10 random numbers on console then message will be display
these numbers are less than 10

e..g

if i input these random numbers
10,9,12,45,120,2,3,1,9,14
then
message display
9,2,3,1,9 are less than 10

i try this

What I have tried:

C#

public void p1()
{
   try
   {
       Console.WriteLine("Enter numbers");

       int num = Convert.ToInt32(Console.ReadLine());

       if (num < 10)
       {
           Console.WriteLine("less num",num);
           Console.ReadLine();

       }
       else
       {
           Console.WriteLine("Not less than num", num);
           Console.ReadLine();
       }
   }
   catch(Exception ex)
   {
       throw new Exception();
   }


}

but this work like that when i enter only 1 e.g. if i enter 9 number then message display less number and when i enter 12 then message display Not less than num

where as i want
i input 10 numbers and from that program identifies which numbers are less than 10

how i do that

CHECK THIS GIF
http://i.imgur.com/xmfiApI.gifv[^]

Posted 9-Oct-16 21:04pm

super_user

Updated 10-Oct-16 3:42am

Patrice T

v4

Add a Solution

Comments

Prabu_Anand22 10-Oct-16 3:20am

try getting the user inputs into an array of type int, then using a for loop, loop through the content checking for the values smaller or larger if so display the message as desired.

super_user 10-Oct-16 3:41am

http://i.imgur.com/xmfiApI.gifv

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2016-10-09T22:16:00

Solution 2

C#

int num = Convert.ToInt32(Console.ReadLine());

This line will only convert a single number, since that is what you have asked it to do. You should deal with multiple numbers by something like:

C#

string[] numbers = Console.ReadLine().split(" ");
foreach (string num in numbers)
{
    int num = Convert.ToInt32(num);
    // test for less or not
}

Note it is better to use TryParse rather than Convert to allow for the case when the user types invalid characters.

Posted 9-Oct-16 22:16pm

Richard MacCutchan

Comments

super_user 10-Oct-16 5:24am

this show error
Error 1 The best overloaded method match for 'string.Split(params char[])' has some invalid arguments
Error 2 Argument 1: cannot convert from 'string' to 'char[]'

Richard MacCutchan 10-Oct-16 5:35am

Then now would be a good time to go to the MSDN documentation and learn the String.split method(s).

Patrice T · Answer 2 · 2016-10-09T21:19:00

Quote:
but this work like that when i enter only 1 e.g. if i enter 9 number then message display less number and when i enter 12 then message display Not less than num

where as i want
i input 10 numbers and from that program identifies which numbers are less than 10

Your code is doing exactly what you requested.
How is it possible that you don't understand what the code is doing ? Is it your code ?

You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.

Member 12747274 · Answer 3 · 2016-10-09T23:44:00

Solution 4

I would have solved it this way:

C#

namespace check_Numbers
{
    class Program
    {
        static void Main(string[] args)
        {    
            string[] seperators = {",", " ", ";", "."};
            int num2;
            Console.WriteLine("Input numbers over 10:");

            string[] splitArray = Console.ReadLine().Split(seperators, StringSplitOptions.RemoveEmptyEntries);
            foreach (string num in splitArray)
            {

            If(Int32.TryParse(num, out num2) == true)
            {
                if (num2 < 10)
                {
                    Console.WriteLine(num + " is smaller than 10");
                }
            }
            else
            {
                Console.WriteLine(num + " is not a f***ing number...");
            }
            }
        }
    }
}

Posted 9-Oct-16 23:44pm

Member 12747274

Updated 10-Oct-16 22:02pm

v7

Comments

[no name] 10-Oct-16 6:52am

Why do you convert a string to a string? Why are you using Convert.ToInt32? What happens when the user types in 1 2 3 a b c?

Member 12747274 10-Oct-16 7:59am

Thank you for the feedback. First of all im a beginner in C# and I think the convertion of string into a string is a leftover from my troubleshooting of some strange problem i had with the ".Split". i couldn't integrate just a simple char (",") and i made a workaround with the string array. Yes, its absoultely unnecessary!

But for the Convert.ToInt: I did that to check if the number is smaller than 10?
I think it's needed or am I wrong? But yes you're right, i should "try and catch" this!

[no name] 10-Oct-16 8:27am

No you shouldn't use Convert at all. You will get an exception if someone types in anything other than a number. Should us int.TryParse which will not throw an exception if the conversion fails.

Member 12747274 10-Oct-16 9:22am

I updated my Code now, thanks for the advice. But now there is the Problem, that every character is seen as "under 10". Wouldn't be an exception + try and catch better, to return a failure message? Or is there a possibility to "ignore" character inputs?

[no name] 10-Oct-16 9:34am

Since TryParse returns a bool indicating success or failure, your error message would be shown in the else part of your if. Exceptions can be expensive in terms of processing so I try to avoid them as much as possible. You *could* catch the exception here but there is a better way to do it.

Member 12747274 11-Oct-16 4:03am

Okay, now I see. So I updated my code once again and now it should be worth using :D

Take input from user console application C#

3 solutions

Solution 2

Solution 1

Solution 4

Add your solution here

Preview 0

Existing Members

...or Join us