Find the mistake in the given problem

Question

0.00/5 (No votes)

See more:

Hi,
I have recently given an interview, where they asked one question to find the mistake in below code.

It would be helpful if anyone can describe...

C#

class Program
    {
        static void Main(string[] args)
        {
            int i = GetDecimalPlaces(0.001);
            Console.Write(i.ToString());
            Console.ReadLine();
        }

        public static int GetDecimalPlaces(double accuracy)
        {
            return Math.Min(0, -(int)(Math.Floor(Math.Log10(accuracy))));
            
        }
    }

answer should be "3" for "0.001".

Thank You.

What I have tried:

I have no idea about Log10.

Also I tried to google but there is no result.

Posted 29-Dec-16 18:33pm

Jagadeesh Bollabathini

Updated 18-Mar-23 11:28am

Add a Solution

Comments

CodeReady 30-Dec-16 0:55am

Why don't you try to debug this, you won't need google for that.

3 solutions

Solution 3

The mistake in the code is with the Math.Min function in the GetDecimalPlaces method. The first argument of Math.Min should be the first number to compare, and the second argument should be the second number to compare. In this code, the arguments are swapped, which will cause the function to always return 0.

To fix this mistake, simply swap the two arguments in the Math.Min function, like this:

sql
Copy code
public static int GetDecimalPlaces(double accuracy)
{
    return Math.Max(0, -(int)(Math.Floor(Math.Log10(accuracy))));
}
This will ensure that the function returns the correct number of decimal places for the given accuracy.

Posted 18-Mar-23 11:28am

Mohtady Ekmail 2023

Solution 2

Use the debugger to see what your code is doing. It allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing.
There is no magic in the debugger, it don't find bugs, it just help you to.

Posted 29-Dec-16 20:01pm

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter Leow · Accepted Answer · 2016-12-29T19:39:00

Solution 1

Logarithm10(x) will return the power that a base in this case 10, must raise in order to get the value x,
in this case, the x is 0.001, so log10(0.001) return -3, i.e. 10^(-3) = 0.001
Anyway, just change

Math.Min

to

Math.Max

Posted 29-Dec-16 19:39pm

Peter Leow

Updated 29-Dec-16 19:43pm

v2

Comments

Jagadeesh Bollabathini 30-Dec-16 3:30am

Yes.
It returns the answer as expected.