Switch case problem ! ! !

Question

0.00/5 (No votes)

See more:

Basically, i think i have problem with switch case when i press 1 the case begins but when i press 2 it should but it doesn't what is the problem !!

What I have tried:

	char answer;
		int choice;
		do
		{
			system("cls");
			system("Color F ");
			cout << "\t|  --------------------------------- |" << endl;
			cout << "\t|  Press 1 for Palying Game.    |" << endl;
			cout << "\t|  Press 2 Exit				   |" << endl;
			cout << "\t|  Enter Your Choice            |" << endl;
			cout << "\t|  -----------------------------|" << endl;
			cout << "\t   \t";
			cin >> choice;    //this 
			switch (choice)
			{
			case 1:
			{
				system("cls");
				system("color E");
				t.org();
			}
			break;
			case 2:
				default:
				break;
			}
		} while (choice == 2);
	}
	return 0;
}

Posted 8-Jan-17 22:55pm

mayashah

Updated 8-Jan-17 23:40pm

Richard MacCutchan

v2

Add a Solution

Comments

Richard MacCutchan 9-Jan-17 5:04am

case 2 does not do anything.

Ayodeji Oluwatomiwo 9-Jan-17 5:11am

the break after the first case will terminate further checkings
Try this and post back if it works so i can repost as Solution or there is any error for correction.

char answer;
      int choice;
       do
        {
         system("cls");
            system("Color F ");
           cout << "\t|  --------------------------------- |" << endl;
           cout << "\t|  Press 1 for Palying Game.    |" << endl;
            cout << "\t|  Press 2 Exit                   |" << endl;
          cout << "\t|  Enter Your Choice            |" << endl;
            cout << "\t|  -----------------------------|" << endl;
            cout << "\t   \t";
          cin >> choice;    //this 
           switch (choice)
           {
         case 1:
           {
             system("cls");
                system("color E");
                t.org();
                break;
          }
         case 2:
         {
              //your code for exit
              break;
         }
         default:
          //your code if no case is found also optional
     } while (choice == 2);
    }
 return 0;
}

3 solutions

Solution 3

Quote:
when i press 2 it should but it doesn't

It should but it don't what ?

You should learn to use the debugger as soon as possible, it is an incredible learning tool. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

Posted 8-Jan-17 23:40pm

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2017-01-08T23:13:00

Um...that's some odd code - and badly indented! You should try to get the indentation right, it makes reading the code a lot, lot easier. And if you are going to use curly brackets around a case code, then put it round the whole code, not just a bit of it - that just looks wrong and is confusing.
char answer;
int choice;

C++

do
    {
    system("cls");
    system("Color F ");
    cout << "\t|  --------------------------------- |" << endl;
    cout << "\t|  Press 1 for Playing Game.         |" << endl;
    cout << "\t|  Press 2 Exit                      |" << endl;
    cout << "\t|  Enter Your Choice                 |" << endl;
    cout << "\t|  --------------------------------- |" << endl;
    cout << "\t   \t";
    cin >> choice;    //this 
    switch (choice)
        {
        case 1:
            {
            system("cls");
            system("color E");
            t.org();
            break;
            }
        case 2:
        default:
            break;
        }
    } while (choice == 2);

See how much clearer it is what is going on?
I'd also suggest that the code inside a case should be as short as possible - so move the "play game" code into a separate function, and just call that inside the case. It makes the function smaller and easier to read, understand, and maintain.

Now...about the actual code...
The loop will execute once, unless the user presses 2 to exit, in which case it will go round again. Probably, you want:

C++

} while (choice != 2);

That may fix your problem!

Jochen Arndt · Accepted Answer · 2017-01-08T23:06:00

Solution 1

The problem is that your do while loop continues while choice is 2 and breaks if it is anything else.

So it should be probably:

C++

do
{
    // ...
} while (choice != 2);

Posted 8-Jan-17 23:06pm

Jochen Arndt